[bedrock] Migrate chrome::FindBrowserWithTab() callers to use BrowserWindowInterface* part4 [chromium/src : main]

0 views
Skip to first unread message

Qikai Zhong (Gerrit)

unread,
Mar 31, 2026, 3:33:26 AM (2 days ago) Mar 31
to Yu He, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, Chromium LUCI CQ, abigailbk...@google.com, armalhotra+a...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, yuzo+...@chromium.org
Attention needed from Yu He

Qikai Zhong added 1 comment

File chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
Line 683, Patchset 2 (Latest): views::Widget* widget = CreateMediaPickerDialogWidget(
browser_for_picker
? browser_for_picker->GetBrowserForMigrationOnly()
: nullptr,
Qikai Zhong . unresolved

Look like we can make a simple change in CreateMediaPickerDialogWidget to avoid this GetBrowserForMigrationOnly

Open in Gerrit

Related details

Attention is currently required from:
  • Yu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0adc6d64790a5933b23c01e956356c34a9e04d99
Gerrit-Change-Number: 7711312
Gerrit-PatchSet: 2
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Yu He <y...@microsoft.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 07:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yu He (Gerrit)

unread,
Apr 1, 2026, 5:51:49 AM (yesterday) Apr 1
to Qikai Zhong, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, Chromium LUCI CQ, abigailbk...@google.com, armalhotra+a...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, yuzo+...@chromium.org
Attention needed from Qikai Zhong

Yu He added 1 comment

File chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
Line 683, Patchset 2: views::Widget* widget = CreateMediaPickerDialogWidget(

browser_for_picker
? browser_for_picker->GetBrowserForMigrationOnly()
: nullptr,
Qikai Zhong . resolved

Look like we can make a simple change in CreateMediaPickerDialogWidget to avoid this GetBrowserForMigrationOnly

Yu He

ok

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0adc6d64790a5933b23c01e956356c34a9e04d99
    Gerrit-Change-Number: 7711312
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 09:51:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Qikai Zhong (Gerrit)

    unread,
    Apr 1, 2026, 6:26:30 AM (yesterday) Apr 1
    to Yu He, Tom Lukaszewicz, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, Chromium LUCI CQ, abigailbk...@google.com, armalhotra+a...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, yuzo+...@chromium.org
    Attention needed from Tom Lukaszewicz and Yu He

    Qikai Zhong voted and added 1 comment

    Votes added by Qikai Zhong

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Qikai Zhong . resolved

    LGTM.
    Hi, Tom, ptal~

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Lukaszewicz
    • Yu He
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0adc6d64790a5933b23c01e956356c34a9e04d99
    Gerrit-Change-Number: 7711312
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Yu He <y...@microsoft.com>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 10:25:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Lukaszewicz (Gerrit)

    unread,
    Apr 1, 2026, 2:05:02 PM (yesterday) Apr 1
    to Yu He, Qikai Zhong, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, Chromium LUCI CQ, abigailbk...@google.com, armalhotra+a...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, yuzo+...@chromium.org
    Attention needed from Yu He

    Tom Lukaszewicz voted and added 1 comment

    Votes added by Tom Lukaszewicz

    Code-Review+1

    1 comment

    Patchset-level comments
    Tom Lukaszewicz . resolved

    lgtm!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yu He
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0adc6d64790a5933b23c01e956356c34a9e04d99
    Gerrit-Change-Number: 7711312
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Yu He <y...@microsoft.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 18:04:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Qikai Zhong (Gerrit)

    unread,
    4:52 AM (10 hours ago) 4:52 AM
    to Yu He, Tom Lukaszewicz, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, Chromium LUCI CQ, abigailbk...@google.com, armalhotra+a...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, storage...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, yuzo+...@chromium.org
    Attention needed from Tom Lukaszewicz and Yu He

    Qikai Zhong voted and added 1 comment

    Votes added by Qikai Zhong

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Qikai Zhong . resolved

    Still LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Lukaszewicz
    • Yu He
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0adc6d64790a5933b23c01e956356c34a9e04d99
      Gerrit-Change-Number: 7711312
      Gerrit-PatchSet: 7
      Gerrit-Owner: Yu He <y...@microsoft.com>
      Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
      Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
      Gerrit-Reviewer: Yu He <y...@microsoft.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-Attention: Yu He <y...@microsoft.com>
      Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 08:52:22 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages