[PDF Ink Signatures] Fix skia font serialization [chromium/src : main]
0 views
Skip to first unread message
April Kallmeyer (Gerrit)
Jun 25, 2026, 6:01:19 PM (yesterday) Jun 25
to chromium...@chromium.org, chromium-a...@chromium.org, pdf-r...@chromium.org, extension...@chromium.org
April Kallmeyer has uploaded the change for review![]( "Open in Gerrit")
Commit message
[PDF Ink Signatures] Fix skia font serialization
System fonts like PengFeng on MacOS were sometimes failing skia
deserialization and this makes it succeed.
It's theoretically possible that there are some fonts that previously
were successfully loaded by FPDFText_LoadFont() with kDoIncludeData but
will not load with kIncludeDataIfLocal. However I don't know of any such
fonts and after this change we will be able to put the font name in a
CrashKey for later debugging.
Bug: 503013380
Change-Id: I84bd66fdb3d61152f1a50daeb1c845edde9354a8
Change diff
diff --git a/chrome/renderer/extensions/api/pdf_viewer_private_custom_bindings.cc b/chrome/renderer/extensions/api/pdf_viewer_private_custom_bindings.cc
index a476dae..3017a4dc 100644
--- a/chrome/renderer/extensions/api/pdf_viewer_private_custom_bindings.cc
+++ b/chrome/renderer/extensions/api/pdf_viewer_private_custom_bindings.cc
@@ -46,7 +46,7 @@
sk_sp<SkTypeface> font) {
CHECK(font);
sk_sp<SkData> serialized_font =
- font->serialize(SkTypeface::SerializeBehavior::kDoIncludeData);
+ font->serialize(SkTypeface::SerializeBehavior::kIncludeDataIfLocal);
if (!serialized_font) {
return {};
}
Change information
Files:
- M chrome/renderer/extensions/api/pdf_viewer_private_custom_bindings.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
April Kallmeyer (Gerrit)
Jun 25, 2026, 6:02:14 PM (yesterday) Jun 25
to Lei Zhang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Lei Zhang
April Kallmeyer voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
April Kallmeyer (Gerrit)
1:11 PM (7 hours ago) 1:11 PM
to Chromium LUCI CQ, Lei Zhang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Lei Zhang
April Kallmeyer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
April Kallmeyer . resolved
I manually tested this on Windows and Linux (in addition to the mac machine I developed this on) with a multi-font string and didn't have any problems loading fonts. I also checked with and without OOPIF and it all worked.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
1:32 PM (7 hours ago) 1:32 PM
to April Kallmeyer, Chromium LUCI CQ, Lei Zhang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from April Kallmeyer
Lei Zhang added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 1 (Latest):
System fonts like PengFeng on MacOS were sometimes failing skiaRelated details
Attention is currently required from:
- April Kallmeyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
1:34 PM (7 hours ago) 1:34 PM
to April Kallmeyer, Chromium LUCI CQ, Lei Zhang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from April Kallmeyer
Lei Zhang added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 1 (Latest):
will not load with kIncludeDataIfLocal. However I don't know of any such
fonts and after this change we will be able to put the font name in aRelated details
Attention is currently required from:
- April Kallmeyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
April Kallmeyer (Gerrit)
1:55 PM (7 hours ago) 1:55 PM
to Chromium LUCI CQ, Lei Zhang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Lei Zhang
April Kallmeyer added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 1 (Latest):
will not load with kIncludeDataIfLocal. However I don't know of any such
fonts and after this change we will be able to put the font name in aApril Kallmeyer
I believe nothing changes for emoji. It crashed at CHECK(font) before and it crashes at CHECK(font) after. So Noto Color Emoji was never successfully loaded by FPDFText_LoadFont() before.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
3:05 PM (6 hours ago) 3:05 PM
to April Kallmeyer, Chromium LUCI CQ, Lei Zhang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from April Kallmeyer
Lei Zhang added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 1 (Latest):
will not load with kIncludeDataIfLocal. However I don't know of any such
fonts and after this change we will be able to put the font name in aLei Zhang . resolved
April Kallmeyer
I believe nothing changes for emoji. It crashed at CHECK(font) before and it crashes at CHECK(font) after. So Noto Color Emoji was never successfully loaded by FPDFText_LoadFont() before.
Lei Zhang
OK. I was just thinking of other fonts that cause a crash in general.
Related details
Attention is currently required from:
- April Kallmeyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages