extensions: Add warning about networking to downloads API test file [chromium/src : main]
0 views
Skip to first unread message
James Cook (Gerrit)
Oct 27, 2025, 8:26:27 PM (2 days ago) Oct 27
to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Michael Wojcicka
James Cook added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
James Cook . resolved
Michael, please take a look. I wasted enough time on this I decided to add a warning for the next developer. Thanks.
Related details
Attention is currently required from:
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wojcicka (Gerrit)
Oct 27, 2025, 8:27:49 PM (2 days ago) Oct 27
to James Cook, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from James Cook
Michael Wojcicka voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- James Cook
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Oct 28, 2025, 1:48:23 PM (yesterday) Oct 28
to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
James Cook voted and added 1 comment![]( "Open in Gerrit")
Votes added by James Cook
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 28, 2025, 1:51:01 PM (yesterday) Oct 28
to James Cook, Michael Wojcicka, Achuith Bhandarkar, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
extensions: Add warning about networking to downloads API test file
The test bots on Android run with networking disabled in the emulator.
However, developers may choose to enable networking locally, so that
they can browse the web. This causes many downloads API tests to fail,
as they have specific expectations about networking behavior.
Add a warning about this to the top of the file.
Bug: none
Change-Id: I623cf5b2459dd8bcfdb9a0c58840d6aec1c65ef9
Reviewed-by: Michael Wojcicka <mw...@google.com>
Commit-Queue: James Cook <jame...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536780}
Files:
- M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
Change size: XS
Delta: 1 file changed, 8 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Wojcicka
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages