Use more standard enumerator names in TabMutedReason(tab enum Part1) [chromium/src : main]
0 views
Skip to first unread message
Jongmok Kim (Gerrit)
Oct 27, 2025, 7:45:13 PM (2 days ago) Oct 27
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org
Attention needed from Darryl James
Jongmok Kim added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 1:
Use more standard enumerator names in tab enum Part1Darryl James . resolved
Jongmok KimLet's update this commit message to clarify that this CL updates the enum entries for `TabMutedReason`
And then in the proceeding line we can briefly describe why we are making this change. Ex:
Update Enumerator Names to Match the Chromium Style Guide Part 1
Updates the TabMutedReason enum entries in order to follow the Chromium Style Guide naming conventions kFoo instead of FOO.
Thank you for your kind review!
Related details
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Oct 27, 2025, 7:45:30 PM (2 days ago) Oct 27
to Jongmok Kim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org
Attention needed from Jongmok Kim
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jongmok Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jongmok Kim (Gerrit)
Oct 27, 2025, 7:47:28 PM (2 days ago) Oct 27
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org
Jongmok Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jongmok Kim . resolved
Thank you for your kind review! 👍
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jongmok Kim (Gerrit)
Oct 27, 2025, 7:47:29 PM (2 days ago) Oct 27
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org
Jongmok Kim voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Oct 27, 2025, 7:49:12 PM (2 days ago) Oct 27
to Jongmok Kim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org
Attention needed from Jongmok Kim
Darryl James added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jongmok Kim . resolved
Thank you for your kind review! 👍
Attention is currently required from:
- Jongmok Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 27, 2025, 8:04:05 PM (2 days ago) Oct 27
to Jongmok Kim, Darryl James, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use more standard enumerator names in TabMutedReason(tab enum Part1)
Enumerators (for both scoped and unscoped enums) should be named like constants, not like macros. That is, use kNone not NONE.
https://google.github.io/styleguide/cppguide.html#Enumerator_Names
Bug: 40281257
Change-Id: I51f4890dd78ccdf8270b4ff4232a6288fd6560f2
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Jongmok Kim <jongm...@navercorp.com>
Cr-Commit-Position: refs/heads/main@{#1536337}
Files:
- M chrome/browser/content_settings/sound_content_setting_observer.cc
- M chrome/browser/content_settings/sound_content_setting_observer_unittest.cc
- M chrome/browser/extensions/api/tabs/tabs_api_non_android.cc
- M chrome/browser/extensions/extension_browser_window_helper.cc
- M chrome/browser/extensions/extension_tab_util.cc
- M chrome/browser/ui/tabs/tab_enums.h
- M chrome/browser/ui/tabs/tab_strip_model.cc
- M chrome/browser/ui/tabs/tab_utils.cc
- M chrome/browser/ui/tabs/tab_utils.h
- M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
Change size: M
Delta: 10 files changed, 30 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages