Move DOM API to //extensions [chromium/src : main]

0 views
Skip to first unread message

Miyoung Shin (Gerrit)

unread,
Jun 19, 2026, 6:22:33 AM (7 days ago) Jun 19
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin

Miyoung Shin voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7f8b8749dadbc49e3aa3fb38d41e1dee3d732d60
Gerrit-Change-Number: 7966019
Gerrit-PatchSet: 1
Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Jun 2026 10:22:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Devlin Cronin (Gerrit)

unread,
5:27 PM (4 hours ago) 5:27 PM
to Miyoung Shin, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Miyoung Shin

Devlin Cronin voted and added 2 comments

Votes added by Devlin Cronin

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Devlin Cronin . resolved

Thanks, Miyoung! LGTM % nit

File extensions/common/api/_api_features.json
Line 188, Patchset 1 (Latest): "dom": {
"channel": "stable",
"contexts": ["privileged_extension", "content_script"]
},
Devlin Cronin . unresolved

nit: please put this above dns

Open in Gerrit

Related details

Attention is currently required from:
  • Miyoung Shin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7f8b8749dadbc49e3aa3fb38d41e1dee3d732d60
Gerrit-Change-Number: 7966019
Gerrit-PatchSet: 1
Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
Gerrit-Attention: Miyoung Shin <myid...@igalia.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 21:27:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages