[Extensions] Clean up event listeners in ExtensionsDropOverlay [chromium/src : main]

0 views
Skip to first unread message

Ehtesham Zahid (Gerrit)

unread,
Feb 9, 2026, 5:51:26 AM (11 days ago) Feb 9
to Devlin Cronin, Kelvin Jiang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin and Kelvin Jiang

Ehtesham Zahid voted and added 1 comment

Votes added by Ehtesham Zahid

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ehtesham Zahid . resolved

Hi Kelvin and Devlin!

While working on my previous CL, I noticed the TODO in drop_overlay.ts regarding a listener leak on document.documentElement. This CL addresses that by moving the listener logic to the proper lifecycle methods and utilizing an EventTracker for cleanup.

Since I don't have dry-runner permissions yet, could a reviewer please trigger the CQ Dry Run for me?

PTAL! Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
  • Kelvin Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
Gerrit-Change-Number: 7558230
Gerrit-PatchSet: 1
Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Comment-Date: Mon, 09 Feb 2026 10:51:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Devlin Cronin (Gerrit)

unread,
Feb 9, 2026, 4:15:10 PM (10 days ago) Feb 9
to Ehtesham Zahid, Devlin Cronin, Chromium LUCI CQ, Kelvin Jiang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Ehtesham Zahid and Kelvin Jiang

Devlin Cronin voted and added 1 comment

Votes added by Devlin Cronin

Commit-Queue+1

1 comment

Patchset-level comments
Devlin Cronin . resolved

Thanks, Ehtesham! I'll take a look after Kelvin stamps, but I'll kick off a dry run now.

Open in Gerrit

Related details

Attention is currently required from:
  • Ehtesham Zahid
  • Kelvin Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
Gerrit-Change-Number: 7558230
Gerrit-PatchSet: 1
Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 21:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ehtesham Zahid (Gerrit)

unread,
Feb 10, 2026, 3:04:01 AM (10 days ago) Feb 10
to Devlin Cronin, Chromium LUCI CQ, Kelvin Jiang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin and Kelvin Jiang

Ehtesham Zahid added 1 comment

Patchset-level comments
Devlin Cronin . resolved

Thanks, Ehtesham! I'll take a look after Kelvin stamps, but I'll kick off a dry run now.

Ehtesham Zahid

Thanks for triggering the dry run, Devlin! Glad to see it passed the bots. I'll wait for Kelvin's review. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
  • Kelvin Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
Gerrit-Change-Number: 7558230
Gerrit-PatchSet: 2
Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 08:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Devlin Cronin <rdevlin...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kelvin Jiang (Gerrit)

unread,
Feb 12, 2026, 5:02:00 PM (7 days ago) Feb 12
to Ehtesham Zahid, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Ehtesham Zahid

Kelvin Jiang voted and added 1 comment

Votes added by Kelvin Jiang

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kelvin Jiang . resolved

LGTM thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Ehtesham Zahid
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
Gerrit-Change-Number: 7558230
Gerrit-PatchSet: 2
Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 22:01:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ehtesham Zahid (Gerrit)

unread,
Feb 17, 2026, 1:51:22 PM (3 days ago) Feb 17
to Kelvin Jiang, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Ehtesham Zahid added 1 comment

Patchset-level comments
Ehtesham Zahid . resolved

Hi Devlin! Just a gentle ping on this. Kelvin has stamped (+1) and the dry run is green, so this should be ready for your final look. Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
Gerrit-Change-Number: 7558230
Gerrit-PatchSet: 2
Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Feb 2026 18:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ehtesham Zahid (Gerrit)

unread,
Feb 19, 2026, 6:27:02 AM (21 hours ago) Feb 19
to Demetrios Papadopoulos, Kelvin Jiang, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Kelvin Jiang

Ehtesham Zahid added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Ehtesham Zahid . resolved

Hi Kelvin and Devlin, I've rebased to resolve the conflict and integrated the new fire() helper into the fix. Could you please take a look? If everything looks good, I'd appreciate a CQ dry run. Hopefully, this is ready to land! Thanks! (CC'ing dpapad as they recently refactored this file).

Open in Gerrit

Related details

Attention is currently required from:
  • Kelvin Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
Gerrit-Change-Number: 7558230
Gerrit-PatchSet: 5
Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-CC: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Feb 2026 11:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Demetrios Papadopoulos (Gerrit)

unread,
Feb 19, 2026, 1:48:16 PM (13 hours ago) Feb 19
to Ehtesham Zahid, Kelvin Jiang, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Ehtesham Zahid and Kelvin Jiang

Demetrios Papadopoulos added 1 comment

Commit Message
Line 11, Patchset 5 (Latest):them. This resulted in a memory leak where listeners accumulated
every time the extensions page was opened.
Demetrios Papadopoulos . unresolved

Are you sure about this? While `extensions-drop-overlay` indeed wasn't removing the document listener, it is only added once in the DOM at [1]. So it wouldn't leak any listeners, at least not in prod code (perhaps in tests where things get attached and detached multiple times).

Closing the extensions WebUI shouldn't leave any lingering listeners or memory leaks as the entire renderer is destroyed.

I don't think the assessment above is accurate.

(although adding and removing listeners is the recommended approach anyway).

[1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/extensions/manager.html.ts;l=12;drc=13775c0341adad4615778458aa27bd361c1e9e14

Open in Gerrit

Related details

Attention is currently required from:
  • Ehtesham Zahid
  • Kelvin Jiang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
    Gerrit-Change-Number: 7558230
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
    Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-CC: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Attention: Ehtesham Zahid <ehtesham...@gmail.com>
    Gerrit-Comment-Date: Thu, 19 Feb 2026 18:48:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kelvin Jiang (Gerrit)

    unread,
    Feb 19, 2026, 11:31:42 PM (3 hours ago) Feb 19
    to Ehtesham Zahid, Demetrios Papadopoulos, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Ehtesham Zahid

    Kelvin Jiang voted and added 1 comment

    Votes added by Kelvin Jiang

    Code-Review+1

    1 comment

    Patchset-level comments
    Kelvin Jiang . resolved

    LGTM but do edit the commit message re: dpapad's comment

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ehtesham Zahid
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5ea1b4b42aaeb8271bf415d60f2808b7b537fc61
    Gerrit-Change-Number: 7558230
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ehtesham Zahid <ehtesham...@gmail.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Ehtesham Zahid <ehtesham...@gmail.com>
    Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-CC: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Attention: Ehtesham Zahid <ehtesham...@gmail.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 04:31:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages