mbsa: Set ListMenuButton state to 'pressed' when menu is open [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Feb 19, 2026, 1:44:35 AM (24 hours ago) Feb 19
to chromium...@chromium.org, peilinwa...@google.com, chromium-a...@chromium.org, hanxi...@chromium.org, extension...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

mbsa: Set ListMenuButton state to 'pressed' when menu is open

mbsa = menu buttons stay active

This CL tweaks the `ListMenuButton` so that when it has its menu open,
the button gets the "active" state. This will allow users to tell which
menu is open, especially when the `ListMenuButtons` are placed closer
together.
Bug: 467851075
Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9

Change diff


Change information

Files:
  • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuButton.java
  • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuHost.java
Change size: S
Delta: 2 files changed, 41 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
Gerrit-Change-Number: 7592215
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Feb 19, 2026, 3:01:16 AM (23 hours ago) Feb 19
to chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2:
Masa Fujita . resolved

Hi Jenna, a very small cosmetic project - ptal!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
Gerrit-Change-Number: 7592215
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 08:00:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jenna Himawan (Gerrit)

unread,
Feb 19, 2026, 2:07:10 PM (11 hours ago) Feb 19
to Masa Fujita, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Attention needed from Masa Fujita

Jenna Himawan added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jenna Himawan . unresolved

Thanks! I wanted to check: if a user uses the keyboard to activate a menu, what does this look like? Does the source button have the keyboard focus ring? If so, is that a desired behavior?

Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
    Gerrit-Change-Number: 7592215
    Gerrit-PatchSet: 3
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Attention: Masa Fujita <mas...@google.com>
    Gerrit-Comment-Date: Thu, 19 Feb 2026 19:07:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Masa Fujita (Gerrit)

    unread,
    Feb 19, 2026, 7:23:46 PM (6 hours ago) Feb 19
    to Jenna Himawan, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
    Attention needed from Jenna Himawan

    Masa Fujita added 1 comment

    Patchset-level comments
    Jenna Himawan . unresolved

    Thanks! I wanted to check: if a user uses the keyboard to activate a menu, what does this look like? Does the source button have the keyboard focus ring? If so, is that a desired behavior?

    Masa Fujita

    Yes, it will have a focus ring and it's the desired (& unchanged) behavior.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jenna Himawan
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
    Gerrit-Change-Number: 7592215
    Gerrit-PatchSet: 3
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Attention: Jenna Himawan <jhim...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 00:23:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jenna Himawan <jhim...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jenna Himawan (Gerrit)

    unread,
    Feb 19, 2026, 7:31:46 PM (6 hours ago) Feb 19
    to Masa Fujita, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
    Attention needed from Masa Fujita

    Jenna Himawan voted and added 1 comment

    Votes added by Jenna Himawan

    Code-Review+1

    1 comment

    Patchset-level comments
    Jenna Himawan . resolved

    Thanks! I wanted to check: if a user uses the keyboard to activate a menu, what does this look like? Does the source button have the keyboard focus ring? If so, is that a desired behavior?

    Masa Fujita

    Yes, it will have a focus ring and it's the desired (& unchanged) behavior.

    Jenna Himawan

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Masa Fujita
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
    Gerrit-Change-Number: 7592215
    Gerrit-PatchSet: 3
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Attention: Masa Fujita <mas...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 00:31:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Masa Fujita <mas...@google.com>
    Comment-In-Reply-To: Jenna Himawan <jhim...@google.com>
    satisfied_requirement
    open
    diffy

    Masa Fujita (Gerrit)

    unread,
    Feb 19, 2026, 8:25:54 PM (5 hours ago) Feb 19
    to Jenna Himawan, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

    Masa Fujita voted and added 1 comment

    Votes added by Masa Fujita

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Masa Fujita . resolved

    Thanks for the review!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
    Gerrit-Change-Number: 7592215
    Gerrit-PatchSet: 3
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 01:25:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Masa Fujita (Gerrit)

    unread,
    Feb 19, 2026, 8:31:15 PM (5 hours ago) Feb 19
    to Jenna Himawan, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

    Masa Fujita voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
    Gerrit-Change-Number: 7592215
    Gerrit-PatchSet: 4
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 01:30:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 19, 2026, 8:33:37 PM (5 hours ago) Feb 19
    to Masa Fujita, Jenna Himawan, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    mbsa: Set ListMenuButton state to 'pressed' when menu is open

    mbsa = menu buttons stay active

    This CL tweaks the `ListMenuButton` so that when it has its menu open,
    the button gets the "active" state. This will allow users to tell which
    menu is open, especially when the `ListMenuButtons` are placed closer
    together.

    Bug: 467851075
    Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9
    Reviewed-by: Jenna Himawan <jhim...@google.com>
    Commit-Queue: Masa Fujita <mas...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1587552}
    Files:
    • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuButton.java
    • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuButtonTest.java
    • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuHost.java
    • M ui/android/junit/src/org/chromium/ui/listmenu/ListMenuHostUnitTest.java
    Change size: M
    Delta: 4 files changed, 105 insertions(+), 26 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jenna Himawan
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: Ib394c1073a0c3018d6725e7db47335e4b52477a9 
    

     Gerrit-Change-Number: 7592215 
    

     Gerrit-PatchSet: 5 
    

     Gerrit-Owner: Masa Fujita <mas...@google.com> 
    

     Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
    

     Gerrit-Reviewer: Jenna Himawan <jhim...@google.com> 
    

     Gerrit-Reviewer: Masa Fujita <mas...@google.com> 
    

    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages