[PWA/AppMigration] Add launch after migration completes, tests [chromium/src : main]

[Daniel Murphy (Gerrit)]

Attention needed from Marijn Kruisselbrink

Daniel Murphy voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Marijn Kruisselbrink

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a57d293e8c5e73c049c109b34e5f3a05ca5cee3

Gerrit-Change-Number: 7590868

Gerrit-PatchSet: 1

Gerrit-Owner: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 00:38:40 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Marijn Kruisselbrink (Gerrit)]

Attention needed from Daniel Murphy

Marijn Kruisselbrink added 3 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Marijn Kruisselbrink . resolved

generally seems fine

File chrome/test/data/web_apps/migration/migrate_from/manifest_suggested.json

Line 13, Patchset 1 (Latest): "migration": {

Marijn Kruisselbrink . unresolved

I assume you meant migrate_to?

File chrome/test/data/web_apps/migration/migrate_to/manifest_suggest_install_url_confirmed.json

File-level comment, Patchset 1 (Latest):

Marijn Kruisselbrink . unresolved

I don't understand the "confirmed" vs "unconfirmed" nature of these two files, or what the difference is. I guess both of these have an install_url in their migrate from field. But for now I don't think we're planning to actually implement anything that does anything with that install url, so I don't think we need to worry about having test data for something we're not currently working on (aside, I guess we should double check with partners if install_url in migrate_from/possibly updating the unmigrated app is still something on their needs). So maybe for now leave out these files with install url in migrate from?

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Murphy

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a57d293e8c5e73c049c109b34e5f3a05ca5cee3

Gerrit-Change-Number: 7590868

Gerrit-PatchSet: 1

Gerrit-Owner: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Daniel Murphy <dmu...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 17:49:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Daniel Murphy (Gerrit)]

Attention needed from Marijn Kruisselbrink

Daniel Murphy added 2 comments

File chrome/test/data/web_apps/migration/migrate_from/manifest_suggested.json

Line 13, Patchset 1: "migration": {

Marijn Kruisselbrink . resolved

I assume you meant migrate_to?

Daniel Murphy

Done

File chrome/test/data/web_apps/migration/migrate_to/manifest_suggest_install_url_confirmed.json

File-level comment, Patchset 1:

Marijn Kruisselbrink . resolved

I don't understand the "confirmed" vs "unconfirmed" nature of these two files, or what the difference is. I guess both of these have an install_url in their migrate from field. But for now I don't think we're planning to actually implement anything that does anything with that install url, so I don't think we need to worry about having test data for something we're not currently working on (aside, I guess we should double check with partners if install_url in migrate_from/possibly updating the unmigrated app is still something on their needs). So maybe for now leave out these files with install url in migrate from?

Daniel Murphy

Done.

Open in Gerrit

Related details

Attention is currently required from:

• Marijn Kruisselbrink

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a57d293e8c5e73c049c109b34e5f3a05ca5cee3

Gerrit-Change-Number: 7590868

Gerrit-PatchSet: 2

Gerrit-Owner: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 20:17:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Marijn Kruisselbrink <m...@chromium.org>

[Daniel Murphy (Gerrit)]

Attention needed from Marijn Kruisselbrink

Daniel Murphy voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

• Marijn Kruisselbrink

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a57d293e8c5e73c049c109b34e5f3a05ca5cee3

Gerrit-Change-Number: 7590868

Gerrit-PatchSet: 2

Gerrit-Owner: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 20:17:48 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Daniel Murphy (Gerrit)]

Attention needed from Hidehiko Abe and Marijn Kruisselbrink

Daniel Murphy voted and added 1 comment

Votes added by Daniel Murphy

Auto-Submit

+0

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Daniel Murphy . resolved

+hidehiko for the app_service changes to add the new enum.

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe
• Marijn Kruisselbrink

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a57d293e8c5e73c049c109b34e5f3a05ca5cee3

Gerrit-Change-Number: 7590868

Gerrit-PatchSet: 2

Gerrit-Owner: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 20:18:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Marijn Kruisselbrink (Gerrit)]

Attention needed from Daniel Murphy and Hidehiko Abe

Marijn Kruisselbrink voted and added 1 comment

Votes added by Marijn Kruisselbrink

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Marijn Kruisselbrink . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Murphy
• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a57d293e8c5e73c049c109b34e5f3a05ca5cee3

Gerrit-Change-Number: 7590868

Gerrit-PatchSet: 2

Gerrit-Owner: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Daniel Murphy <dmu...@chromium.org>

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 20:27:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Hidehiko Abe (Gerrit)]

Attention needed from Daniel Murphy

Hidehiko Abe added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Hidehiko Abe . resolved

bots looks failing. Could you check?

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Murphy

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a57d293e8c5e73c049c109b34e5f3a05ca5cee3

Gerrit-Change-Number: 7590868

Gerrit-PatchSet: 2

Gerrit-Owner: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Daniel Murphy <dmu...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 02:26:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No