[Extensions] V2 of Zero State Promo Chips IPH. [chromium/src : main]
0 views
Skip to first unread message
Emilia Paz (Gerrit)
Oct 27, 2025, 6:19:49 PM (3 days ago) Oct 27
to Yiming Zhou, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Yiming Zhou
Emilia Paz added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Emilia Paz . resolved
extensions/ lgtm, thanks
I like the new version :)
File chrome/browser/ui/webui/extensions_zero_state_promo/extensions_zero_state_promo_interactive_uitest.cc
Line 145, Patchset 5 (Parent):
// TODO(crbug.com/419854475): Re-enable this test once the bug is fixed.Emilia Paz . unresolved
Was this fixed by this CL? Seems unrelated. Could do in separate CL so it's more clear, here is fine too
(same for others)
Related details
Attention is currently required from:
- Dana Fried
- Yiming Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 27, 2025, 6:19:57 PM (3 days ago) Oct 27
to Yiming Zhou, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Yiming Zhou
Emilia Paz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dana Fried
- Yiming Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiming Zhou (Gerrit)
Oct 27, 2025, 7:33:46 PM (3 days ago) Oct 27
to Emilia Paz, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Emilia Paz
Yiming Zhou added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/webui/extensions_zero_state_promo/extensions_zero_state_promo_interactive_uitest.cc
Line 145, Patchset 5 (Parent):
// TODO(crbug.com/419854475): Re-enable this test once the bug is fixed.Emilia Paz . resolved
Was this fixed by this CL? Seems unrelated. Could do in separate CL so it's more clear, here is fine too
(same for others)
Yiming Zhou
Oh the bug was fixed quite sometime ago in https://chromium-review.googlesource.com/6580524. I just opportunistically removed this line, since the test is clearly enabled 😊
Related details
Attention is currently required from:
- Dana Fried
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 27, 2025, 7:52:24 PM (3 days ago) Oct 27
to Yiming Zhou, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Yiming Zhou
Emilia Paz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dana Fried
- Yiming Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Oct 28, 2025, 1:33:41 PM (3 days ago) Oct 28
to Yiming Zhou, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Yiming Zhou
Dana Fried added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Yiming Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiming Zhou (Gerrit)
Oct 28, 2025, 1:46:46 PM (3 days ago) Oct 28
to Emilia Paz, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Emilia Paz
Yiming Zhou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Tests are failing; can you fix them?
Attention is currently required from:
- Dana Fried
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiming Zhou (Gerrit)
Oct 29, 2025, 1:05:45 PM (2 days ago) Oct 29
to Emilia Paz, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Emilia Paz
Yiming Zhou added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Dana Fried . resolved
Yiming ZhouTests are failing; can you fix them?
Should be fixed. I will wait for tryjob results.
Yiming Zhou
Tests are fixed.
File chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler.cc
File-level comment, Patchset 9 (Latest):
Yiming Zhou . unresolved
Please fix this WARNING reported by ClangTidy: warning: building this file or its dependencies failed; no diagnostics will be i...
warning: building this file or its dependencies failed; no diagnostics will be issued.
(Lint observed on `mac-clang-tidy-rel`, but not on `android-clang-tidy-rel` or `linux-clang-tidy-rel`)
Related details
Attention is currently required from:
- Dana Fried
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiming Zhou (Gerrit)
Oct 29, 2025, 1:06:49 PM (2 days ago) Oct 29
to Emilia Paz, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Emilia Paz
Yiming Zhou added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler.cc
Yiming Zhou . resolved
Please fix this WARNING reported by ClangTidy: warning: building this file or its dependencies failed; no diagnostics will be i...
warning: building this file or its dependencies failed; no diagnostics will be issued.
(Lint observed on `mac-clang-tidy-rel`, but not on `android-clang-tidy-rel` or `linux-clang-tidy-rel`)
Yiming Zhou
Acknowledged
Related details
Attention is currently required from:
- Dana Fried
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Oct 29, 2025, 1:23:16 PM (2 days ago) Oct 29
to Yiming Zhou, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz and Yiming Zhou
Dana Fried added 2 comments![]( "Open in Gerrit")
File chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.html.ts
Line 54, Patchset 9 (Latest):
<div class="darkThemeChip">Dana Fried . unresolved
We should not call these "light" and "dark" or reference "theme" here because dark vs. light mode could invert these values.
Please use v1 and v2 or something.
File components/feature_engagement/public/feature_constants.h
Line 66, Patchset 9 (Latest):
kCustomUiChipIphV2,Dana Fried . unresolved
Are these values ever persisted in UMA data? My recollection is, not directly, correct?
Related details
Attention is currently required from:
- Emilia Paz
- Yiming Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiming Zhou (Gerrit)
Oct 29, 2025, 1:40:39 PM (2 days ago) Oct 29
to Emilia Paz, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Emilia Paz
Yiming Zhou added 2 comments![]( "Open in Gerrit")
File chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.html.ts
We should not call these "light" and "dark" or reference "theme" here because dark vs. light mode could invert these values.
Please use v1 and v2 or something.
Yiming Zhou
Done
File components/feature_engagement/public/feature_constants.h
Are these values ever persisted in UMA data? My recollection is, not directly, correct?
Yiming Zhou
Do you mean if anything needs to be changed in the metrics/histogram xml files? No, there are no references to the IPH variations there.
Related details
Attention is currently required from:
- Dana Fried
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Oct 29, 2025, 8:17:03 PM (2 days ago) Oct 29
to Yiming Zhou, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Emilia Paz
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dana Fried
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 30, 2025, 12:30:20 PM (18 hours ago) Oct 30
to Yiming Zhou, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Yiming Zhou
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Yiming Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Oct 30, 2025, 1:01:56 PM (17 hours ago) Oct 30
to Yiming Zhou, Chromium LUCI CQ, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Yiming Zhou
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Yiming Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiming Zhou (Gerrit)
Oct 30, 2025, 2:07:28 PM (16 hours ago) Oct 30
to Dana Fried, Chromium LUCI CQ, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Yiming Zhou voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 30, 2025, 2:11:07 PM (16 hours ago) Oct 30
to Yiming Zhou, Dana Fried, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] V2 of Zero State Promo Chips IPH.
This change introduces V2 of the Extensions Zero State Promo chips IPH, which highlights the chips in a light theme. Also shuffles the chips selection to place the more popular chips first.
Our initial 4% stable rollout of the Extensions Zero State Promo IPH tells us that while users respond to the 'Chips' variant of the IPH the most, most of them do not realize that the chips in the IPH are clickable. This new variant attempts to address this problem by highlighting the chips with greater contrast.
Comparisons of V1 vs V2: https://screenshot.googleplex.com/6Ko2mXcaZzVbdUv
Screenshot of V2: https://screenshot.googleplex.com/5yafPEpiTy8JFaN
Bug: 409573170
Change-Id: I8ebc10f02021a326c438b1d772b844367f3908f1
Reviewed-by: Dana Fried <dfr...@chromium.org>
Reviewed-by: Emilia Paz <emil...@chromium.org>
Commit-Queue: Yiming Zhou <uwyi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1538068}
Files:
- M chrome/app/extensions_strings.grdp
- A chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_IPH_WEB_STORE_LINK.png.sha1
- M chrome/browser/resources/extensions_zero_state_promo/icons.html
- M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.css
- M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.html.ts
- M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.ts
- M chrome/browser/ui/views/user_education/browser_user_education_service.cc
- M chrome/browser/ui/webui/extensions_zero_state_promo/extensions_zero_state_promo_interactive_uitest.cc
- M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler.cc
- M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_ui.cc
- M chrome/test/data/webui/extensions_zero_state/zero_state_promo_app_test.ts
- M chrome/test/data/webui/extensions_zero_state/zero_state_promo_browsertest.cc
- M components/feature_engagement/public/feature_constants.cc
- M components/feature_engagement/public/feature_constants.h
- M extensions/common/extension_urls.cc
- M extensions/common/extension_urls.h
- M extensions/common/switches.cc
- M extensions/common/switches.h
Change size: L
Delta: 18 files changed, 450 insertions(+), 67 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dana Fried, +1 by Emilia Paz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 30, 2025, 7:45:11 PM (10 hours ago) Oct 30
to Chromium LUCI CQ, Yiming Zhou, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Emilia Paz has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages