[iOS]Deal with nil full name [chromium/src : main]

0 views

Skip to first unread message

Arthur Milchior (Gerrit)

unread,

Mar 11, 2026, 11:54:34 AM (yesterday) Mar 11

to Jérôme Lebel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Jérôme Lebel

Arthur Milchior voted and added 2 comments

Votes added by Arthur Milchior

Auto-Submit

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Arthur Milchior . resolved

Hi Jérôme,

I’d appreciate your opinion before looking for an owner of everything

File ios/chrome/browser/authentication/ui_bundled/cells/central_account_view.h

Line 31, Patchset 2 (Parent):- (NSString*)name;

Arthur Milchior . unresolved

Those properties are renamed because `name` may be set to the email value, which was misleading

Open in Gerrit

Related details

Attention is currently required from:

Jérôme Lebel

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jérôme Lebel (Gerrit)

unread,

10:17 AM (2 hours ago) 10:17 AM

to Arthur Milchior, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Arthur Milchior

Jérôme Lebel voted and added 6 comments

Votes added by Jérôme Lebel

Code-Review

6 comments

File components/autofill/core/browser/data_manager/addresses/account_name_email_store.h

Line 81, Patchset 5 (Latest): // `account_name` may be empty if the name has not yet been loaded.

Jérôme Lebel . unresolved

I think it would be more relevant to have a comment:
`If `account_name` is empty, this method does nothing.`

File components/autofill/core/browser/data_manager/addresses/address_data_manager.h

Line 320, Patchset 5 (Latest): // IOS. `account_name` may be empty if the name has not been loaded.

Jérôme Lebel . unresolved

Same here.

File ios/chrome/browser/authentication/ui_bundled/cells/central_account_view.h

Line 31, Patchset 2 (Parent):- (NSString*)name;

Arthur Milchior . resolved

Those properties are renamed because `name` may be set to the email value, which was misleading

Jérôme Lebel

Acknowledged

File ios/chrome/browser/ntp/ui_bundled/new_tab_page_header_view_controller.mm

Line 1087, Patchset 5 (Latest):// `name` may be nil, `email` may not be nil.

Jérôme Lebel . unresolved

From a non english native speaker, I would have a preference with `must not be be nil`.

File ios/chrome/browser/signin/model/signin_util.mm

Line 206, Patchset 5 (Latest):NSString* UserGivenName(id<SystemIdentity> identity) {

Jérôme Lebel . unresolved

I would rename this `UserGivenNameFullNameOrEmail()`. That would be an easy way for the caller to use it as the given name, and the show the email next to it.

Line 214, Patchset 5 (Latest):NSString* UserFullName(id<SystemIdentity> identity) {

Jérôme Lebel . unresolved

`UserFullNameOrEmail()`

Open in Gerrit

Related details

Attention is currently required from:

Arthur Milchior

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages