[Extensions] Port chrome.tabs.discard to desktop Android [chromium/src : main]

0 views
Skip to first unread message

Kelvin Jiang (Gerrit)

unread,
Feb 19, 2026, 10:27:25 PM (5 hours ago) Feb 19
to Keigo Oka, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Keigo Oka

Kelvin Jiang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keigo Oka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iff2dd41240b2254924722b5c87d92abe3def6866
Gerrit-Change-Number: 7594963
Gerrit-PatchSet: 3
Gerrit-Owner: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Keigo Oka <o...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 03:27:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

James Cook (Gerrit)

unread,
Feb 19, 2026, 10:48:08 PM (4 hours ago) Feb 19
to Kelvin Jiang, Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Darryl James and Kelvin Jiang

James Cook added 5 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
James Cook . resolved

Overall shape looks good. A couple comments.

File chrome/browser/extensions/BUILD.gn
Line 639, Patchset 3 (Parent): "api/tabs/tabs_api_android.cc",
James Cook . unresolved

Hooray!

Line 656, Patchset 3 (Parent): "api/tabs/tabs_api_non_android.cc",
James Cook . unresolved

Hooray!

File chrome/browser/extensions/api/tabs/tabs_api.cc
Line 3688, Patchset 3 (Latest): int tab_index;
James Cook . unresolved

nit: initialize this

Line 3699, Patchset 3 (Latest): BrowserWindowInterface* browser_window =
James Cook . unresolved

nit: Check browser_window for null before using it. On ChromeOS it can be null for unusual window types. See https://chromium-review.googlesource.com/c/chromium/src/+/7596693

Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
  • Kelvin Jiang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iff2dd41240b2254924722b5c87d92abe3def6866
    Gerrit-Change-Number: 7594963
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Attention: Darryl James <dlj...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 03:47:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kelvin Jiang (Gerrit)

    unread,
    Feb 19, 2026, 11:28:45 PM (3 hours ago) Feb 19
    to Darryl James, James Cook, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Darryl James and James Cook

    Kelvin Jiang voted and added 5 comments

    Votes added by Kelvin Jiang

    Commit-Queue+1

    5 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Kelvin Jiang . resolved

    That... was an interesting test flake

    File chrome/browser/extensions/BUILD.gn
    Line 639, Patchset 3 (Parent): "api/tabs/tabs_api_android.cc",
    James Cook . resolved

    Hooray!

    Kelvin Jiang

    Acknowledged

    Line 656, Patchset 3 (Parent): "api/tabs/tabs_api_non_android.cc",
    James Cook . resolved

    Hooray!

    Kelvin Jiang

    Acknowledged

    File chrome/browser/extensions/api/tabs/tabs_api.cc
    Line 3688, Patchset 3: int tab_index;
    James Cook . resolved

    nit: initialize this

    Kelvin Jiang

    Done

    Line 3699, Patchset 3: BrowserWindowInterface* browser_window =
    James Cook . resolved

    nit: Check browser_window for null before using it. On ChromeOS it can be null for unusual window types. See https://chromium-review.googlesource.com/c/chromium/src/+/7596693

    Kelvin Jiang

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Darryl James
    • James Cook
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iff2dd41240b2254924722b5c87d92abe3def6866
      Gerrit-Change-Number: 7594963
      Gerrit-PatchSet: 4
      Gerrit-Owner: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
      Gerrit-Reviewer: James Cook <jame...@chromium.org>
      Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Attention: James Cook <jame...@chromium.org>
      Gerrit-Attention: Darryl James <dlj...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 04:28:37 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: James Cook <jame...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages