[Extensions] Implement OnToolbarActionUpdated() in menu model [chromium/src : main]

2 views

Skip to first unread message

Emilia Paz (Gerrit)

unread,

Oct 30, 2025, 5:38:13 PM (19 hours ago) Oct 30

to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Shuhei Takahashi

Emilia Paz added 1 comment

File chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.cc

Line 321, Patchset 3 (Latest): UpdatePage(GetActiveWebContents());

Emilia Paz . unresolved

I think it would be better to pass web contents from the [model](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/extensions/extensions_menu_view_model.cc;l=367-369;drc=0a4bbd7daba492283f6b453c0b0a7d934f2b2ecd?q=extensions_menu_view_model&ss=chromium) to the platform delegates here and in every method that computes it. That way we don't retrieve it from the Browser's tab strip anymore.
Thoughts? Can do in separate CL

Open in Gerrit

Related details

Attention is currently required from:

Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shuhei Takahashi (Gerrit)

unread,

Oct 30, 2025, 8:22:45 PM (17 hours ago) Oct 30

to Emilia Paz, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Emilia Paz

Shuhei Takahashi voted and added 2 comments

Votes added by Shuhei Takahashi

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Shuhei Takahashi . resolved

Thanks Emilia!