[bedrock] Remove BrowserWithTestWindowTest from controlled_home_dialog_controller_unittest.cc [chromium/src : main]

0 views
Skip to first unread message

Daniel Rubery (Gerrit)

unread,
2:58 PM (2 hours ago) 2:58 PM
to chromium-bedrock-reviews, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from chromium-bedrock-reviews

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • chromium-bedrock-reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id47376bd7697d7bd0b7872a8b7cc78edfca0e33e
Gerrit-Change-Number: 7890806
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Attention: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 18:58:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
2:59 PM (2 hours ago) 2:59 PM
to Daniel Rubery, chromium-bedrock-reviews, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Lei Zhang

Message from gwsq

Reviewer source(s):
the...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id47376bd7697d7bd0b7872a8b7cc78edfca0e33e
Gerrit-Change-Number: 7890806
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 18:59:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
3:03 PM (2 hours ago) 3:03 PM
to Daniel Rubery, chromium-bedrock-reviews, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Daniel Rubery

Lei Zhang added 2 comments

Commit Message
Line 9, Patchset 2 (Latest):We don't need a full BrowserWithTestWindowTest, just a WebContents.
Lei Zhang . unresolved

go/avoid-we

I definitely don't need a BrowserWithTestWindowTest. ;-)

File chrome/browser/ui/extensions/controlled_home_dialog_controller_unittest.cc
Line 40, Patchset 2 (Latest):// TODO(crbug.com/441590893): Use ExtensionBrowserTest which is platform
Lei Zhang . unresolved

What about this TODO?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Rubery
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id47376bd7697d7bd0b7872a8b7cc78edfca0e33e
    Gerrit-Change-Number: 7890806
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Daniel Rubery <dru...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 19:03:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages