Rename ozone buildflags [chromium/src : main]

0 views

Skip to first unread message

Fred Shih (Gerrit)

unread,

Jan 30, 2026, 5:38:54 PM (7 hours ago) Jan 30

to Chromium LUCI CQ, Darryl James, Eriko Kurimoto, Christian Biesinger, chromium...@chromium.org, Andrew Rayskiy, Mathias Bynens, Kevin McNee, Rijubrata Bhaumik, Simon Hangl, Ian Vollick, James Maclean, aashna...@google.com, boujan...@google.com, cc-...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, chrstn...@google.com, dewitt...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, kenok...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, rginda...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, tgupta...@chromium.org, webap...@microsoft.com, yigu+...@chromium.org

Attention needed from Darryl James and Eriko Kurimoto

Fred Shih added 10 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Fred Shih . resolved

gave up after about 10 files, almost all the usages look incorrect.

File chrome/browser/actor/tools/window_management_tool_browsertest.cc

Line 202, Patchset 1 (Latest):#if BUILDFLAG(SUPPORTS_OZONE_WAYLAND)

Fred Shih . unresolved

this is probably wrong.

File chrome/browser/actor/ui/handoff_button_controller_interactive_uitest.cc

Line 211, Patchset 1 (Latest):// TODO(crbug.com/465113623) Test flaky on Wayland.

Fred Shih . unresolved

probably wrong.

File chrome/browser/enterprise/idle/idle_service_interactive_uitest.cc

Line 237, Patchset 1 (Latest):#if BUILDFLAG(IS_LINUX) && BUILDFLAG(SUPPORTS_OZONE_WAYLAND)

Fred Shih . unresolved

probably wrong.

File chrome/browser/enterprise/signin/enterprise_signin_service_browsertest.cc

Line 209, Patchset 1 (Latest):#if !BUILDFLAG(SUPPORTS_OZONE_WAYLAND)

Fred Shih . unresolved

probably wrong.

File chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc

Line 95, Patchset 1 (Latest):#if BUILDFLAG(IS_MAC) || BUILDFLAG(SUPPORTS_OZONE_WAYLAND)

Fred Shih . unresolved

probably wrong

File chrome/browser/extensions/api/tabs/tabs_api.cc

Line 1164, Patchset 1 (Latest):#if BUILDFLAG(IS_LINUX) && BUILDFLAG(SUPPORTS_OZONE_X11)

Fred Shih . unresolved

doesn't do what it's intended to do

File chrome/browser/extensions/api/tabs/tabs_interactive_test.cc

Line 492, Patchset 1 (Latest): BUILDFLAG(SUPPORTS_OZONE_WAYLAND)

Fred Shih . unresolved

probably wrong.

File chrome/browser/extensions/api/tabs/tabs_test.cc

Line 1073, Patchset 1 (Latest):#if BUILDFLAG(SUPPORTS_OZONE_X11)

Fred Shih . unresolved

this is probably wrong.

File chrome/browser/glic/browser_ui/context_sharing_border_view_interactive_uitest.cc

Line 661, Patchset 1 (Latest):#if BUILDFLAG(SUPPORTS_OZONE_WAYLAND)

Fred Shih . unresolved

probably wrong.

Open in Gerrit

Related details

Attention is currently required from:

Darryl James
Eriko Kurimoto

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages