dlp: Add fileManagerPrivate::OpenPolicyLearnMore API [chromium/src : main]

gwsq (Gerrit)

unread,

Jul 12, 2023, 11:15:14 AM7/12/23

to Luca Accorsi, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Aida Zolic, ChromeOS DLP, Luciano Pacheco

Attention is currently required from: Aida Zolic, ChromeOS DLP, Luca Accorsi, Luciano Pacheco.

gwsq would like Luca Accorsi to review this change authored by Aida Zolic.

View Change

dlp: Add fileManagerPrivate::OpenPolicyLearnMore API

Adds a fileManagerPrivate::OpenPolicyLearnMore() function that can be
invoked from an error panel item when some file is blocked by DLP or
Enterprise Connectors. It passes the task id to FPNM so that it opens
the correct help page depending on which policy blocked the file.

R=chrome...@google.com, luc...@chromium.org

Fixed: b:289919765
Change-Id: I3367a1b806802a9ac4f28167effd01d4d62c430c
---
M chrome/browser/ash/extensions/file_manager/private_api_file_system.cc
M chrome/browser/ash/extensions/file_manager/private_api_file_system.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h
M chrome/common/extensions/api/file_manager_private.idl
M extensions/browser/extension_function_histogram_value.h
M third_party/closure_compiler/externs/file_manager_private.js
M tools/metrics/histograms/enums.xml
8 files changed, 80 insertions(+), 13 deletions(-)

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

gwsq (Gerrit)

unread,

Jul 12, 2023, 11:15:18 AM7/12/23

to Aya Elsayed, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Aida Zolic, Luca Accorsi, ChromeOS DLP, Luciano Pacheco

Attention is currently required from: Aida Zolic, Aya Elsayed, ChromeOS DLP, Luca Accorsi, Luciano Pacheco.

gwsq would like Aya Elsayed to review this change authored by Aida Zolic.

gwsq (Gerrit)

unread,

Jul 12, 2023, 11:15:24 AM7/12/23

to asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aida Zolic, Aya Elsayed, Luca Accorsi, Luciano Pacheco

Attention is currently required from: Aida Zolic, Aya Elsayed, Luca Accorsi, Luciano Pacheco.

Aida Zolic has uploaded this change for review.

gwsq (Gerrit)

unread,

Jul 12, 2023, 11:16:13 AM7/12/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Aida Zolic, Aya Elsayed, Luca Accorsi, Luciano Pacheco

gwsq (Gerrit)

unread,

Jul 12, 2023, 11:16:20 AM7/12/23

to Aida Zolic, chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aya Elsayed, Luca Accorsi, Luciano Pacheco, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Chromium LUCI CQ

Attention is currently required from: Aida Zolic, Aya Elsayed, Luca Accorsi, Luciano Pacheco.

From chrome/enterprise/gwsq/cros-dlp-review.gwsq:
Note: A shadow reviewer was assigned to this CL.
Shadowed: accorsi

Reviewer source(s):
accorsi, ayaelattar is from context(chrome/enterprise/gwsq/cros-dlp-review.gwsq)

View Change

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

gwsq (Gerrit)

unread,

Jul 12, 2023, 11:35:27 AM7/12/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aida Zolic, Aya Elsayed, Luca Accorsi, Luciano Pacheco

Attention is currently required from: Aya Elsayed, Luca Accorsi, Luciano Pacheco.

Aida Zolic has uploaded this change for review.

View Change

dlp: Add fileManagerPrivate::OpenPolicyLearnMore API

Adds a fileManagerPrivate::OpenPolicyLearnMore() function that can be
invoked from an error panel item when some file is blocked by DLP or
Enterprise Connectors. It passes the task id to FPNM so that it opens
the correct help page depending on which policy blocked the file.

R=chrome...@google.com, luc...@chromium.org

Fixed: b:289919765
Change-Id: I3367a1b806802a9ac4f28167effd01d4d62c430c
---
M chrome/browser/ash/extensions/file_manager/private_api_file_system.cc
M chrome/browser/ash/extensions/file_manager/private_api_file_system.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h
M chrome/common/extensions/api/file_manager_private.idl
M extensions/browser/extension_function_histogram_value.h
M third_party/closure_compiler/externs/file_manager_private.js
M tools/metrics/histograms/enums.xml
8 files changed, 80 insertions(+), 13 deletions(-)

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

gwsq (Gerrit)

unread,

Jul 12, 2023, 11:35:35 AM7/12/23

to Aida Zolic, chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aya Elsayed, Luca Accorsi, Luciano Pacheco, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Chromium LUCI CQ

Attention is currently required from: Aya Elsayed, Luca Accorsi, Luciano Pacheco.

From chrome/enterprise/gwsq/cros-dlp-review.gwsq:

Note: A shadow reviewer was assigned to this CL.

Reviewer source(s):
ayaelattar is from context(chrome/enterprise/gwsq/cros-dlp-review.gwsq)

View Change

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jul 12, 2023, 11:37:44 AM7/12/23

to Toni Barzic, chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Aya Elsayed, Luca Accorsi, Luciano Pacheco

Attention is currently required from: Aya Elsayed, Luca Accorsi, Luciano Pacheco, Toni Barzic.

Aida Zolic would like Toni Barzic to review this change.

View Change

dlp: Add fileManagerPrivate::OpenPolicyLearnMore API

Adds a fileManagerPrivate::OpenPolicyLearnMore() function that can be
invoked from an error panel item when some file is blocked by DLP or
Enterprise Connectors. It passes the task id to FPNM so that it opens
the correct help page depending on which policy blocked the file.

R=chrome...@google.com, luc...@chromium.org

Fixed: b:289919765
Change-Id: I3367a1b806802a9ac4f28167effd01d4d62c430c
---
M chrome/browser/ash/extensions/file_manager/private_api_file_system.cc
M chrome/browser/ash/extensions/file_manager/private_api_file_system.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h
M chrome/common/extensions/api/file_manager_private.idl
M extensions/browser/extension_function_histogram_value.h
M third_party/closure_compiler/externs/file_manager_private.js
M tools/metrics/histograms/enums.xml
8 files changed, 80 insertions(+), 13 deletions(-)

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jul 12, 2023, 11:37:50 AM7/12/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Toni Barzic, ChromeOS DLP, Aya Elsayed, Luca Accorsi, Luciano Pacheco, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Chromium LUCI CQ

Attention is currently required from: Aya Elsayed, Luca Accorsi, Luciano Pacheco, Toni Barzic.

View Change

1 comment:

Patchset:
- Patch Set #3:
  Hi all, PTAL, thanks.
  Toni: `extension_function_histogram_value`
  Luciano: `/file_manager/`
  Aya: `/dlp/`

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

Luciano Pacheco (Gerrit)

unread,

Jul 12, 2023, 10:10:58 PM7/12/23

to Aida Zolic, chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Toni Barzic, ChromeOS DLP, Aya Elsayed, Luca Accorsi, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Chromium LUCI CQ

Attention is currently required from: Aida Zolic, Aya Elsayed, Luca Accorsi, Toni Barzic.

Patch set 3:Code-Review +1

View Change

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

Luca Accorsi (Gerrit)

unread,

Jul 13, 2023, 3:20:30 AM7/13/23

to Aida Zolic, chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Luciano Pacheco, Toni Barzic, ChromeOS DLP, Aya Elsayed, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Chromium LUCI CQ

Attention is currently required from: Aida Zolic, Aya Elsayed, Toni Barzic.

Patch set 3:Code-Review +1

View Change

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

Aya Elsayed (Gerrit)

unread,

Jul 13, 2023, 6:00:19 AM7/13/23

to Aida Zolic, chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Luca Accorsi, Luciano Pacheco, Toni Barzic, ChromeOS DLP, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Chromium LUCI CQ

Attention is currently required from: Aida Zolic, Toni Barzic.

View Change

1 comment:

File chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc:
- Patch Set #3, Line 475:
```
if (task_id.has_value() && !HasBlockedFiles(task_id.value())) {
    return;
  }
  if (notification_id.has_value() &&
      !HasBlockedFiles(notification_id.value())) {
    return;
  }
```
  Why do we need those 2 conditions? Can't we just Open the learn more link regardless whether there's any blocked file?

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jul 13, 2023, 7:48:37 AM7/13/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Luca Accorsi, Luciano Pacheco, Toni Barzic, ChromeOS DLP, Aya Elsayed, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Chromium LUCI CQ

Attention is currently required from: Aya Elsayed, Toni Barzic.

View Change

1 comment:

File chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc:

Patch Set #3, Line 475:

if (task_id.has_value() && !HasBlockedFiles(task_id.value())) {
    return;
  }
  if (notification_id.has_value() &&
      !HasBlockedFiles(notification_id.value())) {
    return;
  }

- Why do we need those 2 conditions? Can't we just Open the learn more link regardless whether there's […]
  Because we will be opening the page based on the policy, for which we need to have the info about blocked files (TODO below). This shouldn't be called otherwise. It's also explained in the CL description. 😊

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

gwsq (Gerrit)

unread,

Jul 14, 2023, 4:15:58 AM7/14/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aida Zolic, Toni Barzic, Luca Accorsi, Luciano Pacheco, Aya Elsayed

Attention is currently required from: Aya Elsayed.

Aida Zolic has uploaded this change for review.

View Change

dlp: Add fileManagerPrivate::OpenPolicyLearnMore API

Adds a fileManagerPrivate::OpenPolicyLearnMore() function that can be
invoked from an error panel item when some file is blocked by DLP or
Enterprise Connectors. It passes the task id to FPNM so that it opens
the correct help page depending on which policy blocked the file.

R=chrome...@google.com, luc...@chromium.org

Fixed: b:289919765
Change-Id: I3367a1b806802a9ac4f28167effd01d4d62c430c
---
M chrome/browser/ash/extensions/file_manager/private_api_file_system.cc
M chrome/browser/ash/extensions/file_manager/private_api_file_system.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h
M chrome/common/extensions/api/file_manager_private.idl
M extensions/browser/extension_function_histogram_value.h
M third_party/closure_compiler/externs/file_manager_private.js
M tools/metrics/histograms/enums.xml
8 files changed, 80 insertions(+), 13 deletions(-)

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

gwsq (Gerrit)

unread,

Jul 14, 2023, 8:41:18 AM7/14/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aida Zolic, Toni Barzic, Luca Accorsi, Luciano Pacheco, Aya Elsayed

Attention is currently required from: Aya Elsayed, Luca Accorsi, Luciano Pacheco, Toni Barzic.

Aida Zolic has uploaded this change for review.

View Change

dlp: Add fileManagerPrivate::OpenPolicyLearnMore API

Adds a fileManagerPrivate::OpenPolicyLearnMore() function that can be
invoked from an error panel item when some file is blocked by DLP or
Enterprise Connectors. It passes the task id to FPNM so that it opens
the correct help page depending on which policy blocked the file.

R=chrome...@google.com, luc...@chromium.org

Fixed: b:289919765
Change-Id: I3367a1b806802a9ac4f28167effd01d4d62c430c
---
M chrome/browser/ash/extensions/file_manager/private_api_file_system.cc
M chrome/browser/ash/extensions/file_manager/private_api_file_system.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h

M chrome/browser/ash/policy/dlp/files_policy_notification_manager_browsertest.cc


M chrome/common/extensions/api/file_manager_private.idl
M extensions/browser/extension_function_histogram_value.h
M third_party/closure_compiler/externs/file_manager_private.js
M tools/metrics/histograms/enums.xml

9 files changed, 87 insertions(+), 13 deletions(-)

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

gwsq (Gerrit)

unread,

Jul 14, 2023, 12:55:53 PM7/14/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aida Zolic, Aya Elsayed, Toni Barzic, Luca Accorsi, Luciano Pacheco

Attention is currently required from: Luca Accorsi, Luciano Pacheco, Toni Barzic.

Aida Zolic has uploaded this change for review.

View Change

dlp: Add fileManagerPrivate::OpenPolicyLearnMore API

Adds a fileManagerPrivate::OpenPolicyLearnMore() function that can be
invoked from an error panel item when some file is blocked by DLP or
Enterprise Connectors. It passes the task id to FPNM so that it opens
the correct help page depending on which policy blocked the file.

R=chrome...@google.com, luc...@chromium.org

Fixed: b:289919765
Change-Id: I3367a1b806802a9ac4f28167effd01d4d62c430c
---
M chrome/browser/ash/extensions/file_manager/private_api_file_system.cc
M chrome/browser/ash/extensions/file_manager/private_api_file_system.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager_browsertest.cc
M chrome/common/extensions/api/file_manager_private.idl
M extensions/browser/extension_function_histogram_value.h
M third_party/closure_compiler/externs/file_manager_private.js
M tools/metrics/histograms/enums.xml

9 files changed, 85 insertions(+), 13 deletions(-)

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

gwsq (Gerrit)

unread,

Jul 17, 2023, 4:28:28 AM7/17/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, ChromeOS DLP, Aida Zolic, Aya Elsayed, Toni Barzic, Luca Accorsi, Luciano Pacheco

Attention is currently required from: Aya Elsayed, Luca Accorsi, Toni Barzic.

Aida Zolic has uploaded this change for review.

View Change

dlp: Add fileManagerPrivate::OpenPolicyLearnMore API

Adds a fileManagerPrivate::OpenPolicyLearnMore() function that can be
invoked from an error panel item when some file is blocked by DLP or
Enterprise Connectors. It passes the task id to FPNM so that it opens
the correct help page depending on which policy blocked the file.

R=chrome...@google.com, luc...@chromium.org

Fixed: b:289919765
Change-Id: I3367a1b806802a9ac4f28167effd01d4d62c430c
---

M chrome/browser/ash/file_manager/file_manager_string_util.cc


M chrome/browser/ash/policy/dlp/files_policy_notification_manager.cc
M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h
M chrome/browser/ash/policy/dlp/files_policy_notification_manager_browsertest.cc

M ui/file_manager/file_manager/background/js/file_operation_handler.js
M ui/file_manager/file_manager/foreground/js/ui/file_table.js
6 files changed, 41 insertions(+), 18 deletions(-)

To view, visit change 4681249. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jul 17, 2023, 4:38:51 AM7/17/23

to chromeos-d...@google.com, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, Toni Barzic, Aya Elsayed, Luca Accorsi, Luciano Pacheco

Attention is currently required from: Aya Elsayed, Luca Accorsi.

Reply all

Reply to author

Forward