Remove unused functions of crosapi::mojom::LocalPrinter [2/n] [chromium/src : main]

0 views
Skip to first unread message

Qijiang Fan (Gerrit)

unread,
Apr 1, 2026, 6:24:38 AM (yesterday) Apr 1
to Hidehiko Abe, Georg Neis, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, chromium-a...@chromium.org, cros-print...@google.com, extension...@chromium.org, ffred...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, tluk+...@chromium.org
Attention needed from Georg Neis and Hidehiko Abe

Qijiang Fan voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Georg Neis
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4173a5b792c0300d6bdefbb5d80d963d9c88d8c0
Gerrit-Change-Number: 7715518
Gerrit-PatchSet: 3
Gerrit-Owner: Qijiang Fan <f...@chromium.org>
Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Qijiang Fan <f...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Georg Neis <ne...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:24:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Georg Neis (Gerrit)

unread,
Apr 1, 2026, 8:59:44 PM (18 hours ago) Apr 1
to Qijiang Fan, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, chromium-a...@chromium.org, cros-print...@google.com, extension...@chromium.org, ffred...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, tluk+...@chromium.org
Attention needed from Hidehiko Abe and Qijiang Fan

Georg Neis voted and added 2 comments

Votes added by Georg Neis

Code-Review+1

2 comments

File chrome/browser/printing/local_printer_utils_chromeos.h
Line 12, Patchset 3 (Parent):#include "chromeos/printing/printer_configuration.h"
Georg Neis . unresolved

Obsolete

File chrome/browser/printing/local_printer_utils_chromeos.cc
Line 18, Patchset 3 (Latest):#include "chromeos/printing/printer_configuration.h"
Georg Neis . unresolved

Please clean up.

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Qijiang Fan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4173a5b792c0300d6bdefbb5d80d963d9c88d8c0
Gerrit-Change-Number: 7715518
Gerrit-PatchSet: 3
Gerrit-Owner: Qijiang Fan <f...@chromium.org>
Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Qijiang Fan <f...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Qijiang Fan <f...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 00:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Apr 1, 2026, 9:47:16 PM (17 hours ago) Apr 1
to Qijiang Fan, Georg Neis, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, chromium-a...@chromium.org, cros-print...@google.com, extension...@chromium.org, ffred...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, tluk+...@chromium.org
Attention needed from Qijiang Fan

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Hidehiko Abe . resolved

LGTM with neis@'s comments

Open in Gerrit

Related details

Attention is currently required from:
  • Qijiang Fan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4173a5b792c0300d6bdefbb5d80d963d9c88d8c0
    Gerrit-Change-Number: 7715518
    Gerrit-PatchSet: 3
    Gerrit-Owner: Qijiang Fan <f...@chromium.org>
    Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Qijiang Fan <f...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Qijiang Fan <f...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 01:46:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Qijiang Fan (Gerrit)

    unread,
    3:25 AM (12 hours ago) 3:25 AM
    to Hidehiko Abe, Georg Neis, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, chromium-a...@chromium.org, cros-print...@google.com, extension...@chromium.org, ffred...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, tluk+...@chromium.org
    Attention needed from Georg Neis and Hidehiko Abe

    Qijiang Fan voted and added 2 comments

    Votes added by Qijiang Fan

    Auto-Submit+1
    Commit-Queue+1

    2 comments

    File chrome/browser/printing/local_printer_utils_chromeos.h
    Line 12, Patchset 3 (Parent):#include "chromeos/printing/printer_configuration.h"
    Georg Neis . resolved

    Obsolete

    Qijiang Fan

    Done

    File chrome/browser/printing/local_printer_utils_chromeos.cc
    Line 18, Patchset 3:#include "chromeos/printing/printer_configuration.h"
    Georg Neis . resolved

    Please clean up.

    Qijiang Fan

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Georg Neis
    • Hidehiko Abe
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4173a5b792c0300d6bdefbb5d80d963d9c88d8c0
      Gerrit-Change-Number: 7715518
      Gerrit-PatchSet: 5
      Gerrit-Owner: Qijiang Fan <f...@chromium.org>
      Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Qijiang Fan <f...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Georg Neis <ne...@chromium.org>
      Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 07:24:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Georg Neis <ne...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Georg Neis (Gerrit)

      unread,
      3:34 AM (11 hours ago) 3:34 AM
      to Qijiang Fan, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, chromium-a...@chromium.org, cros-print...@google.com, extension...@chromium.org, ffred...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, tluk+...@chromium.org
      Attention needed from Hidehiko Abe and Qijiang Fan

      Georg Neis voted and added 2 comments

      Votes added by Georg Neis

      Code-Review+1

      2 comments

      File chrome/browser/printing/local_printer_utils_chromeos.cc
      Line 10, Patchset 5 (Latest):#include <utility>
      Georg Neis . unresolved

      These can be removed too.

      Line 15, Patchset 5 (Latest):#include "chrome/browser/ash/crosapi/local_printer_ash.h" // nogncheck
      Georg Neis . unresolved

      I'm puzzled why the nogncheck has become necessary.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hidehiko Abe
      • Qijiang Fan
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4173a5b792c0300d6bdefbb5d80d963d9c88d8c0
        Gerrit-Change-Number: 7715518
        Gerrit-PatchSet: 5
        Gerrit-Owner: Qijiang Fan <f...@chromium.org>
        Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
        Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
        Gerrit-Reviewer: Qijiang Fan <f...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        Gerrit-CC: Simon Hangl <sim...@google.com>
        Gerrit-Attention: Qijiang Fan <f...@chromium.org>
        Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
        Gerrit-Comment-Date: Thu, 02 Apr 2026 07:34:26 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Qijiang Fan (Gerrit)

        unread,
        4:00 AM (11 hours ago) 4:00 AM
        to Georg Neis, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, chromium-a...@chromium.org, cros-print...@google.com, extension...@chromium.org, ffred...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, tluk+...@chromium.org
        Attention needed from Georg Neis and Hidehiko Abe

        Qijiang Fan voted and added 2 comments

        Votes added by Qijiang Fan

        Auto-Submit+1
        Commit-Queue+1

        2 comments

        File chrome/browser/printing/local_printer_utils_chromeos.cc
        Line 10, Patchset 5:#include <utility>
        Georg Neis . resolved

        These can be removed too.

        Qijiang Fan

        Done

        Line 15, Patchset 5:#include "chrome/browser/ash/crosapi/local_printer_ash.h" // nogncheck
        Georg Neis . resolved

        I'm puzzled why the nogncheck has become necessary.

        Qijiang Fan

        i didn't add this ngncheck.
        some other CL did. i was just rebasing to ToT.
        hmmm. it looks like it is a revert of refactoring (https://chromium-review.googlesource.com/c/chromium/src/+/7722199)
        let me remove the ngncheck.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Georg Neis
        • Hidehiko Abe
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I4173a5b792c0300d6bdefbb5d80d963d9c88d8c0
          Gerrit-Change-Number: 7715518
          Gerrit-PatchSet: 6
          Gerrit-Owner: Qijiang Fan <f...@chromium.org>
          Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
          Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
          Gerrit-Reviewer: Qijiang Fan <f...@chromium.org>
          Gerrit-CC: Andrew Rayskiy <green...@google.com>
          Gerrit-CC: Simon Hangl <sim...@google.com>
          Gerrit-Attention: Georg Neis <ne...@chromium.org>
          Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
          Gerrit-Comment-Date: Thu, 02 Apr 2026 08:00:10 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Georg Neis <ne...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Georg Neis (Gerrit)

          unread,
          4:04 AM (11 hours ago) 4:04 AM
          to Qijiang Fan, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, chromium-a...@chromium.org, cros-print...@google.com, extension...@chromium.org, ffred...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, tluk+...@chromium.org
          Attention needed from Hidehiko Abe and Qijiang Fan

          Georg Neis voted and added 1 comment

          Votes added by Georg Neis

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 6 (Latest):
          Georg Neis . resolved

          thanks

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Hidehiko Abe
          • Qijiang Fan
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I4173a5b792c0300d6bdefbb5d80d963d9c88d8c0
            Gerrit-Change-Number: 7715518
            Gerrit-PatchSet: 6
            Gerrit-Owner: Qijiang Fan <f...@chromium.org>
            Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
            Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
            Gerrit-Reviewer: Qijiang Fan <f...@chromium.org>
            Gerrit-CC: Andrew Rayskiy <green...@google.com>
            Gerrit-CC: Simon Hangl <sim...@google.com>
            Gerrit-Attention: Qijiang Fan <f...@chromium.org>
            Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
            Gerrit-Comment-Date: Thu, 02 Apr 2026 08:04:07 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages