[B4B] Feature flag cleanup [chromium/src : main]

[Ryan Sultanem (Gerrit)]

Attention needed from Mikel Astiz and Monica Salama

Ryan Sultanem added 2 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Ryan Sultanem . resolved

Hello Monica and Mikel, can you please check the following?

Thanks!

Commit Message

Line 9, Patchset 12:Different aspects modified:

Ryan Sultanem . unresolved

Sorry about this very big change - it turned out to be much bigger than I expected when I first started it!

I can split it in by the mentioned bullet points below, if it is easier. Let me know!

Open in Gerrit

Related details

Attention is currently required from:

• Mikel Astiz
• Monica Salama

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Idf05a73fe320d356e0004e28460404c996c10b21

Gerrit-Change-Number: 7209219

Gerrit-PatchSet: 14

Gerrit-Owner: Ryan Sultanem <rs...@google.com>

Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>

Gerrit-Reviewer: Monica Salama <msa...@chromium.org>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Monica Salama <msa...@chromium.org>

Gerrit-Attention: Mikel Astiz <mas...@chromium.org>

Gerrit-Comment-Date: Mon, 05 Jan 2026 16:25:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mikel Astiz (Gerrit)]

Attention needed from Monica Salama and Ryan Sultanem

Mikel Astiz added 3 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Mikel Astiz . resolved

Thanks!

Commit Message

Line 9, Patchset 12:Different aspects modified:

Ryan Sultanem . unresolved

Sorry about this very big change - it turned out to be much bigger than I expected when I first started it!

I can split it in by the mentioned bullet points below, if it is easier. Let me know!

Mikel Astiz

Thanks for the cleanup!

I would definitely appreciate splitting this into smaller CLs, ideally one per feature flag, followed up by dead code deletion.

Line 14, Patchset 14 (Latest):- ChromeOS: enable the feature for this platform - relying on the fact

Mikel Astiz . unresolved

I don't think this is possible. On ChromeOS, there is the edge case where IsSyncFeatureDisabledViaDashboard() returns true, in which case the sync machinery runs in transport mode.

It may still be possible to clean up the flag and rely on other mechanisms, but this should be done with care.

Open in Gerrit

Related details

Attention is currently required from:

• Monica Salama
• Ryan Sultanem

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Idf05a73fe320d356e0004e28460404c996c10b21

Gerrit-Change-Number: 7209219

Gerrit-PatchSet: 14

Gerrit-Owner: Ryan Sultanem <rs...@google.com>

Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>

Gerrit-Reviewer: Monica Salama <msa...@chromium.org>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Monica Salama <msa...@chromium.org>

Gerrit-Attention: Ryan Sultanem <rs...@google.com>

Gerrit-Comment-Date: Wed, 07 Jan 2026 09:19:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ryan Sultanem <rs...@google.com>

[Monica Salama (Gerrit)]

Attention needed from Ryan Sultanem

Monica Salama added 1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Monica Salama . resolved

I will defer my review to after Mikel's code review comments are addressed, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Ryan Sultanem

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Idf05a73fe320d356e0004e28460404c996c10b21

Gerrit-Change-Number: 7209219

Gerrit-PatchSet: 14

Gerrit-Owner: Ryan Sultanem <rs...@google.com>

Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>

Gerrit-Reviewer: Monica Salama <msa...@chromium.org>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ryan Sultanem <rs...@google.com>

Gerrit-Comment-Date: Wed, 07 Jan 2026 12:42:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ryan Sultanem (Gerrit)]

Ryan Sultanem added 2 comments

Commit Message

Line 9, Patchset 12:Different aspects modified:

Ryan Sultanem . unresolved

Sorry about this very big change - it turned out to be much bigger than I expected when I first started it!

I can split it in by the mentioned bullet points below, if it is easier. Let me know!

Mikel Astiz

Thanks for the cleanup!

I would definitely appreciate splitting this into smaller CLs, ideally one per feature flag, followed up by dead code deletion.

Ryan Sultanem

Putting this change on pause for now - when restarting, I will split up the change in smaller CLs for simplicity.

Line 14, Patchset 14 (Latest):- ChromeOS: enable the feature for this platform - relying on the fact

Mikel Astiz . unresolved

I don't think this is possible. On ChromeOS, there is the edge case where IsSyncFeatureDisabledViaDashboard() returns true, in which case the sync machinery runs in transport mode.

It may still be possible to clean up the flag and rely on other mechanisms, but this should be done with care.

Ryan Sultanem

Thanks for that, I was not aware of this edge case. I will look into it then.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Idf05a73fe320d356e0004e28460404c996c10b21

Gerrit-Change-Number: 7209219

Gerrit-PatchSet: 14

Gerrit-Owner: Ryan Sultanem <rs...@google.com>

Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>

Gerrit-Reviewer: Monica Salama <msa...@chromium.org>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 15 Jan 2026 13:03:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mikel Astiz <mas...@chromium.org>

Comment-In-Reply-To: Ryan Sultanem <rs...@google.com>

[Ryan Sultanem (Gerrit)]

Ryan Sultanem abandoned this change.

View Change

Abandoned This change was split into multiple other CLs: some which can be cleaned up direclty, some after launching an intermediate change, and others that can only be landed once Uno on ChromeOS lands.

Ryan Sultanem abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon