[Files app] Update modernize-concat-nested-namespaces in c/b/a/fsp [chromium/src : main]

0 views
Skip to first unread message

Ben Reich (Gerrit)

unread,
Dec 27, 2023, 6:46:05 PM12/27/23
to chromium-a...@chromium.org, cros-enterpris...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, kinuko+...@chromium.org, mtomas...@chromium.org, Nigel Tao, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Nigel Tao.

Patch set 1:Commit-Queue +2

View Change

    To view, visit change 5154407. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I40048375149635fb8c9a09e2a7e602a81ff2eaf0
    Gerrit-Change-Number: 5154407
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ben Reich <benr...@chromium.org>
    Gerrit-Reviewer: Ben Reich <benr...@chromium.org>
    Gerrit-Reviewer: Nigel Tao <nige...@chromium.org>
    Gerrit-Attention: Nigel Tao <nige...@chromium.org>
    Gerrit-Comment-Date: Wed, 27 Dec 2023 23:45:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 27, 2023, 7:11:02 PM12/27/23
    to Ben Reich, chromium-a...@chromium.org, cros-enterpris...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, kinuko+...@chromium.org, mtomas...@chromium.org, Nigel Tao, chromium...@chromium.org

    Chromium LUCI CQ submitted this change.

    View Change

    Approvals: Nigel Tao: Looks good to me Ben Reich: Commit
    [Files app] Update modernize-concat-nested-namespaces in c/b/a/fsp

    Simply a mechanical change to concatenate namespaces in
    chrome/browser/ash/file_system_provider/* using:

    find /chrome/browser/ash/file_system_provider \
    -type f -name "*.cc" -o -name "*.h" | \
    xargs third_party/llvm-build/Release+Asserts/bin/clang-tidy \
    -checks='-*,modernize-concat-nested-namespaces' -fix

    Bug: None
    Change-Id: I40048375149635fb8c9a09e2a7e602a81ff2eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5154407
    Reviewed-by: Nigel Tao <nige...@chromium.org>
    Commit-Queue: Ben Reich <benr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1241268}
    ---
    M chrome/browser/ash/file_system_provider/abort_callback.h
    M chrome/browser/ash/file_system_provider/fake_extension_provider.cc
    M chrome/browser/ash/file_system_provider/fake_extension_provider.h
    M chrome/browser/ash/file_system_provider/fake_registry.cc
    M chrome/browser/ash/file_system_provider/fake_registry.h
    M chrome/browser/ash/file_system_provider/fileapi/backend_delegate.cc
    M chrome/browser/ash/file_system_provider/fileapi/backend_delegate.h
    M chrome/browser/ash/file_system_provider/fileapi/buffering_file_stream_reader.cc
    M chrome/browser/ash/file_system_provider/fileapi/buffering_file_stream_reader.h
    M chrome/browser/ash/file_system_provider/fileapi/buffering_file_stream_reader_unittest.cc
    M chrome/browser/ash/file_system_provider/fileapi/buffering_file_stream_writer.cc
    M chrome/browser/ash/file_system_provider/fileapi/buffering_file_stream_writer.h
    M chrome/browser/ash/file_system_provider/fileapi/buffering_file_stream_writer_unittest.cc
    M chrome/browser/ash/file_system_provider/fileapi/file_stream_reader.cc
    M chrome/browser/ash/file_system_provider/fileapi/file_stream_reader.h
    M chrome/browser/ash/file_system_provider/fileapi/file_stream_reader_unittest.cc
    M chrome/browser/ash/file_system_provider/fileapi/file_stream_writer.cc
    M chrome/browser/ash/file_system_provider/fileapi/file_stream_writer.h
    M chrome/browser/ash/file_system_provider/fileapi/file_stream_writer_unittest.cc
    M chrome/browser/ash/file_system_provider/fileapi/provider_async_file_util.cc
    M chrome/browser/ash/file_system_provider/fileapi/provider_async_file_util.h
    M chrome/browser/ash/file_system_provider/fileapi/provider_async_file_util_unittest.cc
    M chrome/browser/ash/file_system_provider/fileapi/watcher_manager.cc
    M chrome/browser/ash/file_system_provider/fileapi/watcher_manager.h
    M chrome/browser/ash/file_system_provider/icon_set.cc
    M chrome/browser/ash/file_system_provider/icon_set.h
    M chrome/browser/ash/file_system_provider/logging_observer.cc
    M chrome/browser/ash/file_system_provider/logging_observer.h
    M chrome/browser/ash/file_system_provider/mount_path_util.cc
    M chrome/browser/ash/file_system_provider/mount_path_util.h
    M chrome/browser/ash/file_system_provider/mount_path_util_unittest.cc
    M chrome/browser/ash/file_system_provider/notification_manager.cc
    M chrome/browser/ash/file_system_provider/notification_manager.h
    M chrome/browser/ash/file_system_provider/notification_manager_interface.h
    M chrome/browser/ash/file_system_provider/observer.h
    M chrome/browser/ash/file_system_provider/operation_request_manager_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/abort.cc
    M chrome/browser/ash/file_system_provider/operations/abort.h
    M chrome/browser/ash/file_system_provider/operations/abort_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/add_watcher.cc
    M chrome/browser/ash/file_system_provider/operations/add_watcher.h
    M chrome/browser/ash/file_system_provider/operations/add_watcher_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/close_file.cc
    M chrome/browser/ash/file_system_provider/operations/close_file.h
    M chrome/browser/ash/file_system_provider/operations/close_file_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/configure.cc
    M chrome/browser/ash/file_system_provider/operations/configure.h
    M chrome/browser/ash/file_system_provider/operations/configure_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/copy_entry.cc
    M chrome/browser/ash/file_system_provider/operations/copy_entry.h
    M chrome/browser/ash/file_system_provider/operations/copy_entry_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/create_directory.cc
    M chrome/browser/ash/file_system_provider/operations/create_directory.h
    M chrome/browser/ash/file_system_provider/operations/create_directory_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/create_file.cc
    M chrome/browser/ash/file_system_provider/operations/create_file.h
    M chrome/browser/ash/file_system_provider/operations/create_file_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/delete_entry.cc
    M chrome/browser/ash/file_system_provider/operations/delete_entry.h
    M chrome/browser/ash/file_system_provider/operations/delete_entry_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/execute_action.cc
    M chrome/browser/ash/file_system_provider/operations/execute_action.h
    M chrome/browser/ash/file_system_provider/operations/execute_action_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/get_actions.cc
    M chrome/browser/ash/file_system_provider/operations/get_actions.h
    M chrome/browser/ash/file_system_provider/operations/get_actions_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/get_metadata.cc
    M chrome/browser/ash/file_system_provider/operations/get_metadata.h
    M chrome/browser/ash/file_system_provider/operations/get_metadata_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/move_entry.cc
    M chrome/browser/ash/file_system_provider/operations/move_entry.h
    M chrome/browser/ash/file_system_provider/operations/move_entry_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/open_file.cc
    M chrome/browser/ash/file_system_provider/operations/open_file.h
    M chrome/browser/ash/file_system_provider/operations/open_file_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/operation.cc
    M chrome/browser/ash/file_system_provider/operations/operation.h
    M chrome/browser/ash/file_system_provider/operations/read_directory.cc
    M chrome/browser/ash/file_system_provider/operations/read_directory.h
    M chrome/browser/ash/file_system_provider/operations/read_directory_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/read_file.cc
    M chrome/browser/ash/file_system_provider/operations/read_file.h
    M chrome/browser/ash/file_system_provider/operations/read_file_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/remove_watcher.cc
    M chrome/browser/ash/file_system_provider/operations/remove_watcher.h
    M chrome/browser/ash/file_system_provider/operations/remove_watcher_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/test_util.cc
    M chrome/browser/ash/file_system_provider/operations/test_util.h
    M chrome/browser/ash/file_system_provider/operations/truncate.cc
    M chrome/browser/ash/file_system_provider/operations/truncate.h
    M chrome/browser/ash/file_system_provider/operations/truncate_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/unmount.cc
    M chrome/browser/ash/file_system_provider/operations/unmount.h
    M chrome/browser/ash/file_system_provider/operations/unmount_unittest.cc
    M chrome/browser/ash/file_system_provider/operations/write_file.cc
    M chrome/browser/ash/file_system_provider/operations/write_file.h
    M chrome/browser/ash/file_system_provider/operations/write_file_unittest.cc
    M chrome/browser/ash/file_system_provider/provided_file_system.cc
    M chrome/browser/ash/file_system_provider/provided_file_system.h
    M chrome/browser/ash/file_system_provider/provided_file_system_info.cc
    M chrome/browser/ash/file_system_provider/provided_file_system_info.h
    M chrome/browser/ash/file_system_provider/provided_file_system_interface.cc
    M chrome/browser/ash/file_system_provider/provided_file_system_interface.h
    M chrome/browser/ash/file_system_provider/provided_file_system_observer.cc
    M chrome/browser/ash/file_system_provider/provided_file_system_observer.h
    M chrome/browser/ash/file_system_provider/provided_file_system_unittest.cc
    M chrome/browser/ash/file_system_provider/provider_interface.h
    M chrome/browser/ash/file_system_provider/queue.cc
    M chrome/browser/ash/file_system_provider/queue.h
    M chrome/browser/ash/file_system_provider/queue_unittest.cc
    M chrome/browser/ash/file_system_provider/registry.cc
    M chrome/browser/ash/file_system_provider/registry.h
    M chrome/browser/ash/file_system_provider/registry_interface.cc
    M chrome/browser/ash/file_system_provider/registry_interface.h
    M chrome/browser/ash/file_system_provider/registry_unittest.cc
    M chrome/browser/ash/file_system_provider/request_manager.cc
    M chrome/browser/ash/file_system_provider/request_manager.h
    M chrome/browser/ash/file_system_provider/request_value.cc
    M chrome/browser/ash/file_system_provider/request_value.h
    M chrome/browser/ash/file_system_provider/scoped_file_opener.cc
    M chrome/browser/ash/file_system_provider/scoped_file_opener.h
    M chrome/browser/ash/file_system_provider/scoped_file_opener_unittest.cc
    M chrome/browser/ash/file_system_provider/service.cc
    M chrome/browser/ash/file_system_provider/service.h
    M chrome/browser/ash/file_system_provider/service_factory.cc
    M chrome/browser/ash/file_system_provider/service_factory.h
    M chrome/browser/ash/file_system_provider/service_unittest.cc
    M chrome/browser/ash/file_system_provider/throttled_file_system.cc
    M chrome/browser/ash/file_system_provider/throttled_file_system.h
    M chrome/browser/ash/file_system_provider/throttled_file_system_unittest.cc
    M chrome/browser/ash/file_system_provider/watcher.cc
    M chrome/browser/ash/file_system_provider/watcher.h
    132 files changed, 264 insertions(+), 657 deletions(-)


    To view, visit change 5154407. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I40048375149635fb8c9a09e2a7e602a81ff2eaf0
    Gerrit-Change-Number: 5154407
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ben Reich <benr...@chromium.org>
    Gerrit-Reviewer: Ben Reich <benr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nigel Tao <nige...@chromium.org>
    Reply all
    Reply to author
    Forward
    0 new messages