Migrate ChromeOS-exclusive features from chrome/common to ash/constants [chromium/src : main]

1 view

Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,

Mar 11, 2026, 8:29:40 PM (16 hours ago) Mar 11

to Hidehiko Abe, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org

Attention needed from Hidehiko Abe

Mitsuru Oshima added 1 comment

File ash/constants/ash_features.h

Line 917, Patchset 8 (Latest):COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kWmMode);

Mitsuru Oshima . unresolved

I'll sort them once migration is completed.

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

7:12 AM (5 hours ago) 7:12 AM

to Mitsuru Oshima, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org

Attention needed from Mitsuru Oshima

Hidehiko Abe added 3 comments

File ash/constants/ash_features.h

Line 917, Patchset 8:COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kWmMode);

Mitsuru Oshima . resolved

I'll sort them once migration is completed.

Hidehiko Abe

Acknowledged

File chrome/common/chrome_features.h

Line 105, Patchset 10 (Latest):COMPONENT_EXPORT(CHROME_FEATURES)

Hidehiko Abe . unresolved

nit: remaining...?

File chrome/common/chrome_features.cc

Line 1248, Patchset 10 (Parent): "HappinessTrackingOnboardingExperience",

Hidehiko Abe . unresolved

the names look to be dropped?