[omnibox] Replace `prefer_keyword` variables with `in_keyword_mode` [chromium/src : main]
0 views
Skip to first unread message
manuk hovanesian (Gerrit)
Jun 23, 2026, 7:01:42 PM (2 days ago) Jun 23
to Tomasz Wiszkowski, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Tomasz Wiszkowski
manuk hovanesian voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Tomasz Wiszkowski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
manuk hovanesian (Gerrit)
1:12 PM (8 hours ago) 1:12 PM
to Chromium IPC Reviews, Christian Xu, android-bu...@system.gserviceaccount.com, Tomasz Wiszkowski, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Christian Xu, Chromium IPC Reviews and Tomasz Wiszkowski
manuk hovanesian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
manuk hovanesian . resolved
chrome-ipc-reviews, pls review .mojom file
christianxu, pls review ios/
Ender, pls review everything
Related details
Attention is currently required from:
- Christian Xu
- Chromium IPC Reviews
- Tomasz Wiszkowski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
1:18 PM (8 hours ago) 1:18 PM
to manuk hovanesian, Chromium IPC Reviews, Fred Shih, Christian Xu, android-bu...@system.gserviceaccount.com, Tomasz Wiszkowski, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Christian Xu, Fred Shih and Tomasz Wiszkowski
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ff...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ff...@chromium.org
Reviewer source(s):
ff...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Christian Xu
- Fred Shih
- Tomasz Wiszkowski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
manuk hovanesian (Gerrit)
3:00 PM (6 hours ago) 3:00 PM
to Ameur Hosni, Christian Xu, Chromium IPC Reviews, Fred Shih, android-bu...@system.gserviceaccount.com, Tomasz Wiszkowski, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Ameur Hosni, Christian Xu, Fred Shih and Tomasz Wiszkowski
manuk hovanesian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Ameur Hosni
- Christian Xu
- Fred Shih
- Tomasz Wiszkowski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomasz Wiszkowski (Gerrit)
4:26 PM (5 hours ago) 4:26 PM
to manuk hovanesian, Ameur Hosni, Christian Xu, Chromium IPC Reviews, Fred Shih, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Ameur Hosni, Christian Xu, Fred Shih and manuk hovanesian
Tomasz Wiszkowski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ameur Hosni
- Christian Xu
- Fred Shih
- manuk hovanesian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fred Shih (Gerrit)
6:29 PM (3 hours ago) 6:29 PM
to manuk hovanesian, Tomasz Wiszkowski, Ameur Hosni, Christian Xu, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Ameur Hosni, Christian Xu and manuk hovanesian
Fred Shih voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ameur Hosni
- Christian Xu
- manuk hovanesian
Reply all
Reply to author
Forward
0 new messages