[Extensions] Robustly handle UTF8 characters in URLPattern::MatchesPath [chromium/src : main]
0 views
Skip to first unread message
Devlin Cronin (Gerrit)
Aug 14, 2026, 1:23:54 PM (2 days ago) Aug 14
to Devlin Cronin, Andrea Orru, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Andrea Orru
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Andrea Orru
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrea Orru (Gerrit)
Aug 14, 2026, 1:47:27 PM (2 days ago) Aug 14
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Andrea Orru added 2 comments![]( "Open in Gerrit")
File extensions/common/url_pattern.cc
Line 634, Patchset 1 (Latest):
// Unlike the case-sensitive check above, a fallback to the raw strings is notAndrea Orru . unresolved
But as a result, when `case_sensitive == false`, different invalid byte sequences collide and wrongly match.
File extensions/common/url_pattern_unittest.cc
Line 1455, Patchset 1 (Latest):
EXPECT_FALSE(pattern.MatchesPath("/foo%E2bar"));Andrea Orru . unresolved
For the reason I explained above, if you add this check it will fail:
`EXPECT_FALSE(pattern.MatchesPath("/foo%E2bar", /*case_sensitive=*/false));`
Related details
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Aug 14, 2026, 4:15:59 PM (2 days ago) Aug 14
to Devlin Cronin, Andrea Orru, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Andrea Orru
Devlin Cronin added 3 comments![]( "Open in Gerrit")
File extensions/common/url_pattern.cc
Line 605, Patchset 2 (Latest):
if (unescaped_pattern.length() == unescaped_test.length() + 2 &&
base::StartsWith(unescaped_pattern, unescaped_test) &&
base::EndsWith(unescaped_pattern, "/*")) {Devlin Cronin . unresolved
I'll pull this out into a helper template in a followup
Line 634, Patchset 1:
// Unlike the case-sensitive check above, a fallback to the raw strings is notAndrea Orru . resolved
But as a result, when `case_sensitive == false`, different invalid byte sequences collide and wrongly match.
Devlin Cronin
good catch. I had thought about that when writing, and forgot to follow up on it.
Fixed... at the expense of making my head hurt.
File extensions/common/url_pattern_unittest.cc
For the reason I explained above, if you add this check it will fail:
`EXPECT_FALSE(pattern.MatchesPath("/foo%E2bar", /*case_sensitive=*/false));`
Attention is currently required from:
- Andrea Orru
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrea Orru (Gerrit)
Aug 14, 2026, 4:42:46 PM (2 days ago) Aug 14
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Andrea Orru voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrea Orru
| Code-Review | +1 |
1 comment
File extensions/common/url_pattern.cc
Line 605, Patchset 2 (Latest):
if (unescaped_pattern.length() == unescaped_test.length() + 2 &&
base::StartsWith(unescaped_pattern, unescaped_test) &&
base::EndsWith(unescaped_pattern, "/*")) {Devlin Cronin . resolved
I'll pull this out into a helper template in a followup
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Aug 14, 2026, 5:04:44 PM (2 days ago) Aug 14
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Devlin Cronin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 14, 2026, 7:53:27 PM (2 days ago) Aug 14
to Devlin Cronin, Andrea Orru, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Robustly handle UTF8 characters in URLPattern::MatchesPath
Add more robust handling for UTF8 matching in URLPattern paths. This
includes:
* Matching UTF8 characters when checking for /* variants
* Matching incomplete / invalid UTF8 characters
* Matching UTF8 characters in both case-sensitive and case-
insensitive variants (instead of just case-insensitive)
Add various unit tests for the above.
Among other things, this fixes utf8 paths for web-accessible resources.
Fixed: 545512660
Change-Id: I4220793773e001ad3e798834db96b0fe0f4aaf75
Reviewed-by: Andrea Orru <andre...@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680027}
Files:
- M chrome/browser/extensions/web_accessible_resources_browsertest.cc
- M extensions/common/url_pattern.cc
- M extensions/common/url_pattern_unittest.cc
Change size: M
Delta: 3 files changed, 211 insertions(+), 32 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrea Orru
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages