[Extensions] Fix test failure in ZeroStatePromoPageHandlerTest. [chromium/src : main]

0 views
Skip to first unread message

Emilia Paz (Gerrit)

unread,
Oct 30, 2025, 7:00:10 PM (7 days ago) Oct 30
to Yiming Zhou, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Yiming Zhou

Emilia Paz voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yiming Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2737b4f4345379e5e1f2d4237a282db28ea643cc
Gerrit-Change-Number: 7103075
Gerrit-PatchSet: 3
Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 22:59:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tim (Gerrit)

unread,
Oct 30, 2025, 7:02:07 PM (7 days ago) Oct 30
to Yiming Zhou, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Yiming Zhou

Tim voted and added 1 comment

Votes added by Tim

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Yiming Zhou
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2737b4f4345379e5e1f2d4237a282db28ea643cc
    Gerrit-Change-Number: 7103075
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
    Gerrit-Comment-Date: Thu, 30 Oct 2025 23:01:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Emilia Paz (Gerrit)

    unread,
    Oct 30, 2025, 7:02:41 PM (7 days ago) Oct 30
    to Yiming Zhou, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Yiming Zhou

    Emilia Paz voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yiming Zhou
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2737b4f4345379e5e1f2d4237a282db28ea643cc
      Gerrit-Change-Number: 7103075
      Gerrit-PatchSet: 3
      Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
      Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
      Gerrit-Reviewer: Tim <tjud...@chromium.org>
      Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
      Gerrit-Comment-Date: Thu, 30 Oct 2025 23:02:31 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Emilia Paz (Gerrit)

      unread,
      Oct 30, 2025, 7:02:52 PM (7 days ago) Oct 30
      to Yiming Zhou, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
      Attention needed from Yiming Zhou

      Emilia Paz voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Yiming Zhou
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2737b4f4345379e5e1f2d4237a282db28ea643cc
      Gerrit-Change-Number: 7103075
      Gerrit-PatchSet: 3
      Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
      Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
      Gerrit-Reviewer: Tim <tjud...@chromium.org>
      Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
      Gerrit-Comment-Date: Thu, 30 Oct 2025 23:02:42 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Emilia Paz (Gerrit)

      unread,
      Oct 30, 2025, 8:06:24 PM (7 days ago) Oct 30
      to Yiming Zhou, Chromium LUCI CQ, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
      Attention needed from Yiming Zhou

      Emilia Paz voted and added 1 comment

      Votes added by Emilia Paz

      Code-Review-1
      Owners-Override+0

      1 comment

      Patchset-level comments
      Emilia Paz . resolved

      Weird this didn't fix the issue. Before expected url was iph and actual iph_v2 and now is the opposite. Since it's causing a constant failure and is eod, reverting original CL and issue can be look at closer

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Yiming Zhou
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is blockingCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I2737b4f4345379e5e1f2d4237a282db28ea643cc
        Gerrit-Change-Number: 7103075
        Gerrit-PatchSet: 3
        Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
        Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
        Gerrit-Reviewer: Tim <tjud...@chromium.org>
        Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
        Gerrit-Comment-Date: Fri, 31 Oct 2025 00:06:14 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        blocking_requirement
        open
        diffy

        Yiming Zhou (Gerrit)

        unread,
        Nov 3, 2025, 4:09:36 PM (3 days ago) Nov 3
        to Chromium LUCI CQ, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

        Yiming Zhou abandoned this change

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is blockingCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: abandon
        satisfied_requirement
        blocking_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages