[Extensions] Move ExtensionGCMAppHandler to an API folder [chromium/src : main]
0 views
Skip to first unread message
Devlin Cronin (Gerrit)
Jan 7, 2026, 7:58:46 PM (2 days ago) Jan 7
to Devlin Cronin, Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Jan 8, 2026, 2:13:55 PM (20 hours ago) Jan 8
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Tim voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jan 8, 2026, 2:16:21 PM (20 hours ago) Jan 8
to Devlin Cronin, Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Devlin Cronin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 2:18:58 PM (20 hours ago) Jan 8
to Devlin Cronin, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Move ExtensionGCMAppHandler to an API folder
ExtensionGCMAppHandler is currently defined at
//chrome/browser/extensions, but is only needed for the GCM API, and
is primarily accessed by the GCM API (indeed, its corresponding tests
already live in //chrome/browser/extensions/api/gcm). Move the files
to //chrome/browser/extensions/api/gcm/extension_gcm_app_handler.* to
be consistent.
This is in preparation for pulling the GCM API into its own GN target.
This CL should have no behavior change.
Bug: 40245282
Change-Id: I881bef8ef5e75a29e73740cc1732f71830af1dc0
Bypass-Check-License: Just moving files
Reviewed-by: Tim <tjud...@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566451}
Files:
- M chrome/browser/extensions/BUILD.gn
- M chrome/browser/extensions/api/api_browser_context_keyed_service_factories.cc
- R chrome/browser/extensions/api/gcm/extension_gcm_app_handler.cc
- R chrome/browser/extensions/api/gcm/extension_gcm_app_handler.h
- M chrome/browser/extensions/api/gcm/extension_gcm_app_handler_unittest.cc
- M chrome/browser/extensions/api/gcm/gcm_api.cc
- M chrome/browser/extensions/api/gcm/gcm_apitest.cc
- M chrome/browser/extensions/api/instance_id/instance_id_apitest.cc
- M chrome/browser/extensions/keyed_services/chrome_browser_context_keyed_service_factories.cc
Change size: M
Delta: 9 files changed, 27 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tim
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages