Reland "[Extensions] V2 of Zero State Promo Chips IPH." [chromium/src : main]

0 views
Skip to first unread message

Yiming Zhou (Gerrit)

unread,
Oct 30, 2025, 10:43:40 PM (17 hours ago) Oct 30
to AyeAye, Chromium LUCI CQ, Dana Fried, Emilia Paz, chromium...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org, chromium-a...@chromium.org
Attention needed from Dana Fried and Emilia Paz

Yiming Zhou added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yiming Zhou . resolved

Fixed the offending test that caused this cl to be reverted in the 1st place:

ZeroStatePromoPageHandlerTest was not explicitly stating which variant of the IPH is being used in the test, and it seems that makes the test behave indeterministically, with different platforms using different variants.

The fix is to explicitly set the variant. Ironically, the test is not testing any variant-specific behavior.

Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
  • Emilia Paz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a72000d7ff71893753379dec48dd8158661aeb9
Gerrit-Change-Number: 7104328
Gerrit-PatchSet: 2
Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Attention: Emilia Paz <emil...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Oct 2025 02:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dana Fried (Gerrit)

unread,
1:50 PM (2 hours ago) 1:50 PM
to Yiming Zhou, AyeAye, Chromium LUCI CQ, Emilia Paz, chromium...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org, chromium-a...@chromium.org
Attention needed from Emilia Paz and Yiming Zhou

Dana Fried added 1 comment

File chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler_browsertest.cc
Line 89, Patchset 3 (Latest): base::test::ScopedFeatureList feature_list_;
Dana Fried . unresolved

You will need to use a `ScopedIPHFeatureList` or inherit from `InteractiveFeaturePromoTest`. You cannot enable IPH features via a vanilla ScopedFeatureList.

Open in Gerrit

Related details

Attention is currently required from:
  • Emilia Paz
  • Yiming Zhou
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a72000d7ff71893753379dec48dd8158661aeb9
    Gerrit-Change-Number: 7104328
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
    Gerrit-Attention: Emilia Paz <emil...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Oct 2025 17:50:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yiming Zhou (Gerrit)

    unread,
    2:16 PM (2 hours ago) 2:16 PM
    to AyeAye, Chromium LUCI CQ, Dana Fried, Emilia Paz, chromium...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org, chromium-a...@chromium.org
    Attention needed from Dana Fried and Emilia Paz

    Yiming Zhou added 1 comment

    File chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler_browsertest.cc
    Line 89, Patchset 3: base::test::ScopedFeatureList feature_list_;
    Dana Fried . resolved

    You will need to use a `ScopedIPHFeatureList` or inherit from `InteractiveFeaturePromoTest`. You cannot enable IPH features via a vanilla ScopedFeatureList.

    Yiming Zhou

    Thanks for pointing this out! Strangely, the original code using just a ScopedFeatureList also worked locally on my cloudtop - and I tried with different variants to make sure it wasn't due to non-deterministic behavior of the feature flag.

    Switched to ScopedIPHFeatureList.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dana Fried
    • Emilia Paz
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7a72000d7ff71893753379dec48dd8158661aeb9
      Gerrit-Change-Number: 7104328
      Gerrit-PatchSet: 4
      Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
      Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
      Gerrit-Attention: Dana Fried <dfr...@chromium.org>
      Gerrit-Attention: Emilia Paz <emil...@chromium.org>
      Gerrit-Comment-Date: Fri, 31 Oct 2025 18:16:50 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dana Fried <dfr...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dana Fried (Gerrit)

      unread,
      2:20 PM (2 hours ago) 2:20 PM
      to Yiming Zhou, AyeAye, Chromium LUCI CQ, Emilia Paz, chromium...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org, chromium-a...@chromium.org
      Attention needed from Emilia Paz and Yiming Zhou

      Dana Fried voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Emilia Paz
      • Yiming Zhou
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7a72000d7ff71893753379dec48dd8158661aeb9
        Gerrit-Change-Number: 7104328
        Gerrit-PatchSet: 4
        Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
        Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
        Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>
        Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
        Gerrit-Attention: Emilia Paz <emil...@chromium.org>
        Gerrit-Comment-Date: Fri, 31 Oct 2025 18:20:21 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Emilia Paz (Gerrit)

        unread,
        2:36 PM (2 hours ago) 2:36 PM
        to Yiming Zhou, Dana Fried, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org, chromium-a...@chromium.org
        Attention needed from Yiming Zhou

        Emilia Paz voted and added 1 comment

        Votes added by Emilia Paz

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 4 (Latest):
        Emilia Paz . resolved

        Thanks for fixing the test!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Yiming Zhou
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7a72000d7ff71893753379dec48dd8158661aeb9
        Gerrit-Change-Number: 7104328
        Gerrit-PatchSet: 4
        Gerrit-Owner: Yiming Zhou <uwyi...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
        Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
        Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>
        Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
        Gerrit-Comment-Date: Fri, 31 Oct 2025 18:36:13 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages