[Extensions WebIDL] Convert mojoPrivate to WebIDL [chromium/src : main]
0 views
Skip to first unread message
Tim (Gerrit)
Jan 27, 2026, 7:53:52 PM (3 days ago) Jan 27
to Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Tim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tim . resolved
Another small one for a very strange schema. This is one that we don't really compile any useful types for (as the only function on it is marked nocompile) and the whole thing actually gets handled by a custom JS hook and not our normal extension function system.
Related details
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Jan 28, 2026, 5:13:26 PM (2 days ago) Jan 28
to Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Jan 30, 2026, 3:40:39 PM (9 hours ago) Jan 30
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Tim voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Jan 30, 2026, 3:42:47 PM (9 hours ago) Jan 30
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Tim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tim
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Tim . resolved
Trying to manual CR+1 my own CL here to hopefully trigger the re-auth dialog so I can submit this CL 🙃
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 30, 2026, 4:29:15 PM (8 hours ago) Jan 30
to Tim, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions WebIDL] Convert mojoPrivate to WebIDL
This conversion was largely done using a detailed description of the
conversion process passed to Gemini CLI. To double check this work, the
file has also been copied into the converted schemas test to verify no
functional difference in output.
Fixed: 452428776
Change-Id: Idc83494fb9a296337afcaf3066e226b4c0926fdb
Reviewed-by: Emilia Paz <emil...@chromium.org>
Reviewed-by: Tim <tjud...@chromium.org>
Commit-Queue: Tim <tjud...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1577511}
Files:
- M extensions/common/api/generated_externs_list.txt
- A extensions/common/api/mojo_private.webidl
- M extensions/common/api/schema.gni
- R tools/json_schema_compiler/test/converted_schemas/mojo_private.idl
- A tools/json_schema_compiler/test/converted_schemas/mojo_private.webidl
- M tools/json_schema_compiler/web_idl_diff_tool_test.py
Change size: S
Delta: 6 files changed, 31 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emilia Paz, +1 by Tim
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages