Emilia Paz (Gerrit)

unread,

Mar 31, 2026, 6:17:44 PM (2 days ago) Mar 31

to Eva Su, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Eva Su

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Emilia Paz . resolved

Eva, mind taking a look?

Open in Gerrit

Related details

Attention is currently required from:

Eva Su

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eva Su (Gerrit)

unread,

Apr 1, 2026, 6:53:45 PM (20 hours ago) Apr 1

to Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Emilia Paz

Eva Su voted and added 2 comments

Votes added by Eva Su

Code-Review

+1

2 comments

File chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionsMenuMediator.java

Line 146, Patchset 6 (Latest): if (getCurrentPage() == ExtensionsMenuProperties.Page.MAIN) {

Eva Su . unresolved

can you pull this out into a helper?

Line 390, Patchset 6 (Latest):

        // Site access requests only affect the main page.
        if (getCurrentPage() == ExtensionsMenuProperties.Page.MAIN) {
            updateHostAccessRequests();
        }

Eva Su . unresolved

can we also pull this out into a helper and call it something like `maybeUpdateHostAccessRequests()`?

Open in Gerrit

Related details

Attention is currently required from:

Emilia Paz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emilia Paz (Gerrit)

unread,

Apr 1, 2026, 9:06:34 PM (18 hours ago) Apr 1

to AyeAye, Eva Su, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Eva Su

Emilia Paz voted and added 2 comments

Votes added by Emilia Paz

Auto-Submit	+1
Commit-Queue	+2

2 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Emilia Paz . resolved

Thanks Eva! Lost +1 because a gitlink was wrongly added. Mind stamping again?

File chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionsMenuMediator.java

Line 146, Patchset 6: if (getCurrentPage() == ExtensionsMenuProperties.Page.MAIN) {

Eva Su . resolved

can you pull this out into a helper?

Emilia Paz

Thought about it, but I like the flexibility of getting the type and then each method checks for what it needs. Once methods are implemented can see what is better

Open in Gerrit

Related details

Attention is currently required from:

Eva Su

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eva Su (Gerrit)

unread,

Apr 1, 2026, 9:10:26 PM (18 hours ago) Apr 1

to Emilia Paz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Emilia Paz

Eva Su voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Emilia Paz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emilia Paz (Gerrit)

unread,

Apr 1, 2026, 9:38:26 PM (17 hours ago) Apr 1

to Eva Su, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Eva Su

Emilia Paz voted and added 2 comments

Votes added by Emilia Paz

Auto-Submit	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Emilia Paz . resolved

aaaaa I lost it again because a gitlink :(

File chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionsMenuMediator.java

Line 390, Patchset 6: // Site access requests only affect the main page.


        if (getCurrentPage() == ExtensionsMenuProperties.Page.MAIN) {
            updateHostAccessRequests();
        }

Eva Su . resolved

can we also pull this out into a helper and call it something like `maybeUpdateHostAccessRequests()`?

Emilia Paz

Done

Open in Gerrit

Related details

Attention is currently required from:

Eva Su

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eva Su (Gerrit)

unread,

1:07 PM (2 hours ago) 1:07 PM

to Emilia Paz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Emilia Paz

Eva Su voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Emilia Paz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

1:15 PM (2 hours ago) 1:15 PM

to Emilia Paz, Eva Su, AyeAye, chromium...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Extensions] Add getCurrentPage to ExtensionsMenuMediator

The extensions menu will soon contain a site permissions page in addition to the main extensions list. The existing mediator logic assumed only the main page existed and would update its contents unconditionally. This would be incorrect when another page is active.

This change replaces the boolean isMainPageVisible() with a getCurrentPage() method that returns the current page enum. This allows observer methods (onModelChanged, onActionAdded, onActionUpdated, etc.) to check which page is currently displayed before applying UI updates. This prevents unnecessary updates to hidden pages and prepares the mediator for the site permissions page implementation.

Bug: 432392216

Change-Id: I4af0f309561d40e23deb4d4bae13ca245ffb5e89

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718701

Reviewed-by: Eva Su <ev...@chromium.org>

Commit-Queue: Emilia Paz <emil...@chromium.org>

Auto-Submit: Emilia Paz <emil...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1609314}

Files:

M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionsMenuMediator.java

Change size: M

Delta: 1 file changed, 90 insertions(+), 62 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Eva Su

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Extensions] Add getCurrentPage to ExtensionsMenuMediator [chromium/src : main]

Emilia Paz (Gerrit)

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

1 comment

Related details

Eva Su (Gerrit)

Eva Su voted and added 2 comments

Votes added by Eva Su

2 comments

Related details

Emilia Paz (Gerrit)

Emilia Paz voted and added 2 comments

Votes added by Emilia Paz

2 comments

Related details

Eva Su (Gerrit)

Eva Su voted Code-Review+1

Related details

Emilia Paz (Gerrit)

Emilia Paz voted and added 2 comments

Votes added by Emilia Paz

2 comments

Related details

Eva Su (Gerrit)

Eva Su voted Code-Review+1

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information