[Desktop Android CRX] Add a test for service worker-based extensions [chromium/src : main]
94 views
Skip to first unread message
Devlin Cronin (Gerrit)
Sep 11, 2024, 2:06:52 PM9/11/24
to Devlin Cronin, David Bertoni, Chromium LUCI CQ, Tricium, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from David Bertoni
Devlin Cronin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- David Bertoni
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Bertoni (Gerrit)
Sep 11, 2024, 4:49:28 PM9/11/24
to Devlin Cronin, Chromium LUCI CQ, Tricium, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
David Bertoni voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Bertoni
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Sep 11, 2024, 6:54:06 PM9/11/24
to Devlin Cronin, David Bertoni, Chromium LUCI CQ, Tricium, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Devlin Cronin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 11, 2024, 6:57:06 PM9/11/24
to Devlin Cronin, David Bertoni, Tricium, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Desktop Android CRX] Add a test for service worker-based extensions
We are experimenting with desktop-android configurations for Chrome.
This CL adds a new test for service worker-based extensions. These have
already been effectively enabeld and functional by previous CLs; this CL
merely adds test coverage for them.
This CL has no behavior change.
Cq-Include-Trybots: luci.chromium.try:android-desktop-arm64-compile-rel,android-desktop-x64-compile-rel
Bug: 356905053
Change-Id: I5e2b2fddd927329e75c8011c6e3360bb7799aae9
Reviewed-by: David Bertoni <dber...@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354244}
Files:
- M chrome/browser/extensions/desktop_android/desktop_android_extensions_browsertest.cc
Change size: M
Delta: 1 file changed, 66 insertions(+), 29 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Bertoni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages