[Force Save to Cloud] Add FailState::LOCAL_DOWNLOAD_BLOCKED [chromium/src : main]

[Colin Blundell (Gerrit)]

Attention needed from Nasser Al-shawwa

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Colin Blundell . resolved

Thanks! It looks like there are bots to fix? Once that's done, could you add a closer OWNER of all the download-related code as a reviewer?

Open in Gerrit

Related details

Attention is currently required from:

• Nasser Al-shawwa

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 4

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Comment-Date: Thu, 08 Jan 2026 08:10:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nasser Al-shawwa (Gerrit)]

Attention needed from Colin Blundell and Xinghui Lu

Nasser Al-shawwa added 1 comment

Patchset-level comments

File-level comment, Patchset 4:

Colin Blundell . resolved

Thanks! It looks like there are bots to fix? Once that's done, could you add a closer OWNER of all the download-related code as a reviewer?

Nasser Al-shawwa

Added Xinghui for the main download-related code, kept you for the rest of the files. Does that work?

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Xinghui Lu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 5

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xinghui Lu <xing...@chromium.org>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Thu, 08 Jan 2026 19:35:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>

[Min Qin (Gerrit)]

Attention needed from Colin Blundell, Nasser Al-shawwa and Xinghui Lu

Min Qin added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Min Qin . resolved

do you have a design doc or PRD so that I can get some background information about this CL?

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Nasser Al-shawwa
• Xinghui Lu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 5

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Min Qin <qin...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xinghui Lu <xing...@chromium.org>

Gerrit-Attention: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Thu, 08 Jan 2026 19:40:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Xinghui Lu (Gerrit)]

Attention needed from Colin Blundell and Nasser Al-shawwa

Xinghui Lu voted and added 1 comment

Votes added by Xinghui Lu

Code-Review

+1

1 comment

File components/download/public/common/download_interrupt_reason_values.h

Line 146, Patchset 5 (Latest):// Local download blocked

Xinghui Lu . unresolved

Could you add a bit more details here?

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Nasser Al-shawwa

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 5

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Min Qin <qin...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Thu, 08 Jan 2026 20:11:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Min Qin (Gerrit)]

Attention needed from Colin Blundell and Nasser Al-shawwa

Min Qin added 1 comment

File chrome/browser/ui/download/download_bubble_security_view_info.cc

Line 226, Patchset 5 (Latest): case FailState::LOCAL_DOWNLOAD_BLOCKED:

Min Qin . unresolved

you also need to update here to show user a warning message that the download is getting blocked: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/download_ui_controller.cc;l=248
and here:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/download_offline_content_provider.cc;l=479

Gerrit-Comment-Date: Thu, 08 Jan 2026 21:15:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nasser Al-shawwa (Gerrit)]

Attention needed from Colin Blundell and Min Qin

Nasser Al-shawwa added 2 comments

File chrome/browser/ui/download/download_bubble_security_view_info.cc

Line 226, Patchset 5 (Latest): case FailState::LOCAL_DOWNLOAD_BLOCKED:

Min Qin . unresolved

you also need to update here to show user a warning message that the download is getting blocked: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/download_ui_controller.cc;l=248
and here:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/download_offline_content_provider.cc;l=479

Nasser Al-shawwa

This will be done in a subsequent CL, and is intentionally omitted here. This CL is just to introduce the new FAIL_STATE and make it mimic FILE_BLOCKED behaviour. The logical separation means that if I make a mistake with introducing the string, I can roll it back and still keep the new FAIL_STATE.

File components/download/public/common/download_interrupt_reason_values.h

Line 146, Patchset 5 (Latest):// Local download blocked

Xinghui Lu . resolved

Could you add a bit more details here?

Nasser Al-shawwa

Marked as resolved.

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Min Qin

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 5

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Min Qin <qin...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Min Qin <qin...@chromium.org>

Gerrit-Comment-Date: Thu, 08 Jan 2026 21:24:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Xinghui Lu <xing...@chromium.org>

Comment-In-Reply-To: Min Qin <qin...@chromium.org>

[Min Qin (Gerrit)]

Attention needed from Colin Blundell and Nasser Al-shawwa

Min Qin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Nasser Al-shawwa

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 6

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Min Qin <qin...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Thu, 08 Jan 2026 21:30:58 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Nasser Al-shawwa (Gerrit)]

Attention needed from Colin Blundell

Nasser Al-shawwa added 1 comment

File chrome/browser/ui/download/download_bubble_security_view_info.cc

Line 226, Patchset 5: case FailState::LOCAL_DOWNLOAD_BLOCKED:

Min Qin . resolved

you also need to update here to show user a warning message that the download is getting blocked: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/download_ui_controller.cc;l=248
and here:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/download_offline_content_provider.cc;l=479

Nasser Al-shawwa

This will be done in a subsequent CL, and is intentionally omitted here. This CL is just to introduce the new FAIL_STATE and make it mimic FILE_BLOCKED behaviour. The logical separation means that if I make a mistake with introducing the string, I can roll it back and still keep the new FAIL_STATE.

Nasser Al-shawwa

Done

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 6

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Min Qin <qin...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 06:45:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nasser Al-shawwa <alsh...@chromium.org>

Comment-In-Reply-To: Min Qin <qin...@chromium.org>

[Colin Blundell (Gerrit)]

Attention needed from Nasser Al-shawwa

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Nasser Al-shawwa

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 6

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Min Qin <qin...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 08:05:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Nasser Al-shawwa (Gerrit)]

Nasser Al-shawwa voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I973151c825acf6f6a53a65ce6cd41faf247c3735

Gerrit-Change-Number: 7410683

Gerrit-PatchSet: 6

Gerrit-Owner: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Min Qin <qin...@chromium.org>

Gerrit-Reviewer: Nasser Al-shawwa <alsh...@chromium.org>

Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 09 Jan 2026 13:48:36 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes