Replace `std::set` with `absl::flat_hash_set`. [chromium/src : main]
0 views
Skip to first unread message
Reilly Grant (Gerrit)
Jan 29, 2026, 4:10:30 PM (2 days ago) Jan 29
to Jeffrey Yu, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Jeffrey Yu
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Reilly Grant
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Jan 29, 2026, 4:25:23 PM (2 days ago) Jan 29
to Emilia Paz, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Jeffrey Yu voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Jan 29, 2026, 4:57:17 PM (2 days ago) Jan 29
to Jeffrey Yu, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Jeffrey Yu
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 29, 2026, 5:00:20 PM (2 days ago) Jan 29
to Jeffrey Yu, Emilia Paz, Reilly Grant, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace `std::set` with `absl::flat_hash_set`.
The Chromium containers guide
(https://chromium.googlesource.com/chromium/src/+/HEAD/base/containers/README.md)
recommends using `absl::flat_hash_set` as a default set choice when
stable iteration order and pointer stability isn't needed. It generally
perform better and require less overhead than STL sets.
Bug: 473916362
Change-Id: I5b0f25fee61219f04cb7e2044d4795b5a5c54939
Reviewed-by: Emilia Paz <emil...@chromium.org>
Reviewed-by: Reilly Grant <rei...@chromium.org>
Commit-Queue: Emilia Paz <emil...@chromium.org>
Auto-Submit: Jeffrey Yu <yu...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1576845}
Files:
- M chrome/browser/extensions/preinstalled_apps.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emilia Paz, +1 by Reilly Grant
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Bennetts (Gerrit)
Jan 30, 2026, 4:06:51 PM (11 hours ago) Jan 30
to Jeffrey Yu, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Jeffrey Yu
Steven Bennetts voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Jan 30, 2026, 4:28:40 PM (11 hours ago) Jan 30
to Reilly Grant, Steven Bennetts, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Reilly Grant
Jeffrey Yu voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
Jan 30, 2026, 4:40:56 PM (11 hours ago) Jan 30
to Jeffrey Yu, Reilly Grant, Steven Bennetts, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Jeffrey Yu
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Reilly Grant
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Reilly Grant . resolved
LGTM
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 30, 2026, 4:43:56 PM (11 hours ago) Jan 30
to Jeffrey Yu, Reilly Grant, Steven Bennetts, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace `std::set` with `absl::flat_hash_set`.
The Chromium containers guide
(https://chromium.googlesource.com/chromium/src/+/HEAD/base/containers/README.md)
recommends using `absl::flat_hash_set` as a default set choice when
stable iteration order and pointer stability isn't needed. It generally
perform better and require less overhead than STL sets.
Bug: 473916362
Change-Id: I87ef7bbbbdb92d803c3177e6217804c9af42b97b
Reviewed-by: Reilly Grant <rei...@chromium.org>
Commit-Queue: Reilly Grant <rei...@chromium.org>
Auto-Submit: Jeffrey Yu <yu...@chromium.org>
Reviewed-by: Steven Bennetts <stev...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1577522}
Files:
- M extensions/browser/api/system_display/system_display_api.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Reilly Grant, +1 by Steven Bennetts
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Jan 30, 2026, 6:38:49 PM (9 hours ago) Jan 30
to Jeffrey Yu, Kevin McNee, James Maclean, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Jeffrey Yu
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
1 comment
File extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
Line 272, Patchset 1 (Latest):
const std::string_view name = script_value.name;Emilia Paz . unresolved
I think we can keep this as `string` so we don't have to convert it back on line 284. a`bsl::flat_hash_set<std::string_view>` should handle a `std::string` key efficiently via implicit conversion. But I'm not 100% sure so I'm ok with the change too
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Jan 30, 2026, 8:53:29 PM (6 hours ago) Jan 30
to Jeffrey Yu, Kevin McNee, James Maclean, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Jeffrey Yu
Emilia Paz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Jan 30, 2026, 9:32:50 PM (6 hours ago) Jan 30
to Reilly Grant, Kevin McNee, James Maclean, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Reilly Grant
Jeffrey Yu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jeffrey Yu
| Auto-Submit | +1 |
1 comment
File extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
I think we can keep this as `string` so we don't have to convert it back on line 284. a`bsl::flat_hash_set<std::string_view>` should handle a `std::string` key efficiently via implicit conversion. But I'm not 100% sure so I'm ok with the change too
Attention is currently required from:
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
Jan 30, 2026, 9:50:32 PM (6 hours ago) Jan 30
to Jeffrey Yu, Reilly Grant, Kevin McNee, James Maclean, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Jeffrey Yu
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Reilly Grant
| Code-Review | +1 |
| Commit-Queue | +2 |
Reilly Grant . resolved
LGTM
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 30, 2026, 10:01:11 PM (5 hours ago) Jan 30
to Jeffrey Yu, Reilly Grant, Emilia Paz, Kevin McNee, James Maclean, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace `std::set` with `absl::flat_hash_set`.
The Chromium containers guide
(https://chromium.googlesource.com/chromium/src/+/HEAD/base/containers/README.md)
recommends using `absl::flat_hash_set` as a default set choice when
stable iteration order and pointer stability isn't needed. It generally
perform better and require less overhead than STL sets.
Bug: 473916362
Change-Id: Iab823c0c1287f77dd50cd78dce16a399cdd9fd94
Reviewed-by: Emilia Paz <emil...@chromium.org>
Reviewed-by: Reilly Grant <rei...@chromium.org>
Commit-Queue: Reilly Grant <rei...@chromium.org>
Commit-Queue: Jeffrey Yu <yu...@chromium.org>
Auto-Submit: Jeffrey Yu <yu...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1577659}
Files:
- M extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Reilly Grant, +1 by Emilia Paz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages