Delete unused extensions::Bloсklist::GetMalwareIds [chromium/src : main]

0 views
Skip to first unread message

Alexander Kalugin (Gerrit)

unread,
6:01 AM (11 hours ago) 6:01 AM
to Finnur Thorarinsson, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin

Alexander Kalugin added 1 comment

Commit Message
Line 7, Patchset 1:Delete unused extensions::Blobklist::GetMalwareIds
Finnur Thorarinsson . resolved

Typo nit: s/Blobklist/Blocklist/

Alexander Kalugin

Thanks! Fixed.

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e0c930207d38932c0ba32c82e2501a9863d3019
Gerrit-Change-Number: 7889556
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Kalugin <akal...@yandex-team.ru>
Gerrit-Reviewer: Alexander Kalugin <akal...@yandex-team.ru>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Finnur Thorarinsson <fin...@chromium.org>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 10:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Finnur Thorarinsson <fin...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Devlin Cronin (Gerrit)

unread,
1:57 PM (3 hours ago) 1:57 PM
to Alexander Kalugin, Devlin Cronin, Finnur Thorarinsson, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Alexander Kalugin

Devlin Cronin voted and added 1 comment

Votes added by Devlin Cronin

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Devlin Cronin . resolved

LGTM! Thank you for the cleanup, Alexander!

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Kalugin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e0c930207d38932c0ba32c82e2501a9863d3019
    Gerrit-Change-Number: 7889556
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alexander Kalugin <akal...@yandex-team.ru>
    Gerrit-Reviewer: Alexander Kalugin <akal...@yandex-team.ru>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Finnur Thorarinsson <fin...@chromium.org>
    Gerrit-Attention: Alexander Kalugin <akal...@yandex-team.ru>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 17:57:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages