flyout: Implement FlyoutHandler to ChromeSelectionDropdownMenuDelegate [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Oct 30, 2025, 5:55:34 PM (22 hours ago) Oct 30
to AyeAye, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, android-web...@chromium.org, aji...@samsung.com, srahim...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a0e72bb7d858e56b16c26347d7ff983ed9971cd
Gerrit-Change-Number: 7082627
Gerrit-PatchSet: 14
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 21:55:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 30, 2025, 6:48:02 PM (21 hours ago) Oct 30
to AyeAye, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, android-web...@chromium.org, aji...@samsung.com, srahim...@chromium.org
Gerrit-Comment-Date: Thu, 30 Oct 2025 22:47:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 30, 2025, 7:20:34 PM (21 hours ago) Oct 30
to Bo Liu, Wenyu Fu, AyeAye, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, android-web...@chromium.org, aji...@samsung.com, srahim...@chromium.org

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 14:
Masa Fujita . resolved

@bo...@chromium.org PTAL under /content and AwSelectionDropdownMenuDelegate
@wen...@chromium.org PTAL ChromeSelectionDropdownMenuDelegate

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a0e72bb7d858e56b16c26347d7ff983ed9971cd
Gerrit-Change-Number: 7082627
Gerrit-PatchSet: 15
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-CC: Bo Liu <bo...@chromium.org>
Gerrit-CC: Wenyu Fu <wen...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 23:20:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bo Liu (Gerrit)

unread,
Oct 30, 2025, 7:48:03 PM (20 hours ago) Oct 30
to Masa Fujita, Bo Liu, Wenyu Fu, Jenna Himawan, AyeAye, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, android-web...@chromium.org, aji...@samsung.com, srahim...@chromium.org
Attention needed from Masa Fujita and Wenyu Fu

Bo Liu voted and added 2 comments

Votes added by Bo Liu

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 15 (Latest):
Bo Liu . resolved

stamp mostly

File content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
Line 719, Patchset 15 (Latest): HierarchicalMenuController hierarchicalMenuController =
Bo Liu . unresolved

can you explain why this is now created for every show call? and put it in the CL description

Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
  • Wenyu Fu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4a0e72bb7d858e56b16c26347d7ff983ed9971cd
    Gerrit-Change-Number: 7082627
    Gerrit-PatchSet: 15
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
    Gerrit-CC: Jenna Himawan <jhim...@google.com>
    Gerrit-Attention: Masa Fujita <mas...@google.com>
    Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
    Gerrit-Comment-Date: Thu, 30 Oct 2025 23:47:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages