Devlin Cronin (Gerrit)

unread,

Jan 30, 2026, 1:36:18 PM (11 hours ago) Jan 30

to Devlin Cronin, Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Emilia Paz

Devlin Cronin added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Devlin Cronin . resolved

Emilia, mind taking a look?

Android bot must be a flake, because this ensures the test doesn't run on any android bots

File chrome/browser/extensions/api/tabs/tabs_apitest.cc

Line 237, Patchset 2 (Latest):#endif // BUILDFLAG(ENABLE_EXTENSIONS)

Devlin Cronin . unresolved

have to put this back behind enable_extensions, since we don't have the implementation for tabs.highlight yet

Open in Gerrit

Related details

Attention is currently required from:

Emilia Paz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emilia Paz (Gerrit)

unread,

Jan 30, 2026, 2:48:30 PM (10 hours ago) Jan 30

to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin

Emilia Paz voted and added 3 comments

Votes added by Emilia Paz

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Emilia Paz . resolved

Thanks Devlin!

File chrome/browser/extensions/api/tabs/tabs_apitest.cc

Line 237, Patchset 2 (Latest):#endif // BUILDFLAG(ENABLE_EXTENSIONS)

Devlin Cronin . resolved

have to put this back behind enable_extensions, since we don't have the implementation for tabs.highlight yet

Emilia Paz

Acknowledged

File chrome/test/data/extensions/api_test/tabs/basics/highlight/highlight.js

Line 57, Patchset 2 (Latest): // Note: tabs.onHighlightChanged is deprecated.

Emilia Paz . unresolved

nit: lets remove this commet

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Devlin Cronin (Gerrit)

unread,

Jan 30, 2026, 3:45:59 PM (9 hours ago) Jan 30

to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Devlin Cronin voted and added 2 comments

Votes added by Devlin Cronin

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Devlin Cronin . resolved

Thanks, Emilia!

File chrome/test/data/extensions/api_test/tabs/basics/highlight/highlight.js

Line 57, Patchset 2: // Note: tabs.onHighlightChanged is deprecated.

Emilia Paz . resolved

nit: lets remove this commet

Devlin Cronin

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 30, 2026, 4:39:19 PM (8 hours ago) Jan 30

to Devlin Cronin, Emilia Paz, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/test/data/extensions/api_test/tabs/basics/highlight/highlight.js
Insertions: 0, Deletions: 1.

@@ -54,7 +54,6 @@
     chrome.tabs.query({windowId: testWindowId1, url: 'http://a.com/*'},
                       pass(function(tabs) {
       assertEq(4, tabs.length);
-      // Note: tabs.onHighlightChanged is deprecated.
       chrome.test.listenOnce(chrome.tabs.onHighlighted,
                              function(highlightInfo) {
         var tabIds = tabs.map(function(tab) { return tab.id; });
```

Change information

Commit message:

[Extensions] Re-enable ExtensionApiTabTestWithContextType.Highlight

ExtensionApiTabTestWithContextType.Highlight was disabled for flakiness,
likely because on of its subtests relies on current window focus, but it
runs as a browser test (not an interactive UI test).

Instead of having the whole test disabled, just disable (by commenting
out) the single small subtest that relies on current window focus. This
gives us increased test coverage and will allow us to validate changes
we make for porting this to desktop android.

Bug: 449095632, 40254426, 40890826

Change-Id: Idb11eb45cb14733e6ffc661d7a0a421dac03b982

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7533584

Reviewed-by: Emilia Paz <emil...@chromium.org>

Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1577520}

Files:

M chrome/browser/extensions/api/tabs/tabs_apitest.cc
M chrome/test/data/extensions/api_test/tabs/basics/highlight/highlight.js

Change size: S

Delta: 2 files changed, 16 insertions(+), 15 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Emilia Paz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Extensions] Re-enable ExtensionApiTabTestWithContextType.Highlight [chromium/src : main]

Devlin Cronin (Gerrit)

Devlin Cronin added 2 comments

Related details

Emilia Paz (Gerrit)

Emilia Paz voted and added 3 comments

Votes added by Emilia Paz

3 comments

Related details

Devlin Cronin (Gerrit)

Devlin Cronin voted and added 2 comments

Votes added by Devlin Cronin

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information