[Extensions] Update aliasing namespace tests for clarity. [chromium/src : main]
0 views
Skip to first unread message
Justin Lulejian (Gerrit)
Jan 8, 2026, 2:54:21 PM (20 hours ago) Jan 8
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Justin Lulejian voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jan 8, 2026, 5:05:30 PM (18 hours ago) Jan 8
to Justin Lulejian, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Justin Lulejian
Devlin Cronin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Justin Lulejian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Lulejian (Gerrit)
Jan 8, 2026, 5:05:54 PM (18 hours ago) Jan 8
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Justin Lulejian voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 5:10:09 PM (17 hours ago) Jan 8
to Justin Lulejian, Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Update aliasing namespace tests for clarity.
Refines the tests for chrome and browser namespace bindings by:
1) removing redundant assertions (that affect behavior due to lazy
property instantiation)
2) updating comments to better describe the difference between API
instances (like runtime) and aliased ones
(like devtools)
Bug: 470092691
Change-Id: Ie3a6d4cc56d64e088d2c30414701507b06cb99da
Commit-Queue: Justin Lulejian <jlul...@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
Auto-Submit: Justin Lulejian <jlul...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566542}
Files:
- M chrome/browser/extensions/native_bindings_apitest.cc
Change size: S
Delta: 1 file changed, 19 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Devlin Cronin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages