[Extensions] Update aliasing namespace tests for clarity. [chromium/src : main]

0 views
Skip to first unread message

Justin Lulejian (Gerrit)

unread,
Jan 8, 2026, 2:54:21 PM (20 hours ago) Jan 8
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin

Justin Lulejian voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie3a6d4cc56d64e088d2c30414701507b06cb99da
Gerrit-Change-Number: 7416328
Gerrit-PatchSet: 1
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 19:54:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Devlin Cronin (Gerrit)

unread,
Jan 8, 2026, 5:05:30 PM (18 hours ago) Jan 8
to Justin Lulejian, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Justin Lulejian

Devlin Cronin voted and added 1 comment

Votes added by Devlin Cronin

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Devlin Cronin . resolved

LGTM; thanks, Justin!

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Lulejian
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie3a6d4cc56d64e088d2c30414701507b06cb99da
Gerrit-Change-Number: 7416328
Gerrit-PatchSet: 1
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
Gerrit-Attention: Justin Lulejian <jlul...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 22:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Justin Lulejian (Gerrit)

unread,
Jan 8, 2026, 5:05:54 PM (18 hours ago) Jan 8
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Justin Lulejian voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie3a6d4cc56d64e088d2c30414701507b06cb99da
Gerrit-Change-Number: 7416328
Gerrit-PatchSet: 1
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 22:05:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 8, 2026, 5:10:09 PM (17 hours ago) Jan 8
to Justin Lulejian, Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Extensions] Update aliasing namespace tests for clarity.

Refines the tests for chrome and browser namespace bindings by:
1) removing redundant assertions (that affect behavior due to lazy
property instantiation)
2) updating comments to better describe the difference between API
instances (like runtime) and aliased ones
(like devtools)
Bug: 470092691
Change-Id: Ie3a6d4cc56d64e088d2c30414701507b06cb99da
Commit-Queue: Justin Lulejian <jlul...@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
Auto-Submit: Justin Lulejian <jlul...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566542}
Files:
  • M chrome/browser/extensions/native_bindings_apitest.cc
Change size: S
Delta: 1 file changed, 19 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Devlin Cronin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie3a6d4cc56d64e088d2c30414701507b06cb99da
Gerrit-Change-Number: 7416328
Gerrit-PatchSet: 2
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages