glic: Implement activateTabWithConversation in glicPrivate API [chromium/src : main]

[Wei Guo (Gerrit)]

Attention needed from Bryant Chandler, Justin DeWitt and Theodore Olsauskas-Warren

Wei Guo voted and added 3 comments

Votes added by Wei Guo

Commit-Queue

+1

3 comments

Patchset-level comments

File-level comment, Patchset 27:

Justin DeWitt . resolved

Do we need to also focus the text box inside Bluebird when this happens?

Bryant Chandler

If that's a requirement, then it would need to call show. There's no guarantee that the panel is showing on the selected tab.

Wei Guo

Sounds like a good QoL improvement, but I am not aware of a PRD for this feature yet. I imagine we can follow up when the requirement is there.

File chrome/browser/glic/service/glic_instance_coordinator_impl.cc

Line 308, Patchset 27: base::UmaHistogramCounts100("Glic.ActivateTab.CandidateTabCount",

Bryant Chandler . resolved

This is a bit ambiguous. maybe better to Use ActivateTabWithConversation

Wei Guo

Done

Line 308, Patchset 27: base::UmaHistogramCounts100("Glic.ActivateTab.CandidateTabCount",
target_tabs.size());

Bryant Chandler . resolved

Please put this in GlicInstanceCoordinatorMetrics.

Wei Guo

Done

Open in Gerrit

Related details

Attention is currently required from:

• Bryant Chandler
• Justin DeWitt
• Theodore Olsauskas-Warren

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8b2440cddfe1dc7c54e27880cf2fc4ec72701cb

Gerrit-Change-Number: 7801418

Gerrit-PatchSet: 30

Gerrit-Owner: Wei Guo <wei...@google.com>

Gerrit-Reviewer: Bryant Chandler <bryantc...@chromium.org>

Gerrit-Reviewer: Justin DeWitt <dew...@chromium.org>

Gerrit-Reviewer: Theodore Olsauskas-Warren <sau...@google.com>

Gerrit-Reviewer: Wei Guo <wei...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Roman Arora <roman...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Justin DeWitt <dew...@chromium.org>

Gerrit-Attention: Bryant Chandler <bryantc...@chromium.org>

Gerrit-Attention: Theodore Olsauskas-Warren <sau...@google.com>

Gerrit-Comment-Date: Fri, 29 May 2026 19:43:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Justin DeWitt <dew...@chromium.org>

Comment-In-Reply-To: Bryant Chandler <bryantc...@chromium.org>

[Justin DeWitt (Gerrit)]

Attention needed from Bryant Chandler, Theodore Olsauskas-Warren and Wei Guo

Justin DeWitt voted and added 1 comment

Votes added by Justin DeWitt

Code-Review

+1

1 comment

File chrome/browser/extensions/api/glic_private/glic_private_apitest.cc

Line 141, Patchset 31 (Latest): {.load_as_component = true}))

Justin DeWitt . unresolved

I wonder if this is actually the offending part here, since the comment claims to load the test in a non-extension page. Maybe this belongs in GlicMessagingBrowserTest?

Open in Gerrit

Related details

Attention is currently required from:

• Bryant Chandler
• Theodore Olsauskas-Warren
• Wei Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8b2440cddfe1dc7c54e27880cf2fc4ec72701cb

Gerrit-Change-Number: 7801418

Gerrit-PatchSet: 31

Gerrit-Owner: Wei Guo <wei...@google.com>

Gerrit-Reviewer: Bryant Chandler <bryantc...@chromium.org>

Gerrit-Reviewer: Justin DeWitt <dew...@chromium.org>

Gerrit-Reviewer: Theodore Olsauskas-Warren <sau...@google.com>

Gerrit-Reviewer: Wei Guo <wei...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Roman Arora <roman...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Wei Guo <wei...@google.com>

Gerrit-Attention: Bryant Chandler <bryantc...@chromium.org>

Gerrit-Attention: Theodore Olsauskas-Warren <sau...@google.com>

Gerrit-Comment-Date: Mon, 01 Jun 2026 16:51:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Bryant Chandler (Gerrit)]

Attention needed from Theodore Olsauskas-Warren and Wei Guo

Bryant Chandler voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Theodore Olsauskas-Warren
• Wei Guo

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8b2440cddfe1dc7c54e27880cf2fc4ec72701cb

Gerrit-Change-Number: 7801418

Gerrit-PatchSet: 31

Gerrit-Owner: Wei Guo <wei...@google.com>

Gerrit-Reviewer: Bryant Chandler <bryantc...@chromium.org>

Gerrit-Reviewer: Justin DeWitt <dew...@chromium.org>

Gerrit-Reviewer: Theodore Olsauskas-Warren <sau...@google.com>

Gerrit-Reviewer: Wei Guo <wei...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Roman Arora <roman...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Wei Guo <wei...@google.com>

Gerrit-Attention: Theodore Olsauskas-Warren <sau...@google.com>

Gerrit-Comment-Date: Mon, 01 Jun 2026 17:21:18 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Theodore Olsauskas-Warren (Gerrit)]

Attention needed from Wei Guo

Theodore Olsauskas-Warren voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Wei Guo

Gerrit-Comment-Date: Mon, 01 Jun 2026 18:23:11 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Wei Guo (Gerrit)]

Attention needed from Justin DeWitt

Wei Guo added 1 comment

File chrome/browser/extensions/api/glic_private/glic_private_apitest.cc

Line 141, Patchset 31 (Latest): {.load_as_component = true}))

Justin DeWitt . unresolved

I wonder if this is actually the offending part here, since the comment claims to load the test in a non-extension page. Maybe this belongs in GlicMessagingBrowserTest?

Wei Guo

Can you clarify what 'offending' mean here? Does it mean this is the only test that requires "serviceworker" as the custom_arg?

Open in Gerrit

Related details

Attention is currently required from:

• Justin DeWitt

Gerrit-Attention: Justin DeWitt <dew...@chromium.org>

Gerrit-Comment-Date: Mon, 01 Jun 2026 19:25:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Justin DeWitt <dew...@chromium.org>

[Justin DeWitt (Gerrit)]

Attention needed from Wei Guo

Justin DeWitt added 1 comment

File chrome/browser/extensions/api/glic_private/glic_private_apitest.cc

Line 141, Patchset 31 (Latest): {.load_as_component = true}))

Justin DeWitt . unresolved

I wonder if this is actually the offending part here, since the comment claims to load the test in a non-extension page. Maybe this belongs in GlicMessagingBrowserTest?

Wei Guo

Can you clarify what 'offending' mean here? Does it mean this is the only test that requires "serviceworker" as the custom_arg?

Justin DeWitt

yeah, I'm still not clear on how the tests are invoked twice, so was thinking that a test that loads both the component extension and a test page would cause this. If this is the only test that requires the multiple contexts then moving it out could simplify this code.

Open in Gerrit

Related details

Attention is currently required from:

• Wei Guo

Gerrit-Attention: Wei Guo <wei...@google.com>

Gerrit-Comment-Date: Mon, 01 Jun 2026 19:35:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Justin DeWitt <dew...@chromium.org>

Comment-In-Reply-To: Wei Guo <wei...@google.com>