Add request_url to TrustedHeaderClient::OnBeforeSendHeaders [chromium/src : main]

0 views

Skip to first unread message

Anatoli Hancharou (Gerrit)

unread,

2:20 PM (3 hours ago) 2:20 PM

to Colin Blundell, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Kevin McNee, James Maclean, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Attention needed from Chromium IPC Reviews

Anatoli Hancharou added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Anatoli Hancharou . resolved

blundell@ for:

service/network/*
chrome/browser/net/ websocket_browsertest.cc

andreaorru@ for:

extensions/browser/api/web_request/*
components/guest_view/browser/slim_web_view/slim_web_view_url_loader_factory_interceptor.cc

nasko@ for:

content/browser/devtools/ devtools_url_loader_interceptor.cc

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

2:30 PM (2 hours ago) 2:30 PM

to Anatoli Hancharou, Chromium IPC Reviews, Mike West, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Kevin McNee, James Maclean, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Attention needed from Mike West

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org, na...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): mk...@chromium.org, na...@chromium.org

Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)