WebRTC: Add WPT for ignoring stopping transceivers in addTransceiver [chromium/src : main]
0 views
Skip to first unread message
Harald Alvestrand (Gerrit)
May 29, 2026, 4:40:54 PM (3 days ago) May 29
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Guido Urdaneta
Harald Alvestrand added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Harald Alvestrand . resolved
The test I was reminded to write at Thursday's editors' meeting.
Related details
Attention is currently required from:
- Guido Urdaneta
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
10:01 AM (7 hours ago) 10:01 AM
to Harald Alvestrand, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Harald Alvestrand
Guido Urdaneta voted and added 1 comment![]( "Open in Gerrit")
Votes added by Guido Urdaneta
| Code-Review | +1 |
1 comment
File third_party/blink/web_tests/external/wpt/webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html
Line 359, Patchset 1 (Latest):
promise_test(async t => {Guido Urdaneta . unresolved
Should we also have a test where we verify that the direction is copied from t1 if t1 is not stopped? (haven't checked if we already have it, and it can be a separate CL)
Related details
Attention is currently required from:
- Harald Alvestrand
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harald Alvestrand (Gerrit)
3:08 PM (2 hours ago) 3:08 PM
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Harald Alvestrand voted and added 2 comments![]( "Open in Gerrit")
Votes added by Harald Alvestrand
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Harald Alvestrand . resolved
Thanks!
File third_party/blink/web_tests/external/wpt/webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html
Line 359, Patchset 1 (Latest):
promise_test(async t => {Guido Urdaneta . resolved
Should we also have a test where we verify that the direction is copied from t1 if t1 is not stopped? (haven't checked if we already have it, and it can be a separate CL)
Harald Alvestrand
Should be easy to add, but will add as a subsequent CL.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
3:11 PM (2 hours ago) 3:11 PM
to Harald Alvestrand, Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60327.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:36 PM (17 minutes ago) 4:36 PM
to Harald Alvestrand, Blink W3C Test Autoroller, Guido Urdaneta, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
WebRTC: Add WPT for ignoring stopping transceivers in addTransceiver
This CL adds a Web Platform Test to verify that addTransceiver ignores
transceivers where the [[Stopping]] internal slot is true when copying
header extensions from existing transceivers of the same kind, matching
the spec change in w3c/webrtc-extensions#250.
Bug: webrtc:439514253
Change-Id: Ib66cfbf43de8a3b6e6bc861587128fd8bb64f015
Reviewed-by: Guido Urdaneta <gui...@chromium.org>
Commit-Queue: Harald Alvestrand <h...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639632}
Files:
- M third_party/blink/web_tests/external/wpt/webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html
Change size: S
Delta: 1 file changed, 23 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Guido Urdaneta
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages