Revert "[ChromeAndroidTask] Support activity-scoped features" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Feb 19, 2026, 8:13:08 PM (5 hours ago) Feb 19
to Charles Hager, AyeAye, Sirisha Kavuluru, Chromium LUCI CQ, Lijin Shen, Linyu He, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Lijin Shen, Linyu He and Sirisha Kavuluru

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lijin Shen
  • Linyu He
  • Sirisha Kavuluru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7eae261c291b00af13c42cfa72c0f121cc5a2e55
Gerrit-Change-Number: 7596443
Gerrit-PatchSet: 1
Gerrit-Owner: Charles Hager <clh...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lijin Shen <laz...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Lijin Shen <laz...@google.com>
Gerrit-Attention: Linyu He <lin...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:13:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Charles Hager (Gerrit)

unread,
Feb 19, 2026, 8:13:15 PM (5 hours ago) Feb 19
to Rubber Stamper, AyeAye, Sirisha Kavuluru, Chromium LUCI CQ, Lijin Shen, Linyu He, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Lijin Shen, Linyu He and Sirisha Kavuluru

Charles Hager voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lijin Shen
  • Linyu He
  • Sirisha Kavuluru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7eae261c291b00af13c42cfa72c0f121cc5a2e55
Gerrit-Change-Number: 7596443
Gerrit-PatchSet: 1
Gerrit-Owner: Charles Hager <clh...@google.com>
Gerrit-Reviewer: Charles Hager <clh...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lijin Shen <laz...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Lijin Shen <laz...@google.com>
Gerrit-Attention: Linyu He <lin...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:13:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lijin Shen (Gerrit)

unread,
Feb 19, 2026, 8:17:59 PM (5 hours ago) Feb 19
to Charles Hager, Rubber Stamper, AyeAye, Sirisha Kavuluru, Chromium LUCI CQ, Linyu He, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Charles Hager, Linyu He and Sirisha Kavuluru

Lijin Shen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Charles Hager
  • Linyu He
  • Sirisha Kavuluru
Gerrit-Attention: Linyu He <lin...@google.com>
Gerrit-Attention: Charles Hager <clh...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:17:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Charles Hager (Gerrit)

unread,
Feb 19, 2026, 8:20:20 PM (5 hours ago) Feb 19
to Lijin Shen, Rubber Stamper, AyeAye, Sirisha Kavuluru, Chromium LUCI CQ, Linyu He, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Charles Hager, Linyu He and Sirisha Kavuluru

Charles Hager voted

Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Charles Hager
  • Linyu He
  • Sirisha Kavuluru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7eae261c291b00af13c42cfa72c0f121cc5a2e55
Gerrit-Change-Number: 7596443
Gerrit-PatchSet: 1
Gerrit-Owner: Charles Hager <clh...@google.com>
Gerrit-Reviewer: Charles Hager <clh...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lijin Shen <laz...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Linyu He <lin...@google.com>
Gerrit-Attention: Charles Hager <clh...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:20:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 19, 2026, 8:21:22 PM (5 hours ago) Feb 19
to Charles Hager, Lijin Shen, Rubber Stamper, AyeAye, Sirisha Kavuluru, Linyu He, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "[ChromeAndroidTask] Support activity-scoped features"

This reverts commit 6c54c1e246d3973e2b16b97babb345dea95afd5b.

Reason for revert: b/485992435

Original change's description:
> [ChromeAndroidTask] Support activity-scoped features
>
> This CL introduces support for features that are scoped to a specific
> ChromeActivity (via ActivityWindowAndroid) within a ChromeAndroidTask.
>
> - ChromeAndroidTaskFeatureKey: Added an optional ActivityWindowAndroid
> field to allow differentiating features by activity.
>
> - ChromeAndroidTaskImpl: Updated to destroy and remove features
> associated with an ActivityWindowAndroid when that activity's scoped
> objects are removed (e.g., during activity destruction).
>
> Bug: 483810146
> Change-Id: I85e0361f89a9db0fbb68a3d6a6dc117e2aba8bcb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7585362
> Reviewed-by: Sirisha Kavuluru <skav...@google.com>
> Commit-Queue: Lijin Shen <laz...@google.com>
> Reviewed-by: Linyu He <lin...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1587373}
Bug: 483810146
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7eae261c291b00af13c42cfa72c0f121cc5a2e55
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Lijin Shen <laz...@google.com>
Owners-Override: Charles Hager <clh...@google.com>
Commit-Queue: Charles Hager <clh...@google.com>
Cr-Commit-Position: refs/heads/main@{#1587542}
Files:
  • M chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
  • M chrome/browser/ui/android/extensions/windowing/internal/java/src/org/chromium/chrome/browser/ui/extensions/windowing/ExtensionWindowControllerBridgeIntegrationTest.java
  • M chrome/browser/ui/browser_window/internal/android/java/src/org/chromium/chrome/browser/ui/browser_window/ChromeAndroidTaskImpl.java
  • M chrome/browser/ui/browser_window/internal/android/java/src/org/chromium/chrome/browser/ui/browser_window/ChromeAndroidTaskImplUnitTest.java
  • M chrome/browser/ui/browser_window/public/android/java/src/org/chromium/chrome/browser/ui/browser_window/ChromeAndroidTaskFeatureKey.java
Change size: M
Delta: 5 files changed, 4 insertions(+), 89 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lijin Shen, Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7eae261c291b00af13c42cfa72c0f121cc5a2e55
Gerrit-Change-Number: 7596443
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages