[Extensions] Introduce feature flag for webRequest collapsed listeners [chromium/src : main]
0 views
Skip to first unread message
Emilia Paz (Gerrit)
Oct 27, 2025, 12:31:16 PM (10 days ago) Oct 27
to Andrea Orru, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Andrea Orru and Devlin Cronin
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Emilia Paz . resolved
Thanks Andrea! Could I get access to the design doc? LGTM for this intro CL
Related details
Attention is currently required from:
- Andrea Orru
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrea Orru (Gerrit)
Oct 27, 2025, 1:35:34 PM (10 days ago) Oct 27
to Emilia Paz, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Andrea Orru voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 27, 2025, 3:26:25 PM (10 days ago) Oct 27
to Andrea Orru, Emilia Paz, Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Introduce feature flag for webRequest collapsed listeners
This change is the first step required to support persistent filtered
event listeners for the webRequest API.
A new feature flag, `kEnableWebRequestCollapsedListeners`, is added and
disabled by default. When enabled, it causes the JavaScript
`WebRequestEvent` to be conditionally proxied. For service worker
contexts, it will use the new, currently unimplemented
`LazyWebRequestEventImpl`. In all other cases, it falls back to the
existing `WebRequestEventImpl`.
This change introduces no new behavior, as the new implementation is a
placeholder and the feature is turned off by default.
Design doc:
https://docs.google.com/document/d/1ExKZpUyHKDDEkOZ5SOu9bV8sJvTH0QI4qXDZ6vMiWo0/edit?usp=sharing
Bug: 448893426
Change-Id: Id0413200c083336385bd68b56fee01f9ec1e7ab6
Reviewed-by: Emilia Paz <emil...@chromium.org>
Commit-Queue: Andrea Orru <andre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536159}
Files:
- M extensions/common/extension_features.cc
- M extensions/common/extension_features.h
- M extensions/renderer/api/core_extensions_renderer_api_provider.cc
- M extensions/renderer/api/web_request_natives.cc
- M extensions/renderer/api/web_request_natives.h
- M extensions/renderer/resources/extensions_renderer_resources.grd
- A extensions/renderer/resources/lazy_web_request_event.js
- M extensions/renderer/resources/web_request_event.js
Change size: M
Delta: 8 files changed, 108 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emilia Paz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
woxxom (Gerrit)
Oct 28, 2025, 2:53:31 AM (9 days ago) Oct 28
to Chromium LUCI CQ, Andrea Orru, Emilia Paz, Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Andrea Orru
woxxom added 1 comment![]( "Open in Gerrit")
File extensions/renderer/resources/lazy_web_request_event.js
Line 15, Patchset 6 (Latest):
return 'webRequestInternal.' + eventName.substring('webRequest.'.length);woxxom . unresolved
String methods can be spoofed by the extension via String.prototype, so you'll need to use `$String`.
Since `startsWith` is [not safe-guarded currently](https://crsrc.org/extensions/renderer/safe_builtins.cc;l=91;drc=c96a878b1cb45f60aac2285ffbdbd6b53dc92415) you can use `indexOf` instead, although `slice` is just as good performance-wise, AFAIK, since it should reuse the original string buffer internally:
```js
if ($String.slice(eventName, 0, 'webRequest.'.length) === 'webRequest.') {
return 'webRequestInternal.' + $String.slice(eventName, 'webRequest.'.length);
}
```
Related details
Attention is currently required from:
- Andrea Orru
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrea Orru (Gerrit)
Oct 28, 2025, 12:46:21 PM (9 days ago) Oct 28
to Chromium LUCI CQ, woxxom, Emilia Paz, Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Andrea Orru added 1 comment![]( "Open in Gerrit")
File extensions/renderer/resources/lazy_web_request_event.js
Line 15, Patchset 6 (Latest):
return 'webRequestInternal.' + eventName.substring('webRequest.'.length);woxxom . resolved
String methods can be spoofed by the extension via String.prototype, so you'll need to use `$String`.
Since `startsWith` is [not safe-guarded currently](https://crsrc.org/extensions/renderer/safe_builtins.cc;l=91;drc=c96a878b1cb45f60aac2285ffbdbd6b53dc92415) you can use `indexOf` instead, although `slice` is just as good performance-wise, AFAIK, since it should reuse the original string buffer internally:
```js
if ($String.slice(eventName, 0, 'webRequest.'.length) === 'webRequest.') {
return 'webRequestInternal.' + $String.slice(eventName, 'webRequest.'.length);
}
```
Andrea Orru
Thanks - that makes sense. Will fix this in the next commit in the chain.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages