extensions: Add ExtensionUserScriptLoaderTest to desktop Android [chromium/src : main]

0 views
Skip to first unread message

James Cook (Gerrit)

unread,
Jan 30, 2026, 6:35:21 PM (6 hours ago) Jan 30
to Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Zoraiz Naeem

James Cook voted and added 1 comment

Votes added by James Cook

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
James Cook . resolved

Zoraiz, another small one. PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Zoraiz Naeem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id42c7079b8cf226ec01acb6aef9796134930adc5
Gerrit-Change-Number: 7536515
Gerrit-PatchSet: 1
Gerrit-Owner: James Cook <jame...@chromium.org>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Attention: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Comment-Date: Fri, 30 Jan 2026 23:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zoraiz Naeem (Gerrit)

unread,
Jan 30, 2026, 6:45:21 PM (6 hours ago) Jan 30
to James Cook, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from James Cook

Zoraiz Naeem voted and added 1 comment

Votes added by Zoraiz Naeem

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Zoraiz Naeem . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • James Cook
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id42c7079b8cf226ec01acb6aef9796134930adc5
    Gerrit-Change-Number: 7536515
    Gerrit-PatchSet: 1
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Attention: James Cook <jame...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 23:45:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 30, 2026, 7:13:45 PM (5 hours ago) Jan 30
    to James Cook, Zoraiz Naeem, Achuith Bhandarkar, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    extensions: Add ExtensionUserScriptLoaderTest to desktop Android

    Another test in //chrome/browser/extensions we need to add.
    Bug: 469417243
    Change-Id: Id42c7079b8cf226ec01acb6aef9796134930adc5
    Commit-Queue: James Cook <jame...@chromium.org>
    Commit-Queue: Zoraiz Naeem <zorai...@chromium.org>
    Reviewed-by: Zoraiz Naeem <zorai...@chromium.org>
    Auto-Submit: James Cook <jame...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1577616}
    Files:
    • M chrome/browser/extensions/extension_user_script_loader_unittest.cc
    • M chrome/test/BUILD.gn
    Change size: S
    Delta: 2 files changed, 9 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Zoraiz Naeem
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id42c7079b8cf226ec01acb6aef9796134930adc5
    Gerrit-Change-Number: 7536515
    Gerrit-PatchSet: 2
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages