ChromeAndroidTask: Add custom_tab browser window type for Android Custom Tabs [chromium/src : main]
Lijin Shen (Gerrit)
Lijin Shen added 3 comments![]( "Open in Gerrit")
case windows::CreateType::kCustomTab:I don't think we'll allow extension to create a CCT. This is probably not needed.
return api::tabs::WindowType::kCustomTab;Not sure if it is okay to return as a Popup.
Files under third_party in this Cl are auto updated by scripts.
Related details
- Linyu He
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Linyu He (Gerrit)
Linyu He added 4 comments![]( "Open in Gerrit")
Could you help review this CL? It adds a new "custom tab" window type to `BrowserWindowInterface::Type` for CCT (an Android-specific type).
Thank you!
case windows::CreateType::kCustomTab:I don't think we'll allow extension to create a CCT. This is probably not needed.
I don't think we'll allow extension to create a CCT.
I think so.
return api::tabs::WindowType::kCustomTab;Not sure if it is okay to return as a Popup.
I think we need to return `api::tabs::WindowType::kCustomTab` since custom tabs are a special window type where we don't plan to support all extension APIs in the short term.
So extensions need to know the `kCustomTab` type and that it's different from the `kPopup` type.
`browser.{h|cc}` won't be compiled into Android. Can we revert the changes here?
Related details
- Devlin Cronin
- Lijin Shen
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lijin Shen (Gerrit)
Lijin Shen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lijin Shen
| Commit-Queue | +1 |
1 comment
Linyu HeI don't think we'll allow extension to create a CCT. This is probably not needed.
I don't think we'll allow extension to create a CCT.
I think so.
- Devlin Cronin
- Linyu He
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Devlin Cronin added 5 comments![]( "Open in Gerrit")
Thanks! I think this mostly looks good, but tagging in @tjud...@chromium.org for the JSON changes
"enum": ["normal", "popup", "panel", "app", "devtools", "custom_tab"],@tjud...@chromium.org, can we nodoc an enum type while we work on it?
Otherwise, this will show up in the public documentation (for all platforms).
// TODO(crbug.com/543822): Disable automatic extern generation until fixed.As mentioned in this TODO, we can't fully auto-generate this file -- it needs custom handling
// TODO(crbug.com/543822): Disable automatic extern generation until fixed.ditto
Related details
- Lijin Shen
- Linyu He
- Tim
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lijin Shen (Gerrit)
Lijin Shen voted and added 6 comments![]( "Open in Gerrit")
Votes added by Lijin Shen
| Commit-Queue | +1 |
6 comments
return api::tabs::WindowType::kCustomTab;Not sure if it is okay to return as a Popup.
I think we need to return `api::tabs::WindowType::kCustomTab` since custom tabs are a special window type where we don't plan to support all extension APIs in the short term.
So extensions need to know the `kCustomTab` type and that it's different from the `kPopup` type.
`browser.{h|cc}` won't be compiled into Android. Can we revert the changes here?
Done
Files under third_party in this Cl are auto updated by scripts.
Done
// TODO(crbug.com/543822): Disable automatic extern generation until fixed.As mentioned in this TODO, we can't fully auto-generate this file -- it needs custom handling
Done
// TODO(crbug.com/543822): Disable automatic extern generation until fixed.- Linyu He
- Tim
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lijin Shen (Gerrit)
Lijin Shen added 1 comment![]( "Open in Gerrit")
return api::tabs::WindowType::kCustomTab;If `custom_tab` is not added into chrome/common/extensions/api/windows.json, this type will be missing. Is it okay to set `NOTREACHED()`?