[Modularization] Create a build file for //chrome/browser/gcm [chromium/src : main]
0 views
Skip to first unread message
Devlin Cronin (Gerrit)
Jan 8, 2026, 1:58:50 PM (21 hours ago) Jan 8
to Devlin Cronin, Darryl James, Nick Yamane, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, ajayramamurthy+w...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Darryl James
Devlin Cronin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Devlin Cronin . resolved
Darryl, mind taking a look?
/cc nickdiego@ since I see you own the modularization bug.
Related details
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Jan 8, 2026, 2:16:59 PM (20 hours ago) Jan 8
to Devlin Cronin, Nick Yamane, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, ajayramamurthy+w...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Devlin Cronin
Darryl James voted and added 2 comments![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
2 comments
Patchset-level comments
Darryl James . resolved
lgtm! Thank you!
File chrome/browser/gcm/BUILD.gn
Line 5, Patchset 2 (Latest):
source_set("gcm") {Darryl James . unresolved
optional: While you are here, do you mind creating the `unit_tests` target for `chrome/browser/gcm/gcm_profile_service_unittest.cc` to finish out the whole directory?
Here or in a separate CL is fine 👍
Related details
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jan 8, 2026, 2:17:38 PM (20 hours ago) Jan 8
to Devlin Cronin, Darryl James, Nick Yamane, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, ajayramamurthy+w...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Devlin Cronin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Devlin Cronin . resolved
Thanks, Darryl!
File chrome/browser/gcm/BUILD.gn
Line 5, Patchset 2 (Latest):
source_set("gcm") {Darryl James . resolved
optional: While you are here, do you mind creating the `unit_tests` target for `chrome/browser/gcm/gcm_profile_service_unittest.cc` to finish out the whole directory?
Here or in a separate CL is fine 👍
Devlin Cronin
I'll do that in a fast-follow : )
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Jan 8, 2026, 2:18:56 PM (20 hours ago) Jan 8
to Devlin Cronin, Nick Yamane, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, ajayramamurthy+w...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Devlin Cronin
Darryl James added 1 comment![]( "Open in Gerrit")
File chrome/browser/gcm/BUILD.gn
Line 5, Patchset 2 (Latest):
source_set("gcm") {Darryl James . resolved
Devlin Croninoptional: While you are here, do you mind creating the `unit_tests` target for `chrome/browser/gcm/gcm_profile_service_unittest.cc` to finish out the whole directory?
Here or in a separate CL is fine 👍
I'll do that in a fast-follow : )
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 2:20:45 PM (20 hours ago) Jan 8
to Devlin Cronin, Darryl James, Nick Yamane, chromium...@chromium.org, Peter Beverloo, ajayramamurthy+w...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Modularization] Create a build file for //chrome/browser/gcm
Pull out the files in //chrome/browser/gcm into a separate build file
and build target.
This CL should have no production behavior change.
Bug: 353332589
Change-Id: I1da5b69421838b869bb6ad1bee72f68602f167b1
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566452}
Files:
- M chrome/browser/BUILD.gn
- M chrome/browser/ash/boca/BUILD.gn
- M chrome/browser/ash/boca/receiver/BUILD.gn
- M chrome/browser/ash/cryptauth/BUILD.gn
- M chrome/browser/ash/device_sync/BUILD.gn
- M chrome/browser/extensions/BUILD.gn
- A chrome/browser/gcm/BUILD.gn
- M chrome/browser/prefs/BUILD.gn
- M chrome/browser/sync/BUILD.gn
- M chrome/browser/sync/test/integration/BUILD.gn
- M chrome/browser/ui/BUILD.gn
- M chrome/browser/web_applications/BUILD.gn
- M chrome/test/BUILD.gn
Change size: M
Delta: 13 files changed, 54 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages