Remove most base/files/file_util.h includes from headers [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Oct 30, 2025, 2:42:15 PM (6 days ago) Oct 30
to Lei Zhang, Kyle Charbonneau, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, andysjl...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, extension...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Kyle Charbonneau

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved

Please OO+1 as //base/OWNERS.

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Charbonneau
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99193a8c5ee309fdba56b6f70cc753dc08983840
Gerrit-Change-Number: 7099339
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 18:42:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kyle Charbonneau (Gerrit)

unread,
Oct 30, 2025, 4:46:12 PM (6 days ago) Oct 30
to Lei Zhang, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, andysjl...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, extension...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Lei Zhang

Kyle Charbonneau voted and added 1 comment

Votes added by Kyle Charbonneau

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
Kyle Charbonneau . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99193a8c5ee309fdba56b6f70cc753dc08983840
Gerrit-Change-Number: 7099339
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 20:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Oct 30, 2025, 4:47:39 PM (6 days ago) Oct 30
to Lei Zhang, Kyle Charbonneau, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, andysjl...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, extension...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99193a8c5ee309fdba56b6f70cc753dc08983840
Gerrit-Change-Number: 7099339
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 20:47:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 30, 2025, 6:05:12 PM (6 days ago) Oct 30
to Lei Zhang, Kyle Charbonneau, AyeAye, chromium...@chromium.org, andysjl...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, extension...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove most base/files/file_util.h includes from headers

Most headers do not need to include file_util.h. Instead, either include
file_path.h, or forward declare base::FilePath. Then do IWYU to fix the
build. Also forward declare base::FileEnumerator in one case.
Change-Id: I99193a8c5ee309fdba56b6f70cc753dc08983840
Owners-Override: Kyle Charbonneau <kyle...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538232}
Files:
  • M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
  • M chrome/browser/safe_browsing/extension_telemetry/extension_telemetry_persister.h
  • M chrome/browser/safe_browsing/extension_telemetry/extension_telemetry_service.cc
  • M chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_handler.h
  • M chrome/common/importer/firefox_importer_utils.h
  • M components/reporting/util/file.h
  • M components/reporting/util/file_unittest.cc
  • M components/safe_browsing/core/browser/ping_manager.h
  • M components/safe_browsing/core/browser/ping_manager_unittest.cc
  • M net/quic/crypto/proof_source_chromium.cc
  • M net/quic/crypto/proof_source_chromium.h
Change size: S
Delta: 11 files changed, 20 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kyle Charbonneau
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99193a8c5ee309fdba56b6f70cc753dc08983840
Gerrit-Change-Number: 7099339
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages