acm: Context menu should wrap content [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Oct 30, 2025, 5:55:59 PM (7 days ago) Oct 30
to James Cook, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, android-web...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from James Cook

Masa Fujita added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Masa Fujita . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • James Cook
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc
Gerrit-Change-Number: 7103798
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Attention: James Cook <jame...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 21:55:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 30, 2025, 5:56:03 PM (7 days ago) Oct 30
to chromium...@chromium.org, AJITH KUMAR V, chromium-a...@chromium.org, meilian...@chromium.org, davidj...@chromium.org, wychen...@chromium.org, peilinwa...@google.com, yusufo...@chromium.org, gogeral...@chromium.org, yuezhang...@chromium.org, browser-comp...@chromium.org, aji...@samsung.com, hanxi...@chromium.org, mattsimm...@chromium.org, android-web...@chromium.org, extension...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

acm: Context menu should wrap content

(acm = Action Context Menu)

This change makes sure that the context menu's width wraps content.
Bug: 409180417
Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc

Change diff

diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionActionContextMenuUtils.java b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionActionContextMenuUtils.java
index 6d6c8e73..36e52ac 100644
--- a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionActionContextMenuUtils.java
+++ b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionActionContextMenuUtils.java
@@ -121,6 +121,8 @@
                     }
                 });
 
+        buttonView.tryToFitLargestItem(true);
+
         buttonView.showMenu();
     }
 }

Change information

Files:
  • M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionActionContextMenuUtils.java
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc
Gerrit-Change-Number: 7103798
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

James Cook (Gerrit)

unread,
Oct 30, 2025, 6:11:16 PM (7 days ago) Oct 30
to Masa Fujita, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, android-web...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Masa Fujita

James Cook voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc
Gerrit-Change-Number: 7103798
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Attention: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 22:10:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 30, 2025, 6:15:33 PM (7 days ago) Oct 30
to James Cook, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, android-web...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue+2

1 comment

Patchset-level comments
Masa Fujita . resolved

Thanks for the quick review!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc
Gerrit-Change-Number: 7103798
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 22:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 30, 2025, 6:17:15 PM (7 days ago) Oct 30
to Chromium LUCI CQ, James Cook, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, android-web...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc
Gerrit-Change-Number: 7103798
Gerrit-PatchSet: 2
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 22:16:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 30, 2025, 6:59:08 PM (7 days ago) Oct 30
to Masa Fujita, James Cook, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, android-web...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
acm: Context menu should wrap content

(acm = Action Context Menu)

This change makes sure that the context menu's width wraps content.
Bug: 409180417
Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc
Commit-Queue: Masa Fujita <mas...@google.com>
Reviewed-by: James Cook <jame...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538261}
Files:
  • M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/ExtensionActionContextMenuUtils.java
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by James Cook
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I963ce12e713c45fa3568225bb6a0768f0d042fcc
Gerrit-Change-Number: 7103798
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages