Nasser Al-shawwa (Gerrit)

unread,

Oct 28, 2025, 1:05:41 AM (3 days ago) Oct 28

to Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Sophie Chang

Nasser Al-shawwa voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Oct 28, 2025, 4:57:59 AM (3 days ago) Oct 28

to Nasser Al-shawwa, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Nasser Al-shawwa and Sophie Chang

Colin Blundell added 2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Colin Blundell . resolved

Thanks!

Commit Message

Line 14, Patchset 3 (Latest):

Colin Blundell . unresolved

Can you add a bugref here to give context?

Open in Gerrit

Related details

Attention is currently required from:

Nasser Al-shawwa
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nasser Al-shawwa (Gerrit)

unread,

Oct 28, 2025, 10:13:36 AM (3 days ago) Oct 28

to Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell and Sophie Chang

Nasser Al-shawwa added 1 comment

Commit Message

Line 14, Patchset 3:

Colin Blundell . resolved

Can you add a bugref here to give context?

Nasser Al-shawwa

Done

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Oct 28, 2025, 10:16:26 AM (3 days ago) Oct 28

to Nasser Al-shawwa, Carlos IL, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Carlos IL, Nasser Al-shawwa and Sophie Chang

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Colin Blundell . resolved

Thanks! +Carlos, can you review from the safe browsing POV?

Open in Gerrit

Related details

Attention is currently required from:

Carlos IL
Nasser Al-shawwa
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Carlos IL (Gerrit)

unread,

Oct 28, 2025, 6:29:35 PM (2 days ago) Oct 28

to Nasser Al-shawwa, thefrog, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Nasser Al-shawwa, Sophie Chang and thefrog

Carlos IL added 1 comment

Patchset-level comments

File-level comment, Patchset 4:

Colin Blundell . resolved

Thanks! +Carlos, can you review from the safe browsing POV?

Carlos IL

Actually since this is specific to Safe Browsing and not interstitials in general, I'll pass this to +thefrog@ for review.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Nasser Al-shawwa
Sophie Chang
thefrog

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

thefrog (Gerrit)

unread,

Oct 29, 2025, 9:13:44 AM (2 days ago) Oct 29

to Nasser Al-shawwa, Xinghui Lu, Carlos IL, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Nasser Al-shawwa, Sophie Chang and Xinghui Lu

thefrog added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

thefrog . resolved

Replacing myself with @xing...@chromium.org who is a downloads bubble and broader downloads owner.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Nasser Al-shawwa
Sophie Chang

Xinghui Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xinghui Lu (Gerrit)

unread,

Oct 29, 2025, 11:53:32 PM (2 days ago) Oct 29

to Nasser Al-shawwa, Xinghui Lu, Carlos IL, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Nasser Al-shawwa and Sophie Chang

Xinghui Lu added 1 comment

File chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc

Line 296, Patchset 6 (Latest): return DownloadCheckResult::FORCE_SAVE_TO_GDRIVE;

Xinghui Lu . unresolved

Can we match the enum name in DownloadCheckResult to the one in TriggeredRule (DownloadCheckResult::FORCE_SAVE_TO_CLOUD)? Similarly, DOWNLOAD_DANGER_TYPE_FORCE_SAVE_TO_CLOUD.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Nasser Al-shawwa
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nasser Al-shawwa (Gerrit)

unread,

Oct 30, 2025, 9:19:59 AM (21 hours ago) Oct 30

to Xinghui Lu, Carlos IL, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Sophie Chang and Xinghui Lu

Nasser Al-shawwa added 1 comment

File chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc

Line 296, Patchset 6 (Latest): return DownloadCheckResult::FORCE_SAVE_TO_GDRIVE;

Xinghui Lu . unresolved

Can we match the enum name in DownloadCheckResult to the one in TriggeredRule (DownloadCheckResult::FORCE_SAVE_TO_CLOUD)? Similarly, DOWNLOAD_DANGER_TYPE_FORCE_SAVE_TO_CLOUD.

Nasser Al-shawwa

The use of `GDRIVE` is because other options will be added in the future; `TriggeredRule::FORCE_SAVE_TO_CLOUD` will have associated destination parameters. The easiest way to propagate this to the secure browsing extension is by having distinct values for `DownloadCheckResult`. This value will be propagated to the extension via new `DangerType` enum values in the download API. The alternative is to extend the download API which is much less trivial.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Sophie Chang
Xinghui Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xinghui Lu (Gerrit)

unread,

Oct 30, 2025, 1:33:31 PM (16 hours ago) Oct 30

to Nasser Al-shawwa, Xinghui Lu, Carlos IL, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Nasser Al-shawwa and Sophie Chang

Xinghui Lu added 1 comment

File chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc

Line 296, Patchset 6 (Latest): return DownloadCheckResult::FORCE_SAVE_TO_GDRIVE;

Xinghui Lu . unresolved

Can we match the enum name in DownloadCheckResult to the one in TriggeredRule (DownloadCheckResult::FORCE_SAVE_TO_CLOUD)? Similarly, DOWNLOAD_DANGER_TYPE_FORCE_SAVE_TO_CLOUD.

Nasser Al-shawwa

The use of `GDRIVE` is because other options will be added in the future; `TriggeredRule::FORCE_SAVE_TO_CLOUD` will have associated destination parameters. The easiest way to propagate this to the secure browsing extension is by having distinct values for `DownloadCheckResult`. This value will be propagated to the extension via new `DangerType` enum values in the download API. The alternative is to extend the download API which is much less trivial.

Xinghui Lu

I see. I didn't know that we plan to expose it to extensions. Will the destination parameters be an arbitrary endpoint or will it be represented as an enum? If the ultimate goal is to support an arbitrary endpoint, we still need to extend the download extension API at some point since the enum representation won't work anyway.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Nasser Al-shawwa
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nasser Al-shawwa (Gerrit)

unread,

Oct 30, 2025, 2:11:29 PM (16 hours ago) Oct 30

to Xinghui Lu, Carlos IL, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Sophie Chang and Xinghui Lu

Nasser Al-shawwa added 1 comment

File chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc

Line 296, Patchset 6 (Latest): return DownloadCheckResult::FORCE_SAVE_TO_GDRIVE;

Xinghui Lu . unresolved

Can we match the enum name in DownloadCheckResult to the one in TriggeredRule (DownloadCheckResult::FORCE_SAVE_TO_CLOUD)? Similarly, DOWNLOAD_DANGER_TYPE_FORCE_SAVE_TO_CLOUD.

Nasser Al-shawwa

The use of `GDRIVE` is because other options will be added in the future; `TriggeredRule::FORCE_SAVE_TO_CLOUD` will have associated destination parameters. The easiest way to propagate this to the secure browsing extension is by having distinct values for `DownloadCheckResult`. This value will be propagated to the extension via new `DangerType` enum values in the download API. The alternative is to extend the download API which is much less trivial.

Xinghui Lu

I see. I didn't know that we plan to expose it to extensions. Will the destination parameters be an arbitrary endpoint or will it be represented as an enum? If the ultimate goal is to support an arbitrary endpoint, we still need to extend the download extension API at some point since the enum representation won't work anyway.

Nasser Al-shawwa

We do not plan to support arbitrary endpoints, just GDrive and one other major vendor in a subsequent update. Any future enhancements will probably move to a native implementation as opposed to the extension.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Sophie Chang
Xinghui Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xinghui Lu (Gerrit)

unread,

Oct 30, 2025, 6:31:24 PM (12 hours ago) Oct 30

to Nasser Al-shawwa, Xinghui Lu, Carlos IL, Colin Blundell, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Nasser Al-shawwa and Sophie Chang

Xinghui Lu voted and added 1 comment

Votes added by Xinghui Lu

Code-Review

+1

1 comment

File chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc

Line 296, Patchset 6 (Latest): return DownloadCheckResult::FORCE_SAVE_TO_GDRIVE;

Xinghui Lu . resolved

Can we match the enum name in DownloadCheckResult to the one in TriggeredRule (DownloadCheckResult::FORCE_SAVE_TO_CLOUD)? Similarly, DOWNLOAD_DANGER_TYPE_FORCE_SAVE_TO_CLOUD.

Nasser Al-shawwa

The use of `GDRIVE` is because other options will be added in the future; `TriggeredRule::FORCE_SAVE_TO_CLOUD` will have associated destination parameters. The easiest way to propagate this to the secure browsing extension is by having distinct values for `DownloadCheckResult`. This value will be propagated to the extension via new `DangerType` enum values in the download API. The alternative is to extend the download API which is much less trivial.

Xinghui Lu

I see. I didn't know that we plan to expose it to extensions. Will the destination parameters be an arbitrary endpoint or will it be represented as an enum? If the ultimate goal is to support an arbitrary endpoint, we still need to extend the download extension API at some point since the enum representation won't work anyway.

Nasser Al-shawwa

We do not plan to support arbitrary endpoints, just GDrive and one other major vendor in a subsequent update. Any future enhancements will probably move to a native implementation as opposed to the extension.

Xinghui Lu

sg, thanks for the clarification.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Nasser Al-shawwa
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

4:09 AM (2 hours ago) 4:09 AM

to Nasser Al-shawwa, Xinghui Lu, Carlos IL, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, Colin Blundell

Attention needed from Nasser Al-shawwa and Sophie Chang

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Colin Blundell . resolved

Thanks! The only remaining bit you need is //components/history, so I defer to Sophie as closer OWNER there.

Open in Gerrit

Related details

Attention is currently required from:

Nasser Al-shawwa
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[Force Save to Cloud] Add DOWNLOAD_DANGER_TYPE_FORCE_SAVE_TO_GDRIVE [chromium/src : main]

Nasser Al-shawwa (Gerrit)

Nasser Al-shawwa voted Commit-Queue+1

Related details

Colin Blundell (Gerrit)

Colin Blundell added 2 comments

Related details

Nasser Al-shawwa (Gerrit)

Nasser Al-shawwa added 1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell added 1 comment

Related details

Carlos IL (Gerrit)

Carlos IL added 1 comment

Related details

thefrog (Gerrit)

thefrog added 1 comment

Related details

Xinghui Lu (Gerrit)

Xinghui Lu added 1 comment

Related details

Nasser Al-shawwa (Gerrit)

Nasser Al-shawwa added 1 comment

Related details

Xinghui Lu (Gerrit)

Xinghui Lu added 1 comment

Related details

Nasser Al-shawwa (Gerrit)

Nasser Al-shawwa added 1 comment

Related details

Xinghui Lu (Gerrit)

Xinghui Lu voted and added 1 comment

Votes added by Xinghui Lu

1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell added 1 comment

Related details