[Extensions] Add OnHostAccessRequestDismissedByUser() to menu model [chromium/src : main]
0 views
Skip to first unread message
Emilia Paz (Gerrit)
Oct 27, 2025, 5:39:24 PM (7 days ago) Oct 27
to Andrea Orru, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Andrea Orru
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Emilia Paz . resolved
Andrea, mind taking a look? Trying to load balance the CLs reviews :)
Related details
Attention is currently required from:
- Andrea Orru
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrea Orru (Gerrit)
Oct 27, 2025, 5:48:39 PM (7 days ago) Oct 27
to Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Andrea Orru voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrea Orru
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 27, 2025, 6:58:22 PM (7 days ago) Oct 27
to Emilia Paz, Andrea Orru, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Add OnHostAccessRequestDismissedByUser() to menu model
Move PermissionsManager::Observer::OnHostAccessRequestDismissedByUser
from the platform delegate views to the model.
No functionality changed.
Bug: 449814184
Change-Id: I6479cf3100838dd6c95ed2b4aeeb4f4a313657b6
Auto-Submit: Emilia Paz <emil...@chromium.org>
Reviewed-by: Andrea Orru <andre...@chromium.org>
Commit-Queue: Andrea Orru <andre...@chromium.org>
Commit-Queue: Emilia Paz <emil...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536295}
Files:
- M chrome/browser/ui/extensions/extensions_menu_view_model.cc
- M chrome/browser/ui/extensions/extensions_menu_view_model.h
- M chrome/browser/ui/extensions/extensions_menu_view_model_browsertest.cc
- M chrome/browser/ui/extensions/extensions_menu_view_platform_delegate.h
- M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.cc
- M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.h
Change size: M
Delta: 6 files changed, 45 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrea Orru
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages