[passwords] Enforce non-null presenter [chromium/src : main]

0 views
Skip to first unread message

Andrii Natiahlyi (Gerrit)

unread,
Aug 14, 2026, 6:15:09 AM (2 days ago) Aug 14
to Viktor Semeniuk, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, gcasto+w...@chromium.org, extension...@chromium.org
Attention needed from Viktor Semeniuk

Andrii Natiahlyi added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Andrii Natiahlyi . resolved

Hey Viktor, could you please take a look? Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Viktor Semeniuk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
Gerrit-Change-Number: 8256288
Gerrit-PatchSet: 3
Gerrit-Owner: Andrii Natiahlyi <nati...@google.com>
Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
Gerrit-Attention: Viktor Semeniuk <vsem...@google.com>
Gerrit-Comment-Date: Fri, 14 Aug 2026 10:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Viktor Semeniuk (Gerrit)

unread,
Aug 14, 2026, 6:20:28 AM (2 days ago) Aug 14
to Andrii Natiahlyi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, gcasto+w...@chromium.org, extension...@chromium.org
Attention needed from Andrii Natiahlyi

Viktor Semeniuk voted and added 2 comments

Votes added by Viktor Semeniuk

Code-Review+1

2 comments

Patchset-level comments
Viktor Semeniuk . resolved

LGTM, thanks

Commit Message
Line 13, Patchset 3 (Latest):Test: unit_tests --gtest_filter=*PasswordImportController*:*PasswordExportControllerTest*:*PasswordsPrivateDelegate*
Test: components_unittests --gtest_filter=*PasswordImporterTest*:*PasswordManagerExporterTest*
Test: browser_tests --gtest_filter=*PasswordsPrivateApiTest*
Viktor Semeniuk . unresolved

Remove this?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrii Natiahlyi
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
    Gerrit-Change-Number: 8256288
    Gerrit-PatchSet: 3
    Gerrit-Owner: Andrii Natiahlyi <nati...@google.com>
    Gerrit-Reviewer: Andrii Natiahlyi <nati...@google.com>
    Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
    Gerrit-Attention: Andrii Natiahlyi <nati...@google.com>
    Gerrit-Comment-Date: Fri, 14 Aug 2026 10:20:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrii Natiahlyi (Gerrit)

    unread,
    Aug 14, 2026, 6:32:57 AM (2 days ago) Aug 14
    to Viktor Semeniuk, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, gcasto+w...@chromium.org, extension...@chromium.org

    Andrii Natiahlyi added 2 comments

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Andrii Natiahlyi . resolved

    Thanks!

    Commit Message
    Line 13, Patchset 3:Test: unit_tests --gtest_filter=*PasswordImportController*:*PasswordExportControllerTest*:*PasswordsPrivateDelegate*

    Test: components_unittests --gtest_filter=*PasswordImporterTest*:*PasswordManagerExporterTest*
    Test: browser_tests --gtest_filter=*PasswordsPrivateApiTest*
    Viktor Semeniuk . resolved

    Remove this?

    Andrii Natiahlyi

    Done, though I see no harm in this 😐

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
      Gerrit-Change-Number: 8256288
      Gerrit-PatchSet: 5
      Gerrit-Owner: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
      Gerrit-Comment-Date: Fri, 14 Aug 2026 10:32:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Viktor Semeniuk <vsem...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Andrii Natiahlyi (Gerrit)

      unread,
      Aug 14, 2026, 9:01:58 AM (2 days ago) Aug 14
      to Tommy Martino, Viktor Semeniuk, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, gcasto+w...@chromium.org, extension...@chromium.org
      Attention needed from Tommy Martino

      Andrii Natiahlyi voted and added 1 comment

      Votes added by Andrii Natiahlyi

      Commit-Queue+1

      1 comment

      Patchset-level comments
      Andrii Natiahlyi . resolved

      Hey Tommy, could you please take a look at (
      c/u/u/safari_data_importer.cc &
      i/c/b/c/m/credential_importer.mm)? Thank you!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Tommy Martino
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
      Gerrit-Change-Number: 8256288
      Gerrit-PatchSet: 5
      Gerrit-Owner: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
      Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
      Gerrit-Comment-Date: Fri, 14 Aug 2026 13:01:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Tommy Martino (Gerrit)

      unread,
      Aug 14, 2026, 4:35:54 PM (2 days ago) Aug 14
      to Andrii Natiahlyi, Viktor Semeniuk, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, gcasto+w...@chromium.org, extension...@chromium.org
      Attention needed from Andrii Natiahlyi

      Tommy Martino voted and added 1 comment

      Votes added by Tommy Martino

      Code-Review+1

      1 comment

      Patchset-level comments
      Andrii Natiahlyi . resolved

      Hey Tommy, could you please take a look at (
      c/u/u/safari_data_importer.cc &
      i/c/b/c/m/credential_importer.mm)? Thank you!

      Tommy Martino

      lgtm

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrii Natiahlyi
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
      Gerrit-Change-Number: 8256288
      Gerrit-PatchSet: 5
      Gerrit-Owner: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
      Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
      Gerrit-Attention: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Comment-Date: Fri, 14 Aug 2026 20:35:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Andrii Natiahlyi <nati...@google.com>
      satisfied_requirement
      open
      diffy

      Andrii Natiahlyi (Gerrit)

      unread,
      5:30 AM (7 hours ago) 5:30 AM
      to Tommy Martino, Viktor Semeniuk, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, gcasto+w...@chromium.org, extension...@chromium.org

      Andrii Natiahlyi voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
      Gerrit-Change-Number: 8256288
      Gerrit-PatchSet: 5
      Gerrit-Owner: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
      Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
      Gerrit-Comment-Date: Sun, 16 Aug 2026 09:30:03 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      7:05 AM (6 hours ago) 7:05 AM
      to Andrii Natiahlyi, Tommy Martino, Viktor Semeniuk, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, gcasto+w...@chromium.org, extension...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [passwords] Enforce non-null presenter

      Enforce non-null SavedPasswordsPresenter across password import and
      export by passing references and storing members as const raw_ref.

      TAG=agy
      CONV=82ec360c-527d-45e9-811d-92bcf6facea4
      Bug: 352651665
      Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
      Reviewed-by: Tommy Martino <tmar...@chromium.org>
      Commit-Queue: Andrii Natiahlyi <nati...@google.com>
      Reviewed-by: Viktor Semeniuk <vsem...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1680257}
      Files:
      • M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
      • M chrome/browser/password_manager/startup_passwords_importer.cc
      • M chrome/browser/ui/passwords/settings/password_export_controller.cc
      • M chrome/browser/ui/passwords/settings/password_export_controller.h
      • M chrome/browser/ui/passwords/settings/password_export_controller_unittest.cc
      • M chrome/browser/ui/passwords/settings/password_import_controller.cc
      • M chrome/browser/ui/passwords/settings/password_import_controller.h
      • M chrome/browser/ui/passwords/settings/password_import_controller_unittest.cc
      • M components/password_manager/core/browser/export/password_manager_exporter.cc
      • M components/password_manager/core/browser/export/password_manager_exporter.h
      • M components/password_manager/core/browser/export/password_manager_exporter_unittest.cc
      • M components/password_manager/core/browser/import/password_importer.cc
      • M components/password_manager/core/browser/import/password_importer.h
      • M components/password_manager/core/browser/import/password_importer_unittest.cc
      • M components/user_data_importer/utility/safari_data_importer.cc
      • M ios/chrome/browser/credential_exchange/model/credential_importer.mm
      Change size: M
      Delta: 16 files changed, 51 insertions(+), 46 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Tommy Martino, +1 by Viktor Semeniuk
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I72fc6522a8512707c4a322e9cd34fb9526b571ba
      Gerrit-Change-Number: 8256288
      Gerrit-PatchSet: 6
      Gerrit-Owner: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Andrii Natiahlyi <nati...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
      Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages