Use more standard enumerator names in WindowFeature (browser Part1) [chromium/src : main]

0 views
Skip to first unread message

Jongmok Kim (Gerrit)

unread,
Oct 27, 2025, 7:54:06 PM (14 hours ago) Oct 27
to Xinghui Lu, Emilia Paz, Alison Gale, Zonghan Xu, Elly FJ, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Alison Gale, Emilia Paz, Xinghui Lu and Zonghan Xu

Jongmok Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Jongmok Kim . resolved

Hello, PTAL.

Could you review this?
Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
  • Emilia Paz
  • Xinghui Lu
  • Zonghan Xu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie7a665ef5b4c82eaa36f272801d59d02b0a92e51
Gerrit-Change-Number: 7086167
Gerrit-PatchSet: 6
Gerrit-Owner: Jongmok Kim <jongm...@navercorp.com>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Jongmok Kim <jongm...@navercorp.com>
Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
Gerrit-Reviewer: Zonghan Xu <xzon...@chromium.org>
Gerrit-Attention: Xinghui Lu <xing...@chromium.org>
Gerrit-Attention: Zonghan Xu <xzon...@chromium.org>
Gerrit-Attention: Emilia Paz <emil...@chromium.org>
Gerrit-Attention: Alison Gale <ag...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 23:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Oct 27, 2025, 7:57:46 PM (14 hours ago) Oct 27
to Jongmok Kim, Xinghui Lu, Alison Gale, Zonghan Xu, Elly FJ, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Alison Gale, Jongmok Kim, Xinghui Lu and Zonghan Xu

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review+1

1 comment

Patchset-level comments
Emilia Paz . resolved

/extensions LGTM, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
  • Jongmok Kim
  • Xinghui Lu
  • Zonghan Xu
Gerrit-Attention: Alison Gale <ag...@chromium.org>
Gerrit-Attention: Jongmok Kim <jongm...@navercorp.com>
Gerrit-Comment-Date: Mon, 27 Oct 2025 23:57:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Xinghui Lu (Gerrit)

unread,
Oct 27, 2025, 9:37:57 PM (12 hours ago) Oct 27
to Jongmok Kim, Xinghui Lu, Emilia Paz, Alison Gale, Zonghan Xu, Elly FJ, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Alison Gale, Jongmok Kim and Zonghan Xu

Xinghui Lu voted and added 1 comment

Votes added by Xinghui Lu

Code-Review+1

1 comment

Patchset-level comments
Xinghui Lu . resolved

download/ LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
  • Jongmok Kim
  • Zonghan Xu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie7a665ef5b4c82eaa36f272801d59d02b0a92e51
Gerrit-Change-Number: 7086167
Gerrit-PatchSet: 6
Gerrit-Owner: Jongmok Kim <jongm...@navercorp.com>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Jongmok Kim <jongm...@navercorp.com>
Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
Gerrit-Reviewer: Zonghan Xu <xzon...@chromium.org>
Gerrit-Attention: Zonghan Xu <xzon...@chromium.org>
Gerrit-Attention: Alison Gale <ag...@chromium.org>
Gerrit-Attention: Jongmok Kim <jongm...@navercorp.com>
Gerrit-Comment-Date: Tue, 28 Oct 2025 01:37:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages