Add ExtensionUnpublishedAvailability policy definition [chromium/src : main]
Anunoy Ghosh (Gerrit)
Attention is currently required from: David Bertoni, Enterprise Policy Reviews.
Anunoy Ghosh would like David Bertoni to review this change.
Add ExtensionUnpublishedAvailability policy definition
Add policy definition and policy to pref mapping. This policy allows an
admin to disable extensions that are unpublished on the Chrome Web
Store.
Bug: 1406308
Change-Id: Iaf407d09ce86366553d595737518abc6e9a05207
---
M chrome/browser/policy/configuration_policy_handler_list_factory.cc
M chrome/test/data/policy/policy_test_cases.json
M components/policy/resources/templates/policies.yaml
A components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml
M components/policy/resources/templates/policy_definitions/Extensions/policy_atomic_groups.yaml
M extensions/browser/extension_prefs.cc
M extensions/browser/pref_names.cc
M extensions/browser/pref_names.h
M tools/metrics/histograms/enums.xml
9 files changed, 118 insertions(+), 0 deletions(-)
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
Anunoy Ghosh (Gerrit)
Attention is currently required from: David Bertoni, Enterprise Policy Reviews.
gwsq (Gerrit)
Attention is currently required from: David Bertoni, Enterprise Policy Reviews, Pavol Marko.
gwsq would like Pavol Marko to review this change authored by Anunoy Ghosh.
Add ExtensionUnpublishedAvailability policy definition
Add policy definition and policy to pref mapping. This policy allows an
admin to disable extensions that are unpublished on the Chrome Web
Store.
Bug: 1406308
Change-Id: Iaf407d09ce86366553d595737518abc6e9a05207
---
M chrome/browser/policy/configuration_policy_handler_list_factory.cc
M chrome/test/data/policy/policy_test_cases.json
M components/policy/resources/templates/policies.yaml
A components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml
M components/policy/resources/templates/policy_definitions/Extensions/policy_atomic_groups.yaml
M extensions/browser/extension_prefs.cc
M extensions/browser/pref_names.cc
M extensions/browser/pref_names.h
M tools/metrics/histograms/enums.xml
9 files changed, 118 insertions(+), 0 deletions(-)
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
gwsq (Gerrit)
Attention is currently required from: David Bertoni, Pavol Marko.
Anunoy Ghosh has uploaded this change for review.
gwsq (Gerrit)
Attention is currently required from: David Bertoni, Pavol Marko.
Reviewer source(s):
pma...@chromium.org is from context(chrome/enterprise/gwsq/enterprise-policy-review.gwsq)
David Bertoni (Gerrit)
Attention is currently required from: Anunoy Ghosh, Pavol Marko.
Patch set 1:Code-Review +1
1 comment:
Patchset:
lgtm, thanks!
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
Pavol Marko (Gerrit)
Attention is currently required from: Anunoy Ghosh.
Patch set 2:Code-Review +1
3 comments:
Patchset:
LGTM % optional stuff
File components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml:
was this underscore intended?
Patch Set #2, Line 12:
extension is on the force install list, or not if the extension is pinned from Admin ConsoleOptional: An alternative would be mentioning the policy names, something like
but not if the extension is listed in the <ph name="EXTENSION_INSTALL_FORCELIST_POLICY_NAME">ExtensionInstallForcelist</ph> policy or configured as pinned to the toolbar policies in the <ph name="EXTENSION_SETTINGS_POLICY_NAME">ExtensionSettings</ph>.
Or, to make it less verbose (seeing that it repeats in the next paragraph):
but not if the extension is force-installed or pinned to the toolbar by enterprise policy (see the <ph name="EXTENSION_INSTALL_FORCELIST_POLICY_NAME">ExtensionInstallForcelist</ph> and <ph name="EXTENSION_SETTINGS_POLICY_NAME">ExtensionSettings</ph> policies).
That would avoid the reference to Admin Console, as e.g. many Windows administrators are operating on these policies directly in Windows "Group Policy".
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
Anunoy Ghosh (Gerrit)
Attention is currently required from: Pavol Marko.
3 comments:
Patchset:
Thanks for the review Pavol! Do you mind taking a look at the updated policy description one more time?
File components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml:
was this underscore intended?
No! Good eye! Fixed.
Patch Set #2, Line 12:
extension is on the force install list, or not if the extension is pinned from Admin Console
Optional: An alternative would be mentioning the policy names, something like […]
Thanks for the suggestion. I also realized that "pinning" was ambiguous since what it refers to here is version-pinning and not toolbar-pinning.
I have updated the description accordingly.
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
Pavol Marko (Gerrit)
Attention is currently required from: Anunoy Ghosh.
Patch set 3:Code-Review +1
2 comments:
File components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml:
No! Good eye! Fixed.
Done
Patch Set #2, Line 12:
extension is on the force install list, or not if the extension is pinned from Admin Console
Thanks for the suggestion. […]
TIL.
How do you version-pin an extension?
https://source.chromium.org/chromium/chromium/src/+/main:components/policy/resources/templates/policy_definitions/Extensions/ExtensionSettings.yaml;l=3?q=ExtensionSettings.yaml doesn't seem to mention version except for `minimum_version_required` while for pinning I'd expect something like max version (sorry, noob question here :-D)
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
Anunoy Ghosh (Gerrit)
Attention is currently required from: Pavol Marko.
1 comment:
File components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml:
Patch Set #2, Line 12:
extension is on the force install list, or not if the extension is pinned from Admin ConsoleTIL. […]
Version-pinning is achieved by setting override_update_url to true and setting the update_url to something other than the chrome webstore url. Enterprise admins use this technique to prevent automatic updates.
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
Anunoy Ghosh (Gerrit)
Attention is currently required from: Pavol Marko.
Patch set 3:Commit-Queue +2
Pavol Marko (Gerrit)
Attention is currently required from: Anunoy Ghosh.
1 comment:
File components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml:
Patch Set #2, Line 12:
extension is on the force install list, or not if the extension is pinned from Admin Console
Version-pinning is achieved by setting override_update_url to true and setting the update_url to som […]
thanks, learned something new today!
To view, visit change 4188995. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Add ExtensionUnpublishedAvailability policy definition
Add policy definition and policy to pref mapping. This policy allows an
admin to disable extensions that are unpublished on the Chrome Web
Store.
Bug: 1406308
Change-Id: Iaf407d09ce86366553d595737518abc6e9a05207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188995
Commit-Queue: Anunoy Ghosh <anu...@chromium.org>
Reviewed-by: David Bertoni <dber...@chromium.org>
Reviewed-by: Pavol Marko <pma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1098552}
---
M chrome/browser/policy/configuration_policy_handler_list_factory.cc
M chrome/test/data/policy/policy_test_cases.json
M components/policy/resources/templates/policies.yaml
A components/policy/resources/templates/policy_definitions/Extensions/ExtensionUnpublishedAvailability.yaml
M components/policy/resources/templates/policy_definitions/Extensions/policy_atomic_groups.yaml
M extensions/browser/extension_prefs.cc
M extensions/browser/pref_names.cc
M extensions/browser/pref_names.h
M tools/metrics/histograms/enums.xml
9 files changed, 129 insertions(+), 0 deletions(-)