[contextual-tasks] Add histograms and user actions for side panel close button. [chromium/src : main]

0 views
Skip to first unread message

Bryan Nguyen (Gerrit)

unread,
Jun 24, 2026, 6:50:52 PM (yesterday) Jun 24
to Ali Stanfield, Justin Donnelly, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitkine...@chromium.org, lens-chrome...@google.com, mercer...@google.com, stanfie...@google.com
Attention needed from Ali Stanfield and Justin Donnelly

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ali Stanfield
  • Justin Donnelly
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id43856846a16390957f5894dd73ff628dcfe5283
Gerrit-Change-Number: 7997202
Gerrit-PatchSet: 2
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Ali Stanfield <stan...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
Gerrit-Attention: Ali Stanfield <stan...@google.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 22:50:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Donnelly (Gerrit)

unread,
7:03 PM (2 hours ago) 7:03 PM
to Bryan Nguyen, Justin Donnelly, Ali Stanfield, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitkine...@chromium.org, lens-chrome...@google.com, mercer...@google.com, stanfie...@google.com
Attention needed from Ali Stanfield and Bryan Nguyen

Justin Donnelly voted and added 2 comments

Votes added by Justin Donnelly

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Justin Donnelly . unresolved

actions.xml and histograms.xml lgtm. I only skimmed the rest, please wait for Ali's review.

File chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc
Line 260, Patchset 3 (Latest): entry_source_ = EntrySource::kUnknown;
Justin Donnelly . unresolved

Is this really unknown? Or is it just that we haven't yet bothered to enumerate other cases that call this `Show` method? Maybe this should be `kOther`?

Open in Gerrit

Related details

Attention is currently required from:
  • Ali Stanfield
  • Bryan Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id43856846a16390957f5894dd73ff628dcfe5283
Gerrit-Change-Number: 7997202
Gerrit-PatchSet: 3
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Ali Stanfield <stan...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Ali Stanfield <stan...@google.com>
Gerrit-Attention: Bryan Nguyen <nguye...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 23:03:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bryan Nguyen (Gerrit)

unread,
9:25 PM (1 minute ago) 9:25 PM
to Justin Donnelly, Ali Stanfield, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitkine...@chromium.org, lens-chrome...@google.com, mercer...@google.com, stanfie...@google.com
Attention needed from Ali Stanfield

Bryan Nguyen added 1 comment

File chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc
Line 260, Patchset 3: entry_source_ = EntrySource::kUnknown;
Justin Donnelly . resolved

Is this really unknown? Or is it just that we haven't yet bothered to enumerate other cases that call this `Show` method? Maybe this should be `kOther`?

Bryan Nguyen

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Ali Stanfield
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id43856846a16390957f5894dd73ff628dcfe5283
Gerrit-Change-Number: 7997202
Gerrit-PatchSet: 4
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Ali Stanfield <stan...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Ali Stanfield <stan...@google.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 01:24:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin Donnelly <jdon...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages