[Extensions] Update comment in api_schemas.gni [chromium/src : main]

0 views
Skip to first unread message

Devlin Cronin (Gerrit)

unread,
Jan 8, 2026, 1:54:29 PM (21 hours ago) Jan 8
to Devlin Cronin, Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim

Devlin Cronin voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d7d0630d84a82b76a7602d6619f3baf434345c0
Gerrit-Change-Number: 7416085
Gerrit-PatchSet: 1
Gerrit-Owner: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Tim <tjud...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 18:54:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tim (Gerrit)

unread,
Jan 8, 2026, 2:04:25 PM (21 hours ago) Jan 8
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin

Tim voted and added 1 comment

Votes added by Tim

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tim . resolved

Well that makes more sense! LGTM!

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6d7d0630d84a82b76a7602d6619f3baf434345c0
    Gerrit-Change-Number: 7416085
    Gerrit-PatchSet: 1
    Gerrit-Owner: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 19:04:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 8, 2026, 2:39:36 PM (20 hours ago) Jan 8
    to Devlin Cronin, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Extensions] Update comment in api_schemas.gni

    The comment in api_schemas.gni for uncompiled_sources_ was incorrect.
    Update it.
    Bug: None
    Change-Id: I6d7d0630d84a82b76a7602d6619f3baf434345c0
    Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
    Reviewed-by: Tim <tjud...@chromium.org>
    Auto-Submit: Devlin Cronin <rdevlin...@chromium.org>
    Commit-Queue: Tim <tjud...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1566464}
    Files:
    • M chrome/common/extensions/api/api_sources.gni
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tim
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6d7d0630d84a82b76a7602d6619f3baf434345c0
    Gerrit-Change-Number: 7416085
    Gerrit-PatchSet: 2
    Gerrit-Owner: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages